-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
…a bunch of comments for the small gulp release tasks
This is great stuff, thank you so much for investing time in cleaning this up. |
readme will need updating |
I'm not sure i sent this: Would it make more sense to do this:
Then it would be more generalized to onejs build stack, which is what this is becoming. Maybe that could be staged, since it would imply some dependency adjustments in the appropriate projects. |
@dzearing 1. Didn't @jdhuntington say he was planning on doing that? |
…efaults. Fix a mac bug in require statement
Moving |
@jdhuntington could you move |
Closing this as we have decided to leave this plugin alone and keep it as a standalone. All the new importable gulp tasks are in https://github.com/OneJSToolkit/gulp-onejs-build |
It's what we've all been waiting for, importable gulp tasks! We no longer need to have splintered gulp tasks that all do the same thing in our various OneJS repos (and eventually 3rd party repos that want to build OneJS easily).
Overview of changes
Slight breaking change in order to make this work, we needed to modify the way gulp-common-js exposes its modules. Previously, if someone wanted to include OneJsCompiler they would do
Now since we're exposing both the compiler and gulp tasks, it needs to be further qualified
Exposed gulp tasks
Now you can easily use our gulp tasks with just a few lines
After including those few lines, you can run things like
gulp
to run the default task of building, orgulp test
,gulp dist
, etc.!All we're doing is passing our gulp, local root path, and karma instance, and now we have all of the tasks defined in
./tasks/*.js
of this repo available on the gulp instance on any project.This means by default, the user has capabilities to build amd/commonjs modules, test with karma, automate a release of their package and STILL have the ability to write their own gulp tasks in the gulp file or even overwrite our tasks.
Now, we can update these tasks, push out an update to compiler and let all users benefit from it!
Directory structure
After many email threads, we came up with a directory structure. You can see it in index.js (module.exports.gulpTasks.paths). All gulp tasks use these paths/glob helpers to make everything super normalized from OneJS project to the next.
Future work