Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pay: Adds Worldline Saferpay payment provider #1682

Merged
merged 6 commits into from
Feb 11, 2025

Conversation

Daverball
Copy link
Member

@Daverball Daverball commented Feb 11, 2025

Commit message

Pay: Adds Worldline Saferpay payment provider

TYPE: Feature
LINK: OGC-2068

Checklist

  • I have performed a self-review of my code
  • I have updated the PO files
  • I made changes/features for both org and town6
  • I have tested my code thoroughly by hand
  • I have added tests for my changes/features

Copy link

linear bot commented Feb 11, 2025

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 48.89976% with 209 lines in your changes missing coverage. Please review.

Project coverage is 88.35%. Comparing base (8b138e5) to head (aa9c2f0).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...pay/models/payment_providers/worldline_saferpay.py 49.53% 162 Missing ⚠️
src/onegov/org/views/payment.py 21.42% 22 Missing ⚠️
src/onegov/org/views/payment_provider.py 45.83% 13 Missing ⚠️
src/onegov/pay/errors.py 40.00% 6 Missing ⚠️
src/onegov/feriennet/views/invoice.py 57.14% 3 Missing ⚠️
src/onegov/org/views/form_submission.py 80.00% 1 Missing ⚠️
src/onegov/org/views/reservation.py 75.00% 1 Missing ⚠️
src/onegov/town6/views/payment_provider.py 66.66% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
src/onegov/activity/models/invoice_item.py 97.82% <100.00%> (ø)
src/onegov/org/layout.py 91.71% <ø> (ø)
src/onegov/org/views/ticket.py 86.96% <100.00%> (ø)
src/onegov/pay/integration.py 96.00% <100.00%> (+0.08%) ⬆️
src/onegov/pay/models/payment_provider.py 96.29% <100.00%> (+0.21%) ⬆️
...rc/onegov/pay/models/payment_providers/__init__.py 100.00% <100.00%> (ø)
...c/onegov/pay/models/payment_providers/datatrans.py 53.38% <ø> (ø)
src/onegov/org/views/form_submission.py 75.74% <80.00%> (-0.02%) ⬇️
src/onegov/org/views/reservation.py 85.84% <75.00%> (-0.14%) ⬇️
src/onegov/town6/views/payment_provider.py 78.94% <66.66%> (-2.31%) ⬇️
... and 5 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b138e5...aa9c2f0. Read the comment docs.

@Daverball Daverball merged commit f841f76 into master Feb 11, 2025
13 of 14 checks passed
@Daverball Daverball deleted the ogc-2068-wordline-saferpay-payment-provider branch February 11, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant