Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ogc 2017 cronjob unconfirmed subscribers #1668

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

BreathingFlesh
Copy link
Contributor

@BreathingFlesh BreathingFlesh commented Jan 28, 2025

Please fill in the commit message below and work through the checklist. You can delete parts that are not needed, e.g. the optional description, the link to a ticket or irrelevant options of the checklist.

Commit message

Org: Remove unconfirmed subscribers

Remove unconfirmed subscribers after 7 days of initial subscription. Also display date of subscription on recipients-view and export.

TYPE: Feature
LINK: OGC-2017

Checklist

  • I have performed a self-review of my code
  • I considered adding a reviewer
  • I have updated the PO files
  • I made changes/features for both org and town6
  • I have tested my code thoroughly by hand
  • I have added tests for my changes/features

Copy link

linear bot commented Jan 28, 2025

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.75%. Comparing base (382bcc6) to head (81c5140).
Report is 9 commits behind head on master.

Additional details and impacted files
Files with missing lines Coverage Δ
src/onegov/org/cronjobs.py 93.42% <100.00%> (+0.25%) ⬆️
src/onegov/org/forms/newsletter.py 87.00% <100.00%> (+0.64%) ⬆️
src/onegov/org/views/newsletter.py 96.72% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 382bcc6...81c5140. Read the comment docs.

# add some recipients the quick way
recipients = RecipientCollection(session)
recipients.add('[email protected]', confirmed=True)
recipients.add('[email protected]', confirmed=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also add an unconfirmed recipient to show the export does not include it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants