Split contents of MapFloatingPanelController into separate view controllers #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ollers - Replace Nearby Stops OBAListView with standard UICollectionView
ualch9
force-pushed
the
ualch9/concurrency
branch
from
608d43c
to
0160f7a
Compare
aaronbrethorst
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect the layout system in OBAListView is partially responsible for #660. As a hotfix, I am replacing the Recent Stops list view with a standard UICollectionView. The current search view controller was more complicated to replace, so that will stay as an OBAListView for now. To facilitate the UICollectionView and OBAListView, the two states are now separate view controllers, and MapFloatingPanelController will facilitate the view controller's lifecycles.
MapFloatingPanelController is now spaghetti, but I want to collect crash data on whether the problem is really with OBAListView's layout before cleaning up the logic.
Also, some opportunistic fixes too.