Explicitly install vscode-nls as a dependency #4980
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
features/json/projectJSONContribution.ts uses the vscode-nls package; however, up until now, it wasn't actually included as a direct dependency:
It's probably a good idea to include it so that its version can be controlled :).
(By the way, what's up with the various zero-width breaking spaces in the package.json? npm keeps trying to convert them to...something else.)