Clean up code action service and rationalize how we disallow certain Roslyn code actions #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (since it requires a dialog)
david-driscoll
approved these changes
Feb 5, 2017
| { | ||
| public static class LoggerExceptions | ||
| { | ||
| public static void LogError(this ILogger logger, Exception ex, string message, params object[] args) |
There was a problem hiding this comment.
I hate that this overload doesn't exist.
There was a problem hiding this comment.
i think the intent was to use const "categories" as event IDs, but yeah
There was a problem hiding this comment.
Yeah, I hate the event ID thing. Should be optional. There's no reason to have a "0" everywhere if you aren't using them. 😄
| }; | ||
|
|
||
| private static readonly HashSet<string> _nrefactoryListToRemove = new HashSet<string> | ||
| { | ||
| "ICSharpCode.NRefactory6.CSharp.Refactoring.CreateMethodDeclarationAction", |
There was a problem hiding this comment.
Can probably just drop this list for now (perhaps even the hashset).
Currently Refactoring Essentials isn't built with the latest roslyn dlls, so the plugins branch fails. I'll have to get some other form of unit test in there to ensure that plugins are working.
filipw
approved these changes
Feb 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/vscode-csharp#925
There's a fair amount of refactoring in this PR but most of it is moving code around.