Support project type GUID added when the .NET CLI manipulates an SLN file #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DustinCampbell nice, I wanted to do this tonight. :) |
|
I have harder deadlines than that. 😄 |
|
I want to get this one in so we can kick off a build for a new OmniSharp release. |
|
Got it. That is the GUID we use, so looks fine to me. Can't wait for the VSIX to try it out. 😄 |
willl
approved these changes
Jan 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The .NET CLI offers commands to add and remove projects from an SLN file (e.g.
dotnet sln Solution1 add Project1.csproj). When it does this, it uses a different project type GUID which we need to support in OmniSharp.cc @blackdwarf