Support .NET 7 SDKs #2377
Merged
Support .NET 7 SDKs #2377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
force-pushed
the
support-net7-sdk
branch
from
6b822a3 to
7b62a5d
Compare
JoeRobich
commented
Apr 11, 2022
| @@ -161,7 +161,7 @@ public async Task Returns_struct_kind(string filename) | |||
|
|
|||
| var usages = await FindSymbolsAsync(code, filename); | |||
| var symbols = usages.QuickFixes.Cast<SymbolLocation>().Select(q => q.Kind); | |||
| Assert.Equal("Structure", symbols.First()); | |||
| Assert.Contains(symbols.First(), new[] { "Struct", "Structure" }); | |||
There was a problem hiding this comment.
In the TypeKind enum both Struct and Structure have the same value. A runtime change must have effected the order they are returned. Either is valid since they both represent the value 10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new SdkOptions allowing users to specify a SDK path, a SDK version, and the ability to include prerelease SDKs during MSBuild locating.
In order to discover .NET 7.0 preview SDKs our hosts need to run on .NET 7.0 runtime