Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions from 6.0.1xx #2239

Merged
merged 2 commits into from
Oct 1, 2021
Merged

Conversation

nohwnd
Copy link
Contributor

@nohwnd nohwnd commented Oct 1, 2021

No description provided.

-->

<!-- These packages should match the "MicrosoftNETSdkPackageVersion" property-->
<package id="Microsoft.NET.Sdk" version="6.0.100-rc.1.21427.66" />
<package id="Microsoft.DotNet.MSBuildSdkResolver" version="6.0.100-rc.1.21427.66" />
<package id="Microsoft.NET.Sdk" version="6.0.100-rtm.21480.28" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these the ones envisioned for RTM already?!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@filipw Sorry, I don't know how to answer that. I only copied the versions from the release/6.0.1xx branch.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ideally we would have used the packages from https://github.com/dotnet/sdk/tree/release/6.0.1xx-rc2 since RC2 is about to release. Once we have a new build we can validate against RC2 and see if this is going to be a problem or not.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right - that was exactly my question here too - I thought that perhaps RC2 was not happening anymore if the RTM versions are there now? I am not privvy to all these plans 😀

@nohwnd nohwnd merged commit 443e667 into OmniSharp:master Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants