Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log request when response fails #2064

Merged
merged 2 commits into from
Jan 15, 2021
Merged

Conversation

filipw
Copy link
Member

@filipw filipw commented Jan 14, 2021

In #1963 we added a change that always logged responses at error level when an exception occurred.

This PR extends this further, and in case of exceptions, when the server is running at log level higher than Debug, additionally logs corresponding request with Warning too.

This will improve the "out of the box" troubleshooting experience.

@filipw filipw merged commit dcd2b6b into master Jan 15, 2021
@filipw filipw deleted the feature/log-request-when-response-fails branch January 15, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants