Response file can now used enviroment variables in the path + more error handling. #2008
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For custom users scripting I don't want users to have to know where the response file is so I have it defined as an environment variable. This change adds support for that. I also went ahead and added some more error handling because if the .rsp file had invalid members that errors where just thrown into the void.
I was also looking into trying to unit test the parsing of the .rsp file but it's quite difficult at the moment. I was looking at adding checks to make sure we are reading lib paths and source paths however with the current way things are laid out we don't have any accesses to the members without doing dirty reflection checking in tests which is not ideal.