Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response file can now used enviroment variables in the path + more error handling. #2008

Merged
merged 4 commits into from
Nov 20, 2020

Conversation

ByronMayne
Copy link
Contributor

For custom users scripting I don't want users to have to know where the response file is so I have it defined as an environment variable. This change adds support for that. I also went ahead and added some more error handling because if the .rsp file had invalid members that errors where just thrown into the void.

{
  "script": {
     "rspFilePath": "%PLUGIN_DIRECTORY%\\custom.rsp"
  }
}

I was also looking into trying to unit test the parsing of the .rsp file but it's quite difficult at the moment. I was looking at adding checks to make sure we are reading lib paths and source paths however with the current way things are laid out we don't have any accesses to the members without doing dirty reflection checking in tests which is not ideal.

Added more error handling to help users know what is going wrong.
@david-driscoll david-driscoll requested a review from filipw November 8, 2020 21:40
Copy link
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good, thank you

@filipw filipw merged commit 6389c11 into OmniSharp:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants