LSP: wire up handler for codeAction #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razzmatazz
changed the title
razzmatazz
force-pushed
the
lsp-code-actions
branch
2 times, most recently
from
4b759d3 to
4bb8879
Compare
razzmatazz
force-pushed
the
lsp-code-actions
branch
from
4bb8879 to
ce4e5d8
Compare
This was referenced May 16, 2020
|
@filipw would it be possible to have this one merged before the next release? As it would actually increase usability of the server within LSP context, by providing support for fix-imports and provide access to all other kinds of other refactorings available-at-point in the editor. Or do you wish to release the fix for #1791 first -- to see if something broken by that PR first -- but I would say these two are orthogonal issues. Ditto for #1799 |
|
Also, I noticed you've already added changelog line for this in your other PR: So I guess I will have to remove my changelog entry to avoid duplicate |
|
yeah we released already so this is good to merge now, I resolved the conflicts already |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds handler for LSP
textDocument/codeAction