Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for "annotations" in nullable context options #1722

Merged
merged 3 commits into from
Mar 9, 2020
Merged

added support for "annotations" in nullable context options #1722

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
923b3af
added support for "annotations" in nullable context options
filipw Feb 29, 2020
c78c494
nullable annotations
filipw Feb 29, 2020
03980f9
Merge branch 'master' into feature/nullable-annotations
bjorkstromm Mar 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
# Changelog
All changes to the project will be documented in this file.

## [1.34.14] - not yet released
* Added support for `annotations` value of `Nullable` csproj property ([#1721](https://github.com/OmniSharp/omnisharp-roslyn/issues/1721), PR: [#1722](https://github.com/OmniSharp/omnisharp-roslyn/pull/1722))

## [1.34.13] - 2020-02-19
* Fixed a bug where organizing usings clashed with other formatting settings (PR: [#1715](https://github.com/OmniSharp/omnisharp-roslyn/pull/1713))

Expand Down
1 change: 1 addition & 0 deletions src/OmniSharp.MSBuild/ProjectFile/PropertyConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ public static NullableContextOptions ToNullableContextOptions(string propertyVal
case "disable": return NullableContextOptions.Disable;
case "enable": return NullableContextOptions.Enable;
case "warnings": return NullableContextOptions.Warnings;
case "annotations": return NullableContextOptions.Annotations;
default: return NullableContextOptions.Disable;
}
}
Expand Down