Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update release date for 1.34.0 #1560

Merged
merged 2 commits into from
Jul 15, 2019
Merged

Update release date for 1.34.0 #1560

merged 2 commits into from
Jul 15, 2019

Conversation

akshita31
Copy link
Contributor

No description provided.

@akshita31 akshita31 requested a review from filipw July 15, 2019 16:58
@filipw
Copy link
Member

filipw commented Jul 15, 2019

@akshita31 can we merge #1559 before we publish the release? it should be a useful fix

@akshita31
Copy link
Contributor Author

@filipw Is it ready to be merged ?

@filipw
Copy link
Member

filipw commented Jul 15, 2019

yeah should be good to go, IMHO

@akshita31
Copy link
Contributor Author

Done!

filipw
filipw approved these changes Jul 15, 2019
View reviewed changes
Copy link
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, thanks :shipit:

@rchande rchande merged commit 79db05e into master Jul 15, 2019
@filipw filipw deleted the akshita31-patch-2 branch January 27, 2020 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipw filipw filipw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akshita31 @filipw @rchande