-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load project to hold ruleset compilation options #1440
Load project to hold ruleset compilation options #1440
Conversation
@rchande @filipw @mholo65 @david-driscoll ready for review. |
Marking as blocked until #1474 (so that this one goes first). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@savpek if you don't mind, it should be squashed on merge |
src/OmniSharp.Roslyn.CSharp/Workers/Diagnostics/CSharpDiagnosticWorkerWithAnalyzers.cs
Outdated
Show resolved
Hide resolved
Squashing is fine 🙂 |
@rchande @david-driscoll @mholo65 could you guys please have a look? imho should be good to go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. My comments are just nitpicking.
Looks like the changes have been addressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, looks like @rchande changes have been addressed as well. Going to update the branch to ensure there are no conflicts.
thanks! |
forgot to do it 😄 |
Resolves one review issue from original PR #1076 / first two bullets from #1301 and #1458.
This version loads rulesets as part of project instead of joining them to project on every analysis routine.
End user gets:
Pending