Fix find references for indexer properties #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipw
approved these changes
Mar 19, 2019
david-driscoll
approved these changes
Mar 19, 2019
There was a problem hiding this comment.
@SirIntruder thanks for your contribution! Sorry it took us so long to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed find references/code lens were broken for indexer properties, in a similar fashion to #1371. Yet this couldn't be fixed by pushing "CanBeReferencedByName" mess any more, as both get/set method and indexer property can't be referenced by name. So the PR would make sure:
Locations of usages returned by Roslyn are used as-is
When request wants locations of definitions to be added to the response, get/set methods of properties are filtered out using this. Works for both normal and indexed properties and add/remove of events . This perserves current behaviour, but removes all of the unintented side-effects.
There is a new test for indexer properties.