Code

Roslyn analyzers and code fixes#1076

Code

Merged

david-driscoll merged 245 commits intoOmniSharp:masterOmniSharp/omnisharp-roslyn:masterfrom savpek:roslyn-analyzerssavpek/omnisharp-roslyn:roslyn-analyzersCopy head branch name to clipboardMar 19, 2019

+1,723-351

Commits

Commits on Dec 25, 2017

• Moved initial logig to fork.

  savpek

  committed
  b42ac37

• Version with 'by project' results.

  savpek

  committed
  d2f872f

• Now analyzers run for all projects after startup.

  savpek

  committed
  d366b61

• Small refactorings.

  savpek

  committed
  b374a3f

• Small refactoring.

  savpek

  committed
  6ce7e66

Commits on Dec 26, 2017

• Refactored analyzers to providers.

  savpek

  committed
  cc8f251

Commits on Jan 5, 2018

• Refactored compilation as single solution bound (review fix).

  savpek

  committed
  978fbdd

• Undoed accidental change.

  savpek

  committed
  80801ed

Commits on Jan 11, 2018

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  3ec70fd

Commits on Jan 13, 2018

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  1bbd78e

Commits on Jan 26, 2018

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  e168896

Commits on Feb 8, 2018

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  e3ad473

Commits on Jul 22, 2018

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  23e47ee

• Before debugging strange type error.

  savpek

  committed
  4976660

• Simple first working version.

  savpek

  committed
  86d197a

• Cleanup.

  savpek

  committed
  544aec8

• Implemented loading from project analyzer references.

  savpek

  committed
  dc527fb

• Cleanup.

  savpek

  committed
  68fef87

• Small lazy invocation tweak.

  savpek

  committed
  e11d11b

Commits on Jul 24, 2018

• Updated cacellation token handling and way how invalid analyzer ref is handled.

  savpek

  committed
  9070f09

• Tweaked assembly discovery algorithm for analyzers.

  savpek

  committed
  5adf1a1

Commits on Jul 25, 2018

• Initial tests for analyzers.

  savpek

  committed
  1d79739

• Testfix.

  savpek

  committed
  fa2721e

• Improved tests.

  savpek

  committed
  21c670c

• Throtling to avoid certain issues with error reporting.

  savpek

  committed
  7ec5cf0

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  f0b4e2a

• Testfix.

  savpek

  committed
  a8e388a

Commits on Jul 26, 2018

• Attempt to fix hanging cake tests on travis

  savpek

  committed
  177c41b

Commits on Jul 28, 2018

• Refactored diagnostic service.

  savpek

  committed
  2d0c255

Commits on Jul 29, 2018

• Tweaks.

  savpek

  committed
  1e607cc

• Refactoring and tweaks.

  savpek

  committed
  21f91c3

• Added support for remove unnecessary usings.

  savpek

  committed
  b60d5b0

• Implemented code fixes support by project analyzer references.

  savpek

  committed
  8cc9ad2

Commits on Jul 30, 2018

• Made semantic analysis result distinct.

  savpek

  committed
  bfe05ad

• Update to distinct algorithm.

  savpek

  committed
  371271d

• Improved version but still has issues with larger projects.

  savpek

  committed
  7ed7702

• Fixes for larger project (like omnisharp).

  savpek

  committed
  b51d8f5

• Testfixes and grouping support on code check service.

  savpek

  committed
  51d0048

• Testfixes.

  savpek

  committed
  3989685

Commits on Jul 31, 2018

• Small naming fix.

  savpek

  committed
  4986456

• Implemented first version of project rulesets.

  savpek

  committed
  8511611

• Implemented test for testrules.

  savpek

  committed
  a62fdc0

• Implemented another test for rulesets.

  savpek

  committed
  786cbab

• Tweaks for analyzer responsivity.

  savpek

  committed
  bc6c9ef

• Ooppss...

  savpek

  committed
  1297a62

Commits on Aug 1, 2018

• Improved analysis threading.

  savpek

  committed
  44f79ab

• Cleanup.

  savpek

  committed
  19ee0ea

• User experience and test tweaks.

  savpek

  committed
  9e83c60

Commits on Aug 2, 2018

• Implemented final tests for rules.

  savpek

  committed
  b32b04d

• Undo for accidentally pushed change.

  savpek

  committed
  4844226

• Fixed test.

  savpek

  committed
  7ae79b0

Commits on Aug 5, 2018

• Refactored tests.

  savpek

  committed
  a06ddb6

Commits on Aug 6, 2018

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  0db9e4f

Commits on Aug 8, 2018

• Review fixes expect assembly loader from DI.

  savpek

  committed
  f10fa7b

• Merge branch 'roslyn-analyzers' of https://github.com/savpek/omnisharp-roslyn into roslyn-analyzers

  savpek

  committed
  910a365

• Sorted usings.

  savpek

  committed
  f4b829c

• DI fixes, theres currently issue during runtime however.

  savpek

  committed
  00da2a9

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  405b2bd

• Implemented missing method.

  savpek

  committed
  014865a

• Merge branch 'roslyn-analyzers' of https://github.com/savpek/omnisharp-roslyn into roslyn-analyzers

  savpek

  committed
  2dc672c

• Some testfixes, however theres changes from master that require changes still.

  savpek

  committed
  b0242ce

Commits on Aug 9, 2018

• Fix that is required for cake project system to work with diagnostics.

  savpek

  committed
  bf38248

• Removed obsolete hack.

  savpek

  committed
  9d7e2ae

Commits on Aug 10, 2018

• More robust initialization routine.

  savpek

  committed
  44949a2

• Small style tweaks.

  savpek

  committed
  b3654d4

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  b6210f0

• Removed empty class.

  savpek

  committed
  bf9db1c

• Merge branch 'roslyn-analyzers' of https://github.com/savpek/omnisharp-roslyn into roslyn-analyzers

  savpek

  committed
  74b6046

Commits on Aug 19, 2018

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  636a02f

• Some merge fixes.

  savpek

  committed
  ee18d0f

Commits on Aug 21, 2018

• Fixed mistake in wait routine.

  savpek

  committed
  bf89628

• Small readibility update.

  savpek

  committed
  8594fe8

• Added todo.

  savpek

  committed
  6575055

• Fixed support with misc files.

  savpek

  committed
  85d424f

Commits on Aug 24, 2018

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  871c1d7

• Restored null safety.

  savpek

  committed
  32b0c85

• Merge branch 'roslyn-analyzers' of https://github.com/savpek/omnisharp-roslyn into roslyn-analyzers

  savpek

  committed
  2ec0450

• Fixed mistake.

  savpek

  committed
  39e33ec

Commits on Aug 28, 2018

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  65837a9

• Review updates, however theres broken csx diagnostic tests still.

  savpek

  committed
  fa9f660

• Merge branch 'roslyn-analyzers' of https://github.com/savpek/omnisharp-roslyn into roslyn-analyzers

  savpek

  committed
  55cf797

Commits on Aug 29, 2018

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  4233203

Commits on Aug 31, 2018

• Fixed custom code actions.

  savpek

  committed
  e5ef6b3

• Testfixes.

  savpek

  committed
  c5c92f0

• Merge branch 'roslyn-analyzers' of https://github.com/savpek/omnisharp-roslyn into roslyn-analyzers

  savpek

  committed
  3aaf770

Commits on Sep 6, 2018

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  0e59d1b

Commits on Sep 9, 2018

• Small review fixes and simplified assembly loader algorithm.

  savpek

  committed
  5b9b265

• Merge branch 'roslyn-analyzers' of https://github.com/savpek/omnisharp-roslyn into roslyn-analyzers

  savpek

  committed
  902cfe1

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  3e9ec2a

• Mergefix.

  savpek

  committed
  4989125

Commits on Sep 10, 2018

• Fixed changed MiscFile project name.

  savpek

  committed
  16ef3bb

• Renamed service with better name and fixed missing language for analysis.

  savpek

  committed
  2360ee2

• Review fixes for code fix provider.

  savpek

  committed
  ec0e520

• Small tweaks for linq.

  savpek

  committed
  28a9118

• Immutablity to csharpdiagnostic service.

  savpek

  committed
  f32c8e7

Commits on Sep 12, 2018

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  abea526

Commits on Sep 13, 2018

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  6ff3af8

Commits on Sep 14, 2018

• Comment to explain non self descriptive initial wait.

  savpek

  committed
  b33dd60

• Merge branch 'roslyn-analyzers' of https://github.com/savpek/omnisharp-roslyn into roslyn-analyzers

  savpek

  committed
  d4e7a6e

Commits on Sep 16, 2018

• Support for roslyn 'IDE' analyzers.

  savpek

  committed
  51359b4

Commits on Sep 23, 2018

• Testfixes and added test that IDE analyzers are enabled.

  savpek

  committed
  862d8de

• Better comment on code based on review.

  savpek

  committed
  f64738d

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  e761e87

• Testfix for signed project.

  savpek

  committed
  9c25d64

• Testfix.

  savpek

  committed
  24f08b1

• Small test tweak.

  savpek

  committed
  1c3c989

• Buildfix.

  savpek

  committed
  a0f5258

Commits on Oct 2, 2018

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  0f41ea5

Commits on Oct 3, 2018

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  e25d686

Commits on Oct 5, 2018

• Tweaks for issue where workspace updates comes after request.

  savpek

  committed
  bf154f9

• Added assert to protect possibly internal changes of roslyn.

  savpek

  committed
  2e10c35

• Increased timeout and added comment about asserting.

  savpek

  committed
  9028a01

• Further tweaked timeouts on event mechanism asserts.

  savpek

  committed
  41ccefc

• Increased another 'assert' timeout.

  savpek

  committed
  164bae4

• Fix for threading issue in test utility.

  savpek

  committed
  02ca6cb

• Trigger to test build stability

  savpek

  committed
  39e3bdc

• Trigger to test build stability.

  savpek

  committed
  f635588

• Trigger to test build stability.

  savpek

  committed
  a6f825b

• Yet another attempt to get build execute.

  savpek

  committed
  f210d14

• Trigger build

  savpek

  committed
  f8cce2d

• Added original caller name tracking for OmnisharpTestHostDisposing.

  savpek

  committed
  dbab30c

Commits on Oct 7, 2018

• Attempt to improve robustness of tests.

  savpek

  committed
  be8f23e

• Moved tool to test utilities.

  savpek

  committed
  9cca424

• Added missing file.

  savpek

  committed
  9f64935

• Test build robustnes

  savpek

  committed
  ffe8e8a

• Test build robustnes

  savpek

  committed
  ed82a59

Commits on Oct 13, 2018

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  ed29a61

Commits on Oct 17, 2018

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  e25e934

Commits on Oct 29, 2018

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  c4dfc19

Commits on Nov 2, 2018

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  21018b9

• Fix for possible null ref issue.

  savpek

  committed
  c322d46

• Fixed mistake on exception handling when using WhenAll.

  savpek

  committed
  336a799

• Trigger build

  savpek

  committed
  acb954f

Commits on Nov 3, 2018

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  a734c16

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  6aea8d1

Commits on Nov 7, 2018

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  eba7ca5

Commits on Nov 9, 2018

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  bb93520

Commits on Nov 10, 2018

• Added fallback code to CodeCheckService, next need to figure out how to configure it.

  savpek

  committed
  c33d8f3

• Removed duplicate code.

  savpek

  committed
  c34f554

• Added flag to options.

  savpek

  committed
  c9548f6

• Use expiremental analysis as default during testing.

  savpek

  committed
  42a939a

• Disabled CsharpDiagnosticService workers if not enabled.

  savpek

  committed
  7c7d85a

• Buildfix.

  savpek

  committed
  3cab565

• Fix for codefix support when analyzers are disabled.

  savpek

  committed
  8b538a2

• Updated flag name.

  savpek

  committed
  de7426e

• Fixed default.

  savpek

  committed
  633555b

Commits on Nov 13, 2018

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  5295e9b

• Renamed flag.

  savpek

  committed
  81d743a

• Merge branch 'roslyn-analyzers' of https://github.com/savpek/omnisharp-roslyn into roslyn-analyzers

  savpek

  committed
  baa2113

Commits on Nov 14, 2018

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  ffce204

Commits on Nov 15, 2018

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  08276f1

Commits on Nov 19, 2018

• Initial structure divide for testability.

  savpek

  committed
  b4a656d

• Merge branch 'roslyn-analyzers' of https://github.com/savpek/omnisharp-roslyn into roslyn-analyzers

  savpek

  committed
  e69334e

Commits on Nov 21, 2018

• Few tests.

  savpek

  committed
  ee55e0d

Commits on Nov 25, 2018

• More tests for queue functionality.

  savpek

  committed
  ea54463

• Improved functionality to match exceptations.

  savpek

  committed
  047d5ed

• Move towards diagnosis which can be switched by common interface.

  savpek

  committed
  6528518

• Refactored ugly if switching of diagnostics behind common class.

  savpek

  committed
  180b979

Commits on Nov 26, 2018

• Implementation of api in worker with analyzers.

  savpek

  committed
  7ad625c

• Small refactoring.

  savpek

  committed
  8b1b499

• Added logging when codefix provider cannot be created.

  savpek

  committed
  5e1ab8c

Commits on Dec 4, 2018

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  c8a59ba

Commits on Dec 6, 2018

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  4e21965

• Moved to more robust time control mechanism.

  savpek

  committed
  bb5a896

• Throttling period refactoring.

  savpek

  committed
  b22d717

Commits on Dec 13, 2018

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  2d0a7af

Commits on Jan 12, 2019

• Merge branch 'roslyn-analyzers' of https://github.com/savpek/omnisharp-roslyn into roslyn-analyzers

  savpek

  committed
  6bfb484

• Merge.

  savpek

  committed
  1f0f347

Commits on Jan 17, 2019

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  d8c98fe

• Small review fix.

  savpek

  committed
  d37af46

• Small review update.

  savpek

  committed
  3ebb4fd

• Typofix.

  savpek

  committed
  6bd21bb

• Removed unused member.

  savpek

  committed
  4ac48b9

Commits on Jan 18, 2019

• Testfix.

  savpek

  committed
  6ce28fc

• Testfix.

  savpek

  committed
  eb313dd

• Restored sdk version to global.json.

  savpek

  committed
  d5b69d2

Commits on Jan 19, 2019

• Added test for multiple thead execution of queue.

  savpek

  committed
  6034988

• Parametrized tests to test both non roslyn analysis and with analysis.

  savpek

  committed
  42ec450

• Attempt to remove retry from asserts.

  savpek

  committed
  65c1398

• Removed unused code and restored correct global.json.

  savpek

  committed
  0384bc7

Commits on Jan 22, 2019

• File rename.

  savpek

  committed
  d6b8e8f

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  f69ffc7

• Merge branch 'roslyn-analyzers' of https://github.com/savpek/omnisharp-roslyn into roslyn-analyzers

  savpek

  committed
  17854f5

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  475bcef

• Added test to queue facts.

  savpek

  committed
  421ef74

• Merge branch 'roslyn-analyzers' of https://github.com/savpek/omnisharp-roslyn into roslyn-analyzers

  savpek

  committed
  f074e79

Commits on Jan 27, 2019

• Conditional action facts with and without analyzers.

  savpek

  committed
  80eb9dd

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  afe1ad6

• Small refactoring.

  savpek

  committed
  1ee7372

• Merge branch 'roslyn-analyzers' of https://github.com/savpek/omnisharp-roslyn into roslyn-analyzers

  savpek

  committed
  ff9e72b

Commits on Feb 1, 2019

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  cdb30d0

Commits on Feb 9, 2019

• Merge lsp

  savpek

  committed
  5e049b1

• Fix for lsp merge.

  savpek

  committed
  e423278

• Merge branch 'roslyn-analyzers' of https://github.com/savpek/omnisharp-roslyn into roslyn-analyzers

  savpek

  committed
  589512d

Commits on Feb 14, 2019

• Initial version of single file analysis.

  savpek

  committed
  5e11541

Commits on Feb 16, 2019

• Fixes and tweaks for analysis, timeouts and error handling.

  savpek

  committed
  a3e11d0

• Testfixes.

  savpek

  committed
  3c8a471

• Testfixes.

  savpek

  committed
  242a28b

• Correct global.json.

  savpek

  committed
  2cd0183

• Reduced clutter from message.

  savpek

  committed
  8eeabdf

• Build stability testing.

  savpek

  committed
  811cbd9

• Testfix.

  savpek

  committed
  5dac0aa

• Test tweak.

  savpek

  committed
  9b4b1f0

• Reattempt with travis builds.

  savpek

  committed
  ad38560

• Threading fix.

  savpek

  committed
  50f25c5

• Restored task based version to fix possible deadlock with xunit scheduler.

  savpek

  committed
  be71dd7

Commits on Feb 17, 2019

• Retest builds.

  savpek

  committed
  e38e73e

• Added skip to possibly hanging cake tests as test.

  savpek

  committed
  b251e24

• Skipped more cake tests as test.

  savpek

  committed
  342a140

• Restored some cake tests to find correct hanging one.

  savpek

  committed
  a2f8a63

• Restored tests to see which one is broken one.

  savpek

  committed
  5edc6de

• Restored CodeCheckFacts

  savpek

  committed
  751f3c5

• Skipped code checks again because built was aborted.

  savpek

  committed
  856e40e

• CodeCheckFacts from cake tests unignored.

  savpek

  committed
  4753e64

• Restored Can_get_code_actions_from_roslyn to check if it is hanging one.

  savpek

  committed
  ce0358c

• Refactored initialization routine for diagnostics and updated test defaults.

  savpek

  committed
  f886c8b

• Bugfix.

  savpek

  committed
  dd98cfe

• Test build stability.

  savpek

  committed
  05c8ed5

Commits on Feb 18, 2019

• Tiny tweak for logging and comment.

  savpek

  committed
  da6089d

Commits on Feb 21, 2019

• Merge branch 'master' into roslyn-analyzers

  

  Ravi Chande

  authored
  e0c2590

Commits on Feb 22, 2019

• Simplify method

  

  Ravi Chande

  committed
  8afa925

• Review fixes.

  savpek

  committed
  76cba87

• Merge branch 'roslyn-analyzers' into pr_feedback

  savpek

  authored
  1d3965a

• Merge pull request #1 from rchande/pr_feedback

  Show description for fd9dc51
  savpek

  authored
  fd9dc51

Commits on Feb 24, 2019

• Small tweak, startup with larger projects.

  savpek

  committed
  4e4d01c

Commits on Feb 26, 2019

• Initial fixes for syntax analysis rulesets.

  savpek

  committed
  01cafcb

• Initial fix for rulesets with syntax analysis.

  savpek

  committed
  2a0cb3e

Commits on Feb 27, 2019

• Moved comment to correct location.

  savpek

  committed
  0c28cbb

• Logging improvement.

  savpek

  committed
  4250f38

• Test for CS rule apply.

  savpek

  committed
  2b11dd7

• Removed dummy variable.

  savpek

  committed
  2d81bda

• Fix for document loading.

  savpek

  committed
  1c83919

• Merge upstream/master.

  savpek

  committed
  cbc81e5

• Fixed mistake on document fetching.

  savpek

  committed
  ce6ca69

Commits on Feb 28, 2019

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  3e7edf8

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  4c49a96

• Attempt to fix duplicate key error.

  savpek

  committed
  7e4b77c

• Merge branch 'roslyn-analyzers' of https://github.com/savpek/omnisharp-roslyn into roslyn-analyzers

  savpek

  committed
  ab42b95

• Small refactoring.

  savpek

  committed
  583d68a

Commits on Mar 1, 2019

• Removed unnecessary semantic model get.

  savpek

  committed
  5abc746

Commits on Mar 14, 2019

• Merge from upstream.

  savpek

  committed
  5ab1836

• Fix for null ref error on document removal.

  savpek

  committed
  d15427c

Commits on Mar 16, 2019

• Merge remote-tracking branch 'upstream/master' into roslyn-analyzers

  savpek

  committed
  640a968

Commits on Mar 17, 2019

• Merge branch 'master' into roslyn-analyzers

  savpek

  authored
  849bf32

Commits on Mar 19, 2019

• Merge branch 'master' into roslyn-analyzers

  david-driscoll

  authored
  9b635c9