Roslyn 2.6.0 + C# 7.2

[filipw]

• upgraded to Roslyn 2.6.0
• added C# 7.2 support
• added a C# 7.2 test for scripting (scripting by design should default to latest language version)
• fixed some tests that contained invalid C#

[DustinCampbell]

Looks good! I think you found all of the places. 😄

[filipw]

@DustinCampbell thanks! there is however a weird issue on Travis which seems legit. any idea what could cause this weird exception on Mono?

�[39;49m�[31m    OmniSharp.Roslyn.CSharp.Tests.RenameFacts.Rename_DoesTheRightThingWhenDocumentIsNotFound [FAIL]
�[39;49m�[37m      System.AggregateException : One or more errors occurred.
�[39;49m�[37m      ---- System.ArgumentException : checksum must be a SHA-1 hash

The only related thing I found is this dotnet/roslyn#22794, could it be a regression on Mono of some sort?

[DustinCampbell]

I think you're right. The exception is coming from here: https://github.com/dotnet/roslyn/blob/de8b37a43d13aeea3a7a8b6bdf33e8363ada4da2/src/Workspaces/Core/Portable/Workspace/Solution/Checksum.cs#L30.

I've pinged that PR to see it can be ported to Roslyn master. I don't think this is a regression in Mono. It looks more like some subtle change in Roslyn's solution checksum caused it. I'm starting a mail thread internally to raise the priority.

[filipw]

Adding a blocked label - pending dotnet/roslyn#23722

[DustinCampbell]

@filipw : The 2.6.1 Roslyn packages are now available on nuget.org.

[filipw]

perfect! I updated this PR and now the checks are all passing 🎉

[david-driscoll]

LGTM

[filipw]

@david-driscoll @DustinCampbell I'm punching this in then 😇