Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSX project system should listen file added events #227

Closed
jrieken opened this issue May 20, 2015 · 6 comments
Closed

CSX project system should listen file added events #227

jrieken opened this issue May 20, 2015 · 6 comments
Assignees

Comments

@jrieken
Copy link
Contributor

jrieken commented May 20, 2015

I would be cool if the ScriptCS project system listens to additions and deletions of CSX files so that OmniSharp doesn't need to be restarted.

@nosami
Copy link
Contributor

nosami commented May 20, 2015

Yes!
On 20 May 2015 17:22, "Johannes Rieken" [email protected] wrote:

I would be cool if the ScriptCS project system listens to additions and
deletions of CSX files so that OmniSharp doesn't need to be restarted.


Reply to this email directly or view it on GitHub
#227.

@filipw
Copy link
Member

filipw commented May 20, 2015

does the client currently notify omnisharp at all about new document creation/deletion?

@jrieken
Copy link
Contributor Author

jrieken commented May 20, 2015

they should! there is a route /filesChanged

@jrieken jrieken closed this as completed May 20, 2015
@jrieken jrieken reopened this May 20, 2015
@jrieken
Copy link
Contributor Author

jrieken commented May 20, 2015

also on windows we could use the native file watcher, see #193

@nosami
Copy link
Contributor

nosami commented May 20, 2015

We add new cs files to a project without a watcher.
On 20 May 2015 17:55, "Johannes Rieken" [email protected] wrote:

also on windows we could use the native file watcher, see #193
#193


Reply to this email directly or view it on GitHub
#227 (comment)
.

@jrieken
Copy link
Contributor Author

jrieken commented May 21, 2015

yeah, but only when their path matches the path of another directory. So, as a first step we could add the logic here: https://github.com/OmniSharp/omnisharp-roslyn/blob/master/src/OmniSharp/Roslyn/BufferManager.cs. That would make sure new files sort even without file events

@filipw filipw added the csx label Dec 20, 2016
jmbeach pushed a commit to jmbeach/omnisharp-roslyn that referenced this issue Dec 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants