Minor updates. #509
Merged
Minor updates. #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'s empty. StringOrMarkupContent implict conversion should be nullable.
333fred
approved these changes
Jan 28, 2021
| @@ -17,9 +17,9 @@ public record StringOrMarkupContent | |||
| public MarkupContent? MarkupContent { get; } | |||
| public bool HasMarkupContent => String == null; | |||
|
|
|||
| public static implicit operator StringOrMarkupContent(string value) => new StringOrMarkupContent(value); | |||
| public static implicit operator StringOrMarkupContent?(string? value) => value is null ? null : new StringOrMarkupContent(value); | |||
There was a problem hiding this comment.
@david-driscoll doesn't look like this was addressed.
Codecov Report
@@ Coverage Diff @@
## master #509 +/- ##
==========================================
- Coverage 73.46% 69.85% -3.61%
==========================================
Files 256 256
Lines 12246 12246
Branches 827 827
==========================================
- Hits 8996 8554 -442
- Misses 3250 3428 +178
- Partials 0 264 +264
Continue to review full report at Codecov.
|
NTaylorMullen
approved these changes
Jan 28, 2021
There was a problem hiding this comment.
Excited to have a variant that doesn't require the serialization of the resolver handler ID, /cc @ToddGrun since we'll both probably want to adopt this for perf reasons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @NTaylorMullen @333fred