Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure facade interfaces get registered in external service collection #477

Merged
merged 1 commit into from
Dec 15, 2020

Conversation

david-driscoll
Copy link
Member

No description provided.

@david-driscoll david-driscoll added bug Something isn't working merge Shipit! labels Dec 15, 2020
@github-actions github-actions bot added this to the v0.19.0 milestone Dec 15, 2020
@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #477 (e6e1c3e) into master (04dc114) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #477      +/-   ##
==========================================
+ Coverage   72.63%   72.67%   +0.04%     
==========================================
  Files         254      254              
  Lines       12245    12269      +24     
  Branches      832      832              
==========================================
+ Hits         8894     8917      +23     
- Misses       3351     3352       +1     
Impacted Files Coverage Δ
...lient/LanguageClientServiceCollectionExtensions.cs 97.14% <100.00%> (+0.17%) ⬆️
...t/DebugAdapterClientServiceCollectionExtensions.cs 96.80% <100.00%> (+0.21%) ⬆️
...r/DebugAdapterServerServiceCollectionExtensions.cs 96.20% <100.00%> (+0.31%) ⬆️
...erver/LanguageServerServiceCollectionExtensions.cs 97.34% <100.00%> (+0.14%) ⬆️
src/Shared/LspRequestRouter.cs 98.00% <0.00%> (-2.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04dc114...e6e1c3e. Read the comment docs.

@mergify mergify bot merged commit 8e0377a into master Dec 15, 2020
@mergify mergify bot removed the merge Shipit! label Dec 15, 2020
@mergify mergify bot deleted the fix/facade-interfaces branch December 15, 2020 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant