Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to define the scheduler used for both input and output #458

Merged
merged 2 commits into from
Dec 5, 2020

Conversation

david-driscoll
Copy link
Member

This gives use the ability to assign a specific scheduler for both the InputHandler and OutputHandler based on configuration. This should help in more scenarios (I'm looking at you Blazor).

cc @anthony-c-martin @NTaylorMullen

@david-driscoll david-driscoll added the feature This adds some form of new functionality label Dec 5, 2020
@github-actions github-actions bot added this to the v0.19.0 milestone Dec 5, 2020
@codecov
Copy link

codecov bot commented Dec 5, 2020

Codecov Report

Merging #458 (31a2ffb) into master (60ebb3a) will decrease coverage by 0.06%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #458      +/-   ##
==========================================
- Coverage   71.44%   71.38%   -0.07%     
==========================================
  Files         251      251              
  Lines       11892    11905      +13     
  Branches      812      806       -6     
==========================================
+ Hits         8496     8498       +2     
- Misses       3396     3407      +11     
Impacted Files Coverage Δ
src/JsonRpc/JsonRpcServerOptionsExtensions.cs 0.00% <0.00%> (ø)
src/JsonRpc/OutputHandler.cs 98.27% <ø> (-0.24%) ⬇️
...red/LanguageProtocolServiceCollectionExtensions.cs 94.44% <ø> (ø)
src/JsonRpc/Connection.cs 100.00% <100.00%> (ø)
src/JsonRpc/InputHandler.cs 88.05% <100.00%> (+0.02%) ⬆️
src/JsonRpc/JsonRpcServerOptionsBase.cs 78.20% <100.00%> (+0.57%) ⬆️
...sonRpc/JsonRpcServerServiceCollectionExtensions.cs 88.81% <100.00%> (+0.38%) ⬆️
src/Shared/LspRequestRouter.cs 100.00% <0.00%> (+1.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60ebb3a...31a2ffb. Read the comment docs.

@david-driscoll david-driscoll merged commit acb618b into master Dec 5, 2020
@mergify mergify bot deleted the feature/configurable-schedulers branch December 5, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This adds some form of new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant