react to new registration type for semantic tokens #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #401 +/- ##
==========================================
- Coverage 74.72% 72.52% -2.21%
==========================================
Files 566 569 +3
Lines 13640 13778 +138
Branches 1275 1291 +16
==========================================
- Hits 10192 9992 -200
- Misses 3448 3786 +338
Continue to review full report at Codecov.
|
david-driscoll
commented
Oct 28, 2020
| @@ -36,7 +36,7 @@ public interface ISemanticTokensDeltaHandler : | |||
| [Method(TextDocumentNames.SemanticTokensRange, Direction.ClientToServer)] | |||
| [GenerateHandlerMethods] | |||
| public interface ISemanticTokensRangeHandler : IJsonRpcRequestHandler<SemanticTokensRangeParams, SemanticTokens?>, | |||
| IRegistration<SemanticTokensRegistrationOptions>, ICapability<SemanticTokensCapability>, IDoesNotParticipateInRegistration | |||
There was a problem hiding this comment.
These are just marker interfaces, so this shouldn't be a breaking change.
|
Merging in for now, no real breaking changes unless you're using the new client, which the current version won't work with. |
david-driscoll
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #397
Reference commit for latest vscode client: microsoft/vscode-languageserver-node@bb85e80
LSP reference: microsoft/language-server-protocol#1107