Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to use built in source generation #314

Merged
merged 15 commits into from
Nov 17, 2020

Conversation

david-driscoll
Copy link
Member

Leaving as a draft as source generators are still in preview (and not supported across all editors)

@github-actions github-actions bot added this to the v0.18.0 milestone Aug 14, 2020
@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #314 (9529a98) into master (508e3ac) will increase coverage by 5.34%.
The diff coverage is 96.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #314      +/-   ##
==========================================
+ Coverage   72.81%   78.16%   +5.34%     
==========================================
  Files         588      237     -351     
  Lines       14344     8647    -5697     
  Branches     1377      634     -743     
==========================================
- Hits        10445     6759    -3686     
+ Misses       3899     1888    -2011     
Impacted Files Coverage Δ
src/JsonRpc.Generators/Helpers.cs 57.40% <ø> (-1.21%) ⬇️
...nRpc/Generation/GenerateHandlerMethodsAttribute.cs 0.00% <ø> (ø)
...nRpc/Generation/GenerateRequestMethodsAttribute.cs 0.00% <ø> (ø)
...nRpc.Generators/GenerateHandlerMethodsGenerator.cs 85.16% <88.21%> (+0.91%) ⬆️
src/JsonRpc.Generators/StronglyTypedGenerator.cs 98.86% <98.86%> (ø)
...JsonRpc.Generators/RegistrationOptionsGenerator.cs 99.06% <99.06%> (ø)
src/JsonRpc.Generators/GeneratorDiagnostics.cs 100.00% <100.00%> (ø)
src/JsonRpc.Generators/Preamble.cs 100.00% <100.00%> (ø)
src/Protocol/DocumentUri.cs
... and 355 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 508e3ac...9529a98. Read the comment docs.

@github-actions github-actions bot modified the milestones: v0.18.0, v0.18.3 Nov 2, 2020
@github-actions github-actions bot modified the milestones: v0.18.3, v0.18.4 Nov 14, 2020
@david-driscoll david-driscoll force-pushed the feature/source-generators branch from 30b20ab to ba1dff3 Compare November 16, 2020 23:29
@david-driscoll david-driscoll marked this pull request as ready for review November 17, 2020 03:26
@david-driscoll david-driscoll merged commit 7b4f140 into master Nov 17, 2020
@david-driscoll david-driscoll added the enhancement New feature or request label Nov 17, 2020
@mergify mergify bot deleted the feature/source-generators branch November 17, 2020 04:21
@github-actions github-actions bot modified the milestones: v0.18.4, v0.19.0 Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants