Skip to content

contract(OMN-9043): add contract + DoD receipts for hardcoded-path enforcement - #952

Merged
jonahgabriel merged 2 commits into
mainfrom
jonah/omn-9043-hardcoded-path-violations-occ
May 12, 2026
Merged

jonahgabriel merged 2 commits into
mainfrom
jonah/omn-9043-hardcoded-path-violations-occ

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented May 12, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Delivery PRs

Ticket

OMN-9043

Summary by CodeRabbit

  • New Features

    • Pre-commit validation now prevents hardcoded-path violations across projects.
    • Validation returns explicit failure signal when dependencies are unavailable.
  • Tests

    • Added validation evidence receipts confirming expected behavior.

Review Change Stack

…forcement

Binds omniclaude PR #1570 (fail-loud fix for validator_local_paths import error)
and omnibase_core PR #1065 (check-local-paths pre-commit hook addition).
@coderabbitai

coderabbitai Bot commented May 12, 2026 •

Copy link
Copy Markdown

Warning

Rate limit exceeded

@jonahgabriel has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 11 minutes and 14 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 903a4cbe-b9fc-4d10-a918-5d9ecd2ac4e2

📥 Commits

Reviewing files that changed from the base of the PR and between ea22627 and 4324368.

📒 Files selected for processing (2)
  • contracts/OMN-9043.yaml
  • drift/dod_receipts/OMN-9043/dod-occ-pr/command.yaml
📝 Walkthrough

Walkthrough

This PR adds ticket OMN-9043 documenting the requirement to wire the check-local-paths validator as a pre-commit hook in omniclaude and omnibase_core, ensuring loud failure when the validator is not importable. It includes two DOD receipt files providing verification evidence that this behavior has been checked and confirmed.

Changes

OMN-9043 Hardcoded-Path Validator Wiring

Layer / File(s) Summary
Ticket contract definition
contracts/OMN-9043.yaml
Ticket defines the requirement to wire the check-local-paths validator as a pre-commit hook with exit code 1 on import failure, exclude tests/fixtures/ via annotations, remove stale baseline, and include CI evidence requirements with emergency bypass disabled.
Definition of Done evidence
drift/dod_receipts/OMN-9043/dod-001/command.yaml, drift/dod_receipts/OMN-9043/dod-002/command.yaml
Two command receipt files document verification: dod-001 records the fail-loud exit-code transition (0 → 1) when validator import fails, and dod-002 records a passing command check confirming the integration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A ticket was born, so structured and fine,
To prevent hardcoded paths, by design,
With receipts as proof of the validation's might,
The validator now guards with a fail, bold and bright!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main changeset: adding a contract definition and Definition of Done receipts for the OMN-9043 ticket related to hardcoded-path enforcement.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-9043-hardcoded-path-violations-occ

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonahgabriel
jonahgabriel enabled auto-merge (squash) May 12, 2026 15:45
The verify/verify gate requires at least one receipt binding to the OCC
PR number. Add dod-occ-pr to the contract and a corresponding receipt
with pr_number: 952 to satisfy the pr_ticket_mismatch check.
@jonahgabriel
jonahgabriel merged commit 50aa927 into main May 12, 2026
27 of 28 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-9043-hardcoded-path-violations-occ branch May 12, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant