Skip to content

fix(OMN-10278): prefix dod-001/session-id-bridge/occ-pr-912 check_values with $CONTRACT_REPO_DIR - #920

Merged
jonahgabriel merged 2 commits into
mainfrom
jonah/omn-10278-fix-dod-relative-paths
May 10, 2026
Merged

jonahgabriel merged 2 commits into
mainfrom
jonah/omn-10278-fix-dod-relative-paths

Conversation

@jonahgabriel

Copy link
Copy Markdown
Contributor

Summary

  • Fixes 3 DoD check_values in contracts/OMN-10278.yaml that used bare relative paths
  • dod-001, dod-session-id-bridge, and dod-occ-pr-912 used drift/dod_receipts/... which resolves against the calling repo workspace (omnibase_compat) in CI, not the OCC clone at /tmp/onex_change_control
  • Prefixed all 3 with $CONTRACT_REPO_DIR/ to match the pattern used by all other 9 DoD items in the same contract

Root Cause

The CI script (run_contract_compliance_check.py) runs sh -c <check_value> with cwd=workspace (the calling repo checkout). $CONTRACT_REPO_DIR is exported as /tmp/onex_change_control. Bare relative paths resolve into the calling repo, not OCC where the receipt files live.

Test Plan

OMN-10278
Evidence-Ticket: OMN-10278
Evidence-Source: OCC#918

…ues with \$CONTRACT_REPO_DIR

Three DoD check_values used bare relative paths (drift/dod_receipts/...) which
resolve against the calling repo workspace (omnibase_compat checkout) in CI, not
the OCC clone. Prefix with \$CONTRACT_REPO_DIR so they resolve to /tmp/onex_change_control/
where the receipt files live, matching the pattern used by all other DoD items.
@coderabbitai

coderabbitai Bot commented May 10, 2026 •

Copy link
Copy Markdown

Warning

Rate limit exceeded

@jonahgabriel has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 2 minutes and 8 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8c2b28f0-cba3-4873-a27c-c60e3cd03e9f

📥 Commits

Reviewing files that changed from the base of the PR and between cb2aacd and 86e406f.

📒 Files selected for processing (2)
  • contracts/OMN-10278.yaml
  • drift/dod_receipts/OMN-10278/dod-occ-pr-920/command.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-10278-fix-dod-relative-paths

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonahgabriel
jonahgabriel enabled auto-merge (squash) May 10, 2026 19:54
…ence item

Adds DoD evidence item dod-occ-pr-920 and receipt file binding to OCC PR #920
(the fix for bare relative paths in dod-001/session-id-bridge/occ-pr-912).
Required by receipt-gate pr_ticket_mismatch check — every OCC PR must have
a PASS receipt with its own PR number.
@jonahgabriel
jonahgabriel merged commit 910b0e8 into main May 10, 2026
28 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-10278-fix-dod-relative-paths branch May 10, 2026 20:03
jonahgabriel added a commit that referenced this pull request Aug 17, 2026
…ecord

The occ-autobind rebind for OmniNode-ai/omninode_infra#920 modified the
already-merged drift/dod_receipts/OMN-16027/dod-occ-evidence-admissibility-validator/command.yaml
in place instead of adding a net-new correction, tripping the OCC Append-Only
Gate on occ#6570.

Restores the file to its exact merged (origin/dev) bytes and adds a net-new
command.supersede.0001.yaml re-binding the evidence item to PR #920, same
remedy shape as the OMN-15800/PR-858 precedent.

Evidence-Ticket: OMN-16027
jonahgabriel added a commit that referenced this pull request Aug 17, 2026
…inode_infra#920 (#6570)

* evidence(OMN-16027): author OCC companion for OmniNode-ai/omninode_infra#920

OCC companion by node_pr_lifecycle_fix_effect (OMN-13317 F1 / OMN-13990 / OMN-14285). Product PR head bb58c1ea34a3b4343575951801a276f549916b45.

* evidence(OMN-16027): self-bind OCC#6570 + rebind contract_sha256

* fix(OMN-16027): restore append-only-violated receipt, add supersede record

The occ-autobind rebind for OmniNode-ai/omninode_infra#920 modified the
already-merged drift/dod_receipts/OMN-16027/dod-occ-evidence-admissibility-validator/command.yaml
in place instead of adding a net-new correction, tripping the OCC Append-Only
Gate on occ#6570.

Restores the file to its exact merged (origin/dev) bytes and adds a net-new
command.supersede.0001.yaml re-binding the evidence item to PR #920, same
remedy shape as the OMN-15800/PR-858 precedent.

Evidence-Ticket: OMN-16027

* fix(OMN-16027): yamlfmt-canonicalize command.supersede.0001.yaml

Pre-commit Pre-commit hook flagged this net-new receipt as not
yamlfmt-canonical (files were modified by this hook). Ran yamlfmt
v0.21.0 with the repo's .yamlfmt config over the file; the only
change is folded-scalar line-wrap position in the `reason` field.
Verified the parsed YAML value is byte-identical before/after and
the yamlfmt contamination gate (OMN-15479) passes on the result.

---------

Co-authored-by: omnimarket-bot <bot@omninode.ai>
Co-authored-by: jonahgabriel <jonah.gabriel@gmail.com>
Co-authored-by: Jonah Gray <jonah@omninode.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant