Skip to content

docs(OMN-10278): ticket contract for mandatory DI params resolver fix - #913

Merged
jonahgabriel merged 3 commits into
mainfrom
jonah/omn-10278-mandatory-di-params-contract
May 10, 2026
Merged

jonahgabriel merged 3 commits into
mainfrom
jonah/omn-10278-mandatory-di-params-contract

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented May 10, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Add OCC contract for OMN-10278 (mandatory DI params — resolver multi-param injection)
  • Contract covers omnibase_core PR 1057: RESOLVED_VIA_KNOWN_PARAMS enum + resolver Step 4 extension
  • Includes deploy verification dod_evidence (dod-005)

Evidence-Ticket: OMN-10278

Test plan

  • Contract validates against ModelTicketContract (uv run validate-yaml contracts/OMN-10278.yaml)
  • Pre-commit hooks pass

Summary by CodeRabbit

  • Chores
    • Updated contract specifications and deployment verification records.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 10, 2026 •

Copy link
Copy Markdown

Warning

Rate limit exceeded

@jonahgabriel has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 1 minute and 1 second before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e395b76c-2bd4-4f22-ba40-7737ca5f0109

📥 Commits

Reviewing files that changed from the base of the PR and between eef92f3 and e6794a5.

📒 Files selected for processing (9)
  • contracts/OMN-10278.yaml
  • drift/dod_receipts/OMN-10278/dod-005/command.yaml
  • drift/dod_receipts/OMN-10278/dod-core-known-params-enum/command.yaml
  • drift/dod_receipts/OMN-10278/dod-core-known-providers/command.yaml
  • drift/dod_receipts/OMN-10278/dod-core-pr-open/command.yaml
  • drift/dod_receipts/OMN-10278/dod-core-tests/command.yaml
  • drift/dod_receipts/OMN-10278/dod-occ-pr-912/command.yaml
  • drift/dod_receipts/OMN-10278/dod-occ-pr-913/command.yaml
  • drift/dod_receipts/OMN-10278/dod-session-id-bridge/command.yaml
📝 Walkthrough

Walkthrough

Updated contract OMN-10278 from batch commit recovery to resolver multi-parameter dependency injection verification. Replaced evidence requirements with omnibase_core PR 1057 test suite checks. Extended verification checks to include enum updates, resolver multi-param injection, unit tests, and PR status. Added deployment evidence record file with health probe and container log inspection command results.

Changes

Resolver DI Contract and Evidence

Layer / File(s) Summary
Contract Definition Update
contracts/OMN-10278.yaml
Contract title/summary rewritten for resolver multi-param DI injection focus. Evidence requirements redirected from local YAML validation to omnibase_core PR 1057 test suite and CI checks. dod-001 updated to reference RESOLVED_VIA_KNOWN_PARAMS.
Verification Checks Registry
contracts/OMN-10278.yaml
Checks list extended with four new manual validation entries: enum outcome update, resolver Step 4 multi-param known injection, unit test pass verification, and PR-open status on main. New dod-005 receipt check references command.yaml deployment assertions.
Deployment Evidence Record
drift/dod_receipts/OMN-10278/dod-005/command.yaml
New evidence record file added with schema identifiers and command-check metadata. Defines health probe via curl and container log inspection via ssh with grep for "TypeError" count. Records execution payload, probe results, and verification metadata with PASS status and exit code 0.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 Hops through contracts with DI care,
Resolvers multi-param everywhere,
Evidence receipts now come to play,
Deployment checks pass the day!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding a ticket contract for mandatory DI params resolver fix. It directly relates to the primary objective of the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-10278-mandatory-di-params-contract

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonahgabriel
jonahgabriel enabled auto-merge (squash) May 10, 2026 15:49
… fix

Replaces the stale batch-evidence-recovery contract with the correct
OMN-10278 contract for the mandatory DI params plan (resolver multi-param
injection + handler migration). Adds deploy-oriented dod_evidence pointing
at omnibase_core PR 1057.
Adds dod-005 with deploy check_value so the deploy gate can verify the
resolver change doesn't introduce handler TypeError on .201 runtime.
@jonahgabriel
jonahgabriel force-pushed the jonah/omn-10278-mandatory-di-params-contract branch 2 times, most recently from eef92f3 to f1c2252 Compare May 10, 2026 16:06

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@contracts/OMN-10278.yaml`:
- Around line 60-64: The check in the "checks" block uses check_type: command
and check_value that counts any occurrence of "pass" (grep -c 'pass') which
doesn't enforce the stated "69 green" and the description is inconsistent with
the current 42 passes; update the "check_value" to assert an exact count (for
example, count only whole-line "pass" entries and compare to the expected
number) and either change the description field to the actual expected count or
update the expected count to 69 if the PR will reach that; specifically, modify
the check_value string (the command executed by the check) to perform an exact
numeric comparison against the target (referencing the existing check_value) and
align the description field with that target number.

In `@drift/dod_receipts/OMN-10278/dod-005/command.yaml`:
- Line 10: Update the commit_sha entry in the command.yaml to the new head
commit value: replace the current commit_sha
"508757e3191018c72907c86d5ea0ec657d3166ce" with
"29764d6d291d43580882f1dcfda70487e6c694fc" so the recorded commit matches the
OmniNode-ai/omnibase_core PR `#1057` head; edit the commit_sha field in the
existing YAML (the key named commit_sha) to the new string.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 53e61817-959e-4780-ac83-943370976db0

📥 Commits

Reviewing files that changed from the base of the PR and between ff9cce9 and eef92f3.

📒 Files selected for processing (2)
  • contracts/OMN-10278.yaml
  • drift/dod_receipts/OMN-10278/dod-005/command.yaml

Comment thread contracts/OMN-10278.yaml Outdated
Comment thread drift/dod_receipts/OMN-10278/dod-005/command.yaml Outdated
@jonahgabriel
jonahgabriel force-pushed the jonah/omn-10278-mandatory-di-params-contract branch from f1c2252 to 0abc510 Compare May 10, 2026 16:08
@jonahgabriel
jonahgabriel force-pushed the jonah/omn-10278-mandatory-di-params-contract branch from 0abc510 to e6794a5 Compare May 10, 2026 16:13
@jonahgabriel
jonahgabriel merged commit 5a60ba4 into main May 10, 2026
28 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-10278-mandatory-di-params-contract branch May 10, 2026 17:43
jonahgabriel added a commit that referenced this pull request May 26, 2026
… batch (#1691)

* contracts(OMN-12208..12231): add OCC evidence for Wave 2-6 stub nodes batch

Add OCC contracts and DoD receipts for 10 omnimarket PRs (Wave 2-6 stub nodes):
- OMN-12208 (#903): node_self_healing_dispatch_orchestrator — 20 tests
- OMN-12211 (#908): node_pipeline_audit_orchestrator — 24 tests
- OMN-12216 (#909): node_recall_compute — 18 tests
- OMN-12222 (#910): Wave 5 contract_drift + verification_sweep — 42 tests
- OMN-12219 (#911): node_decision_store_orchestrator — 10 tests
- OMN-12218 (#912): node_runner_orchestrator — 13 tests
- OMN-12217 (#913): node_observability_sink_effect — 14 tests
- OMN-12228 (#914): Wave 6 design_to_plan Phase3 + generate_node — 21 tests
- OMN-12231 (#915): Wave 6 6 COMPUTE stubs — 36 tests
- OMN-12225 (#916): Wave 6 5 batch nodes — 50 tests

Also adds hardcoded_topic to the adapter_occ_contract.py allowlist to baseline
the pre-existing topic violation introduced in OMN-10278 (PR #885).

* chore: update receipt commit_sha to post-trigger-CI PR heads
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant