Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions contracts/OMN-10797.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
---
schema_version: "1.0.0"
ticket_id: OMN-10797
title: "fix(OMN-10797): condition evaluator supports quoted-literal LHS"
summary: >
OMN-10779 followup. The interactive onboarding policy uses LHS literals such as `"llm_inference" in
selected_local_services`; the evaluator was treating every LHS as a state key and raising ConditionEvaluationError.
Extend the LHS grammar to accept quoted literals; quote the affected policy conditions. Unblocks failing
Tests (Split 2/15) job on omnibase_infra.
is_seam_ticket: false
interface_change: false
interfaces_touched: []
emergency_bypass:
enabled: false
justification: ""
follow_up_ticket_id: ""
dod_evidence:
- id: dod-unit-tests
description: "All 49 condition_evaluator unit + integration tests pass on omnibase_infra branch."
source: generated
checks:
- check_type: command
check_value: "grep -q '^status: PASS$' drift/dod_receipts/OMN-10797/dod-unit-tests/command.yaml
&& grep -q '^ticket_id: OMN-10797$' drift/dod_receipts/OMN-10797/dod-unit-tests/command.yaml"
- id: dod-occ-pr
description: "Self-binding receipt for this OCC PR."
source: generated
checks:
- check_type: command
check_value: "grep -q '^status: PASS$' drift/dod_receipts/OMN-10797/dod-occ-pr/command.yaml &&
grep -q '^ticket_id: OMN-10797$' drift/dod_receipts/OMN-10797/dod-occ-pr/command.yaml"
18 changes: 18 additions & 0 deletions drift/dod_receipts/OMN-10797/dod-occ-pr/command.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
---
schema_version: "1.0.0"
ticket_id: OMN-10797
evidence_item_id: dod-occ-pr
check_type: command
check_value: "grep -q '^status: PASS$' drift/dod_receipts/OMN-10797/dod-occ-pr/command.yaml"
status: PASS
run_timestamp: 2026-05-10T06:35:00+00:00
commit_sha: 0ed2755e
runner: occ-self-binding
verifier: receipt-gate-v1
probe_command: "grep -q '^status: PASS$' drift/dod_receipts/OMN-10797/dod-occ-pr/command.yaml"
probe_stdout: |
OCC self-binding receipt for OMN-10797 condition evaluator quoted-literal LHS support
actual_output: "Self-binding receipt for OCC PR — contract and evidence for omnibase_infra fix PR #1557
(OMN-10797)."
exit_code: 0
pr_number: 904
26 changes: 26 additions & 0 deletions drift/dod_receipts/OMN-10797/dod-unit-tests/command.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
---
schema_version: "1.0.0"
ticket_id: OMN-10797
evidence_item_id: dod-unit-tests
check_type: command
check_value: "uv run pytest tests/unit/onboarding/test_condition_evaluator.py tests/integration/onboarding/test_condition_evaluator_policy_integration.py
-v"
status: PASS
run_timestamp: 2026-05-10T06:25:00+00:00
commit_sha: 0ed2755e
runner: omniclaude-ci
verifier: receipt-gate-v1
probe_command: "uv run pytest tests/unit/onboarding/test_condition_evaluator.py tests/integration/onboarding/test_condition_evaluator_policy_integration.py
-v"
probe_stdout: |
tests/integration/onboarding/test_condition_evaluator_policy_integration.py::test_policy_not_in_response_routes_local_without_llm_to_terminal PASSED
tests/integration/onboarding/test_condition_evaluator_policy_integration.py::test_policy_not_in_selected_services_routes_hybrid_without_llm_to_terminal PASSED
tests/unit/onboarding/test_condition_evaluator.py::TestQuotedLiteralLhs::test_double_quoted_literal_in_state_list_true PASSED
tests/unit/onboarding/test_condition_evaluator.py::TestQuotedLiteralLhs::test_double_quoted_literal_in_state_list_false PASSED
tests/unit/onboarding/test_condition_evaluator.py::TestQuotedLiteralLhs::test_single_quoted_literal_not_in_state_list_true PASSED
tests/unit/onboarding/test_condition_evaluator.py::TestQuotedLiteralLhs::test_quoted_literal_does_not_resolve_state PASSED
tests/unit/onboarding/test_condition_evaluator.py::TestQuotedLiteralLhs::test_quoted_literal_compound_with_state_key PASSED
49 passed
actual_output: "All 49 condition_evaluator unit + integration tests pass on omnibase_infra branch jonah/omn-10797-condition-eval-literal-lhs"
exit_code: 0
pr_number: 1557
Loading