Skip to content

fix(OMN-10782): add OCC contract and receipts for interactive executor - #901

Merged
jonahgabriel merged 3 commits into
mainfrom
jonah/omn-10782-occ-evidence
May 10, 2026
Merged

jonahgabriel merged 3 commits into
mainfrom
jonah/omn-10782-occ-evidence

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented May 10, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Add OCC contract for OMN-10782 (interactive executor)
  • Add DoD receipts: product-pr (omnibase_infra#1555), local-tests (23/23 pass), occ-contract

Ticket: OMN-10782

Test plan

  • Contract validates against ModelTicketContract
  • All pre-commit hooks pass

Summary by CodeRabbit

  • Chores
    • Added a new compliance contract specification with metadata and evidence requirements.
    • Added validation and test evidence records documenting successful unit and integration test runs (PASS).
    • Added contract presence and deployment verification confirmation records.
    • Strengthened audit trail and evidence documentation for compliance reviews.

Review Change Stack

Binds omnibase_infra PR #1555 to OMN-10782 with product-pr, local-tests,
and occ-contract evidence receipts.
@jonahgabriel
jonahgabriel enabled auto-merge (squash) May 10, 2026 04:38
@coderabbitai

coderabbitai Bot commented May 10, 2026 •

Copy link
Copy Markdown

Warning

Rate limit exceeded

@jonahgabriel has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 3 minutes and 54 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d085b48a-a972-40a3-8e27-7f75985acada

📥 Commits

Reviewing files that changed from the base of the PR and between 2eb0022 and 0740cbd.

📒 Files selected for processing (3)
  • contracts/OMN-10782.yaml
  • drift/dod_receipts/OMN-10782/dod-occ-pr-901/command.yaml
  • drift/dod_receipts/OMN-10782/dod-product-pr/command.yaml
📝 Walkthrough

Walkthrough

This PR adds contract OMN-10782 and three evidence receipts: a file-existence check, a local pytest run recording 23 passing tests, and a GitHub PR status check for PR 1555.

Changes

OMN-10782 Contract Definition and Evidence

Layer / File(s) Summary
Contract Definition
contracts/OMN-10782.yaml
Adds OMN-10782 contract with schema metadata, policy flags (is_seam_ticket, interface_change, emergency_bypass), and three dod_evidence references.
Contract File Existence Check
drift/dod_receipts/OMN-10782/dod-occ-contract/command.yaml
Evidence recording test -f contracts/OMN-10782.yaml with PASS status and exit_code: 0.
Local Test Coverage Evidence
drift/dod_receipts/OMN-10782/dod-local-tests/command.yaml
Evidence capturing uv run pytest over onboarding tests: 23 passed, probe stdout, timestamp, commit SHA, runner/verifier, and exit_code: 0.
PR Status Evidence
drift/dod_receipts/OMN-10782/dod-product-pr/command.yaml
Evidence documenting gh pr view 1555 output showing PR 1555 open against main, with PASS status and exit_code: 0.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A contract is born, evidence in hand,
Tests passing bright across every land,
Files found steady, PR open wide,
Checks recorded with timestamps beside,
OMN-10782 hops on its stride. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title clearly and specifically summarizes the main change: adding an OCC contract and receipts for the OMN-10782 ticket related to the interactive executor.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-10782-occ-evidence

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@drift/dod_receipts/OMN-10782/dod-product-pr/command.yaml`:
- Around line 6-15: The probe command requests headRefOid in check_value and
probe_command but probe_stdout does not include headRefOid; either modify the
probe to actually capture headRefOid into probe_stdout or remove headRefOid from
the --json list in check_value and probe_command so the recorded probe_stdout
matches the requested fields; update the check_value string and probe_command
string (or ensure the process that runs the gh command writes headRefOid into
probe_stdout) and keep probe_stdout, check_value and actual_output consistent.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6c1d566f-afa7-4b33-bf07-2db9a7270b70

📥 Commits

Reviewing files that changed from the base of the PR and between 6b16da8 and e4fc02d.

📒 Files selected for processing (4)
  • contracts/OMN-10782.yaml
  • drift/dod_receipts/OMN-10782/dod-local-tests/command.yaml
  • drift/dod_receipts/OMN-10782/dod-occ-contract/command.yaml
  • drift/dod_receipts/OMN-10782/dod-product-pr/command.yaml

Comment thread drift/dod_receipts/OMN-10782/dod-product-pr/command.yaml Outdated
@jonahgabriel
jonahgabriel merged commit 78af1e3 into main May 10, 2026
28 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-10782-occ-evidence branch May 10, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant