Skip to content

docs(OMN-9743): add hook resolver receipts - #818

Merged
jonahgabriel merged 2 commits into
mainfrom
jonah/omn-9743-occ-evidence
May 8, 2026
Merged

jonahgabriel merged 2 commits into
mainfrom
jonah/omn-9743-occ-evidence

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented May 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Verification

  • uv run pytest tests/test_dod_evidence_schema.py tests/test_yaml_parsing.py -q
  • uv run python scripts/lint_contract_check_values.py contracts/OMN-9743.yaml

Supports OmniNode-ai/omnibase_infra#1536.

Summary by CodeRabbit

  • Documentation

    • Added contract specifications for hook activation resolver functionality
  • Tests

    • Added verification evidence records documenting test results and lint validation checks

@coderabbitai

coderabbitai Bot commented May 8, 2026 •

Copy link
Copy Markdown

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2b0bcfce-10a6-45bc-9979-b82ae382723d

📥 Commits

Reviewing files that changed from the base of the PR and between 5eb75a1 and 4850b9f.

📒 Files selected for processing (6)
  • contracts/OMN-9743.yaml
  • drift/dod_receipts/OMN-9743/dod-hook-resolver-lint/command.yaml
  • drift/dod_receipts/OMN-9743/dod-hook-resolver-tests/command.yaml
  • drift/dod_receipts/OMN-9743/dod-occ-pr-818/command.yaml
  • drift/dod_receipts/OMN-9743/dod-pr-1536-head/command.yaml
  • drift/dod_receipts/OMN-9743/dod-precommit/command.yaml

📝 Walkthrough

Walkthrough

This pull request establishes a new change control contract for OMN-9743 documenting interface changes to HookActivationResolver, declaring a public API surface change, and providing comprehensive verification evidence from lint checks, unit and integration tests, and pre-commit validations across multiple referenced PRs and branches.

Changes

Hook Activation Resolver Contract & Evidence

Layer / File(s) Summary
Contract Metadata Definition
contracts/OMN-9743.yaml
Contract declares interface change to public API, disables emergency bypass, and references DoD evidence items for lint, test, and integration verification.
Lint & Format Verification
drift/dod_receipts/OMN-9743/dod-hook-resolver-lint/command.yaml
Ruff formatting and lint checks pass for the hook activation resolver module with exit code 0.
Unit & Integration Tests
drift/dod_receipts/OMN-9743/dod-hook-resolver-tests/command.yaml
Pytest execution confirms 5 test cases pass for hook activation resolver unit and integration coverage.
PR & Pre-commit Integration
drift/dod_receipts/OMN-9743/dod-occ-pr-818/command.yaml, drift/dod_receipts/OMN-9743/dod-pr-1536-head/command.yaml, drift/dod_receipts/OMN-9743/dod-precommit/command.yaml
Evidence records confirm PR 818 and PR 1536 validation pass and pre-commit checks pass with all linter and ONEX validation steps passing.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

A contract is born for the hook resolver bright,
With evidence receipts shining from lint to test light,
Five tests passed and pre-commits aligned,
All validation checks respectfully signed. 🐇✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title clearly describes the main change: adding documentation/evidence receipts for ticket OMN-9743 related to the hook resolver, which matches the file additions across contracts and dod_receipts directories.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-9743-occ-evidence

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonahgabriel
jonahgabriel merged commit b70ee4d into main May 8, 2026
27 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-9743-occ-evidence branch May 8, 2026 19:48
jonahgabriel added a commit that referenced this pull request Aug 6, 2026
…#6126)

* evidence(OMN-15655): OCC companion for OmniNode-ai/omninode_infra#819

Manual net-new evidence companion — the automated node_occ_companion_effect
path fired (GHA publish job 31049690178 succeeded, event_id=e380482b at
2026-08-05T21:41:34Z, consumed on .201 omninode-runtime-effects) but the
mint dispatcher failed downstream: SupersessionCheckBindingError at
21:41:42Z, preceded by "Secret resolution failed (configuration issue):
GITHUB_TOKEN", boundary-swallowed (dlq_routed=false, dlq_enabled=False) —
no completed/failed event, nothing stamped back onto #819. Confirmed
live to be a currently-active, cross-PR outage (100% failure rate on
node_occ_companion_effect across the 21:31Z/21:41Z/21:55Z window
observed on .201), not specific to this PR. Automated retrigger not
attempted given that live evidence.

Appends four dod_evidence entries to the existing OMN-15655 contract,
binding OmniNode-ai/omninode_infra#819 (round 4: re-pins the onex-dev
runtime image + readiness composition doc to omnibase_infra dev@a853500a,
the same source revision PR #818/OMN-15349 re-pins the migrate image to,
restoring SINGLE_SOURCE_REV_BUNDLE). Self-bind entry to follow once this
PR's number is known.

OMN-15655

* evidence(OMN-15655): self-bind OCC#6126 for OmniNode-ai/omninode_infra#819

OMN-15655

* fix(OMN-15655): repair stale contract_sha256 on #819 receipts

The self-bind append commit mutated contracts/OMN-15655.yaml after these
four receipts were minted, invalidating their whole-file contract_sha256
binding (occ-preflight/eligibility reason=contract_hash_mismatch). Rebind
to the current contract hash.

OMN-15655

* evidence(OMN-15655): refresh PR 819 head evidence

* fix: bind OMN-15655 PR819 validator receipt by entry hash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant