Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions contracts/OMN-10688.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
---
schema_version: "1.0.0"
ticket_id: "OMN-10688"
title: "AST-based contract-config compliance validator"
summary: >
Adds omnibase_core.validators.contract_config_compliance: an AST-based static validator that catches
three anti-patterns (bare_env_read, bus_bypass_import, missing_contract_config) in handler and script
files. Wires as pre-commit hook and CI gate feeding the quality-gate required status check.
is_seam_ticket: false
interface_change: false
interfaces_touched: []
emergency_bypass:
enabled: false
justification: ""
follow_up_ticket_id: ""
dod_evidence:
- id: "dod-unit-tests"
description: "25 unit tests in tests/unit/validators/test_contract_config_compliance.py pass on omnibase_core
PR #1053"
source: "manual"
checks:
- check_type: "command"
check_value: "grep -q '^status: PASS$' \"$CONTRACT_REPO_DIR/drift/dod_receipts/OMN-10688/dod-unit-tests/command.yaml\""
- id: "dod-pr-1053-head"
description: "Bind OMN-10688 evidence to omnibase_core PR #1053 head commit."
source: "manual"
checks:
- check_type: "command"
check_value: "gh pr view 1053 --repo OmniNode-ai/omnibase_core --json headRefOid,title"
- id: "dod-deploy"
description: "Deploy-gate evidence: pure static validator, no runtime process or service deploy required."
source: "manual"
checks:
- check_type: "command"
check_value: "grep -q '^status: PASS$' \"$CONTRACT_REPO_DIR/drift/dod_receipts/OMN-10688/dod-deploy/command.yaml\""
- id: "dod-occ-pr"
description: "OCC PR carries the OMN-10688 central contract and receipt evidence."
source: "manual"
checks:
- check_type: "command"
check_value: "grep -q '^status: PASS$' \"$CONTRACT_REPO_DIR/drift/dod_receipts/OMN-10688/dod-occ-pr/command.yaml\""
20 changes: 20 additions & 0 deletions drift/dod_receipts/OMN-10688/dod-deploy/command.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
---
schema_version: "1.0.0"
ticket_id: "OMN-10688"
evidence_item_id: "dod-deploy"
check_type: "command"
check_value: "echo 'deploy-gate: OMN-10688 adds a pure static validator; no Docker image, daemon, broker
topic, runtime process, docker exec, or service deploy is required'"
status: PASS
run_timestamp: "2026-05-08T17:00:00Z"
commit_sha: "77f98d3a287ac0750296590810196107386dc01b"
runner: "local-macos"
verifier: "adr-canary-worker"
probe_command: "echo 'deploy-gate: OMN-10688 adds a pure static validator'"
probe_stdout: |
deploy-gate: OMN-10688 adds a pure static validator; no Docker image, daemon, broker topic, runtime process, docker exec, or service deploy is required
actual_output: "PASS: OMN-10688 is a pure static analysis tool; no live deploy required before merge."
exit_code: 0
pr_number: 1053
branch: "jonah/omn-10688-contract-config-validator"
working_dir: "/workspace/omni_worktrees/OMN-10688/omnibase_core"
19 changes: 19 additions & 0 deletions drift/dod_receipts/OMN-10688/dod-occ-pr/command.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
---
schema_version: "1.0.0"
ticket_id: "OMN-10688"
evidence_item_id: "dod-occ-pr"
check_type: "command"
check_value: "grep -q '^status: PASS$' \"$CONTRACT_REPO_DIR/drift/dod_receipts/OMN-10688/dod-occ-pr/command.yaml\""
status: PASS
run_timestamp: "2026-05-08T17:00:00Z"
commit_sha: "6cc1c3ee6c88113900558a641b591358ed7ba457"
runner: "local-macos"
verifier: "adr-canary-worker"
probe_command: "gh pr view 813 --repo OmniNode-ai/onex_change_control --json number,headRefOid"
probe_stdout: |
{"number":813,"headRefOid":"6cc1c3ee6c88113900558a641b591358ed7ba457"}
actual_output: "PASS: OCC tree carries OMN-10688 central contract and receipt files bound to OCC PR #813."
exit_code: 0
pr_number: 813
branch: "jonah/omn-10688-contract"
working_dir: "/workspace/omni_worktrees/OMN-10688/onex_change_control"
19 changes: 19 additions & 0 deletions drift/dod_receipts/OMN-10688/dod-pr-1053-head/command.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
---
schema_version: "1.0.0"
ticket_id: "OMN-10688"
evidence_item_id: "dod-pr-1053-head"
check_type: "command"
check_value: "gh pr view 1053 --repo OmniNode-ai/omnibase_core --json headRefOid,title"
status: PASS
run_timestamp: "2026-05-08T17:00:00Z"
commit_sha: "77f98d3a287ac0750296590810196107386dc01b"
runner: "local-macos"
verifier: "adr-canary-worker"
probe_command: "gh pr view 1053 --repo OmniNode-ai/omnibase_core --json headRefOid,title --jq '{headRefOid,title}'"
probe_stdout: |
{"headRefOid":"77f98d3a287ac0750296590810196107386dc01b","title":"feat(OMN-10688): AST-based contract-config compliance validator"}
actual_output: "PASS: omnibase_core PR #1053 is bound to OMN-10688 at the observed PR head."
exit_code: 0
pr_number: 1053
branch: "jonah/omn-10688-contract-config-validator"
working_dir: "/workspace/omni_worktrees/OMN-10688/omnibase_core"
22 changes: 22 additions & 0 deletions drift/dod_receipts/OMN-10688/dod-unit-tests/command.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
---
schema_version: "1.0.0"
ticket_id: "OMN-10688"
evidence_item_id: "dod-unit-tests"
check_type: "command"
check_value: "cd omni_worktrees/OMN-10688/omnibase_core && env -u PYTHONPATH uv run pytest tests/unit/validators/test_contract_config_compliance.py
-q"
status: PASS
run_timestamp: "2026-05-08T17:00:00Z"
commit_sha: "77f98d3a287ac0750296590810196107386dc01b"
runner: "local-macos"
verifier: "adr-canary-worker"
probe_command: "cd omni_worktrees/OMN-10688/omnibase_core && env -u PYTHONPATH uv run pytest tests/unit/validators/test_contract_config_compliance.py
-q"
probe_stdout: |
25 passed in 2.82s
actual_output: "PASS: 25 unit tests pass for contract_config_compliance validator on omnibase_core PR
#1053."
exit_code: 0
pr_number: 1053
branch: "jonah/omn-10688-contract-config-validator"
working_dir: "/workspace/omni_worktrees/OMN-10688/omnibase_core"
Loading