Skip to content

docs(OMN-10626): add omniclaude delegation OCC evidence - #802

Merged
jonahgabriel merged 3 commits into
mainfrom
jonah/omn-10626-10656-omniclaude-occ
May 8, 2026
Merged

jonahgabriel merged 3 commits into
mainfrom
jonah/omn-10626-10656-omniclaude-occ

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented May 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds central OCC evidence for the late-night omniclaude delegation PR repairs.

  • Adds OMN-10626 contract and PASS receipts for omniclaude#1538 installer hardening.
  • Extends OMN-10656 with PASS receipts for omniclaude#1539 delegation bus bootstrap hardening while preserving the existing chore(occ-deps): update rerun state after 63381313 #1537 evidence.
  • Binds evidence to the pushed omniclaude heads 9654c86e24fb7ce322bc83631f843675b42ec6ea and 27eef6441b1c1df0c30ab3d0156978486e9a4bad.

Verification

  • uv run validate-yaml contracts/OMN-10626.yaml contracts/OMN-10656.yaml
  • OMNIBASE_INFRA_PATH=/Volumes/PRO-G40/Code/omni_home/omnibase_infra pre-commit run --files contracts/OMN-10626.yaml contracts/OMN-10656.yaml drift/dod_receipts/OMN-10626/dod-installer-tests/command.yaml drift/dod_receipts/OMN-10626/dod-precommit/command.yaml drift/dod_receipts/OMN-10626/dod-pr-1538-head/command.yaml drift/dod_receipts/OMN-10656/dod-bootstrap-tests/command.yaml drift/dod_receipts/OMN-10656/dod-bootstrap-precommit/command.yaml drift/dod_receipts/OMN-10656/dod-pr-1539-head/command.yaml

Summary by CodeRabbit

  • New Features

    • Added delegation installation script with dry-run mode, rollback manifest handling, settings merge preservation, and package install hardening for Claude Code delegation.
  • Documentation

    • Added comprehensive delivery evidence and validation test records for delegation and bootstrap features.

Additional verification

  • Local OCC eligibility PASS for omniclaude#1538, omniclaude#1539, and onex_change_control#802 against 864c1ca.

Evidence-Ticket: OMN-10626
Evidence-Source: OCC#802
Evidence-Commit: 864c1ca

@coderabbitai

coderabbitai Bot commented May 8, 2026 •

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This PR formalizes two delegation-related feature tickets by adding contract metadata and complete DoD (Definition of Done) evidence receipts. OMN-10626 defines the delegation installer with public API interface changes, while OMN-10656 extends delegation-bus bootstrap validation. All evidence records (installer tests, pre-commit hooks, bootstrap tests, and GitHub PR state bindings) passed validation and are recorded with execution metadata and captured outputs.

Changes

Contracts and DoD Evidence for Delegation Features

Layer / File(s) Summary
Contract Definitions
contracts/OMN-10626.yaml, contracts/OMN-10656.yaml
OMN-10626 contract is added with public API interface flag and four DoD evidence requirements (installer tests, pre-commit, PR 1538 binding, OCC PR binding). OMN-10656 contract is updated with three new DoD evidence entries for bootstrap tests, bootstrap pre-commit validation, and PR 1539 binding.
Installer Tests Evidence
drift/dod_receipts/OMN-10626/dod-installer-tests/command.yaml
Evidence record captures installer script test execution with PASS status, including metadata (schema version, ticket ID, check type), execution provenance (timestamp, commit SHA, runner/verifier), and detailed test assertions validating help, validation failures, dry-run/apply/uninstall operations, idempotency, and overall test completion summary.
Pre-commit Hook Validation
drift/dod_receipts/OMN-10626/dod-precommit/command.yaml, drift/dod_receipts/OMN-10656/dod-bootstrap-precommit/command.yaml
Two evidence records document pre-commit hook execution: OMN-10626 validates two test scripts and OMN-10656 validates bootstrap source/test files. Both record PASS status with exit code 0, probe commands, captured stdout, and complete run metadata including PR number, branch, and working directory.
Bootstrap Tests Evidence
drift/dod_receipts/OMN-10656/dod-bootstrap-tests/command.yaml
Evidence record for delegation-bus bootstrap unit tests captures pytest command execution with PASS status, 11 tests passing in 4.63s, and detailed output validating behavior around invalid adapters and non-object JSON handling, along with execution metadata and PR context.
GitHub PR State Binding
drift/dod_receipts/OMN-10626/dod-pr-1538-head/command.yaml, drift/dod_receipts/OMN-10656/dod-pr-1539-head/command.yaml
Two evidence records bind contract validations to GitHub PR commits via gh CLI queries: OMN-10626 against onex PR #1538 and OMN-10656 against omniclaude PR #1539, recording headRefOid, branch metadata, and verification timestamps to ensure evidence is bound to specific repository commit states.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A rabbit hops through contracts bright,
With installers ready for the flight,
Tests all pass and hooks align,
PR states sealed with golden line—
Evidence complete, the deed is signed! 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding OCC (operational change control) evidence documentation for the OMN-10626 delegation feature, which is the primary focus of this PR's contract and evidence files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-10626-10656-omniclaude-occ

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonahgabriel
jonahgabriel merged commit f57e1e5 into main May 8, 2026
28 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-10626-10656-omniclaude-occ branch May 8, 2026 03:20
jonahgabriel pushed a commit that referenced this pull request Aug 2, 2026
…ninode_infra#802

validator_occ_merge_eligibility finds no closing keyword in #802's body and
falls back to its TITLE, which names OMN-15623 + OMN-15656 + OMN-15655. Each
extracted ticket needs a PASS receipt bound to the PR. Adds:
  - OMN-15623/occ-self-bind-pr-5991 (binds this OCC PR to itself)
  - OMN-15656/dod-omn15656-carried-in-omninode-infra-pr-802
  - OMN-15655/dod-omn15655-carried-in-omninode-infra-pr-802

All three append-only (zero deletions); every probe re-executed live by this
non-implementer lane.

Refs OMN-15623
jonahgabriel added a commit that referenced this pull request Aug 2, 2026
…#5991)

* evidence(OMN-15623): OCC companion for OmniNode-ai/omninode_infra#802

Non-implementer evidence companion for the onex-dev runtime+migrate digest
bump. Appends two dod_evidence entries + receipts to contracts/OMN-15623.yaml;
edits no existing entry (append-only, zero deletions vs origin/dev).

Refs OMN-15623

* evidence(OMN-15623): bind OCC#5991 self + the two carried fixes to omninode_infra#802

validator_occ_merge_eligibility finds no closing keyword in #802's body and
falls back to its TITLE, which names OMN-15623 + OMN-15656 + OMN-15655. Each
extracted ticket needs a PASS receipt bound to the PR. Adds:
  - OMN-15623/occ-self-bind-pr-5991 (binds this OCC PR to itself)
  - OMN-15656/dod-omn15656-carried-in-omninode-infra-pr-802
  - OMN-15655/dod-omn15655-carried-in-omninode-infra-pr-802

All three append-only (zero deletions); every probe re-executed live by this
non-implementer lane.

Refs OMN-15623

---------

Co-authored-by: Jonah Gray <jonah.g.gray@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant