Skip to content

evidence(OMN-17188): OCC evidence for OmniNode-ai/omnidash#305 - #7788

Merged
jonahgabriel merged 2 commits into
devfrom
jonah/omn-17188-occ-pr305
Aug 31, 2026
Merged

jonahgabriel merged 2 commits into
devfrom
jonah/omn-17188-occ-pr305

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Aug 31, 2026 •

Copy link
Copy Markdown
Contributor

Appends a dod_evidence entry + PASS receipt binding OMN-17188 to OmniNode-ai/omnidash#305.

#305 is the second attempt at CodeQL alerts #14/#15, diagnosed from the analysis SARIF rather than guessed. The data-flow path ran straight THROUGH both replace calls, so CodeQL treated neither as a sanitizer. The query source is decisive: StringReplaceSanitizer requires replaces(s, "") and s.regexpMatch("\\n"), and replaces(old,new) resolves new via getRawReplacement().mayHaveStringValue — so a ' ' replacement yields new = " " and never matches. #304's character-class-vs-alternation theory was wrong; the replacement string was the defect.

Append-only: the #302 and #304 entries and receipts are untouched.

Evidence-Source: OCC#7788
Evidence-Ticket: OMN-17188

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 41 minutes.

View limit details

Limit details: You’ve used the included review currently available. Your 138 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2c2e536d-e406-414e-a59b-abb307a8eada

📥 Commits

Reviewing files that changed from the base of the PR and between 420f940 and c999750.

📒 Files selected for processing (2)
  • contracts/OMN-17188.yaml
  • drift/dod_receipts/OMN-17188/dod-OmniNode-ai-omnidash-pr-305/command.yaml

Comment @coderabbitai help to get the list of available commands.

@jonahgabriel
jonahgabriel merged commit a314a74 into dev Aug 31, 2026
161 of 168 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-17188-occ-pr305 branch August 31, 2026 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant