Repository navigation
chore(OMN-16702): re-stage prod-promotion grant — batch-af8142c0 expired unused - #7561
Merged
Merged
Conversation
…red unused The operator ruled 2026-08-29 to re-stage the OMN-16702/OMN-16685 grant window after batch-af8142c0-f2bf-4d79-887a-e65d964c9da8 (OCC#7464) lapsed unconsumed at expires_at 2026-08-29T09:00:00Z: no deploy-onex-prod.yml dispatch ever ran against it (last dispatch was 2026-08-28T20:42Z, before the grant merged at 21:51Z). Reproduces the same four entries in substance (runtime same-digest, mechanically required; omnidash, onex-api, dev-valkey roll, all three documentary) under a NEW batch id batch-48e48b4c-68f5-4e1c-b12e-818dcf062dfd and new grant_ids, expires_at 2026-08-30T16:00:00Z aligned with the still-live OMN-16799 cutover batch (batch-404af076). Target surfaces re-verified unchanged against omninode_infra@main/@dev: runtime digest, k8s/onex-public tree SHA, omnidash/onex-api/valkey image digests all identical to what af8142c0 authorized. Branch is built on top of hotfix/omn-15010-prune-expired-af8142c0-grants (OCC#7554, OMN-15010) so this PR's diff carries that prune and no grant_id is duplicated regardless of merge order. Ticket: OMN-16702, OMN-16685
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
occ-preflight/eligibility failed with reason=missing_occ_self_bind: OMN-16702 evidence verifies but no receipt binds to this OCC PR. Adds occ-self-bind-pr-7561 to contracts/OMN-16702.yaml with a PASS receipt (pr_number 7561), and recomputes contract_sha256 on the four pre-existing OMN-16702 receipts since the whole-file hash moves when the contract gains an entry (per-entry contract_entry_sha256 values verified unchanged, per OMN-13888). Ticket: OMN-16702
…opped for main-target-guard/occ-preflight/receipt-gate/CI)
…age-batch-af8142c0 # Conflicts: # grants/prod_promotion_grants.yaml
…aged batch Contract Compliance Check re-executes dod_evidence check_value commands live and failed: dod-prod-promotion-grant-values-omn16702's check_value still grepped for batch-af8142c0's grant_ids, pruned by OCC#7554 before this PR's own commits landed. Updates the check_value/description/receipt to assert the current re-staged batch-48e48b4c grant_ids instead, and recomputes contract_sha256 (whole-file) + this entry's contract_entry_sha256 accordingly (OMN-13888). Ticket: OMN-16702
This was referenced Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AGENT SCOPE: OPEN AND VERIFY ONLY — DO NOT MERGE
This PR touches
grants/prod_promotion_grants.yaml, CODEOWNERS-protected by@OmniNode-ai/platform-leads. No agent will merge it. The CODEOWNERS merge is the approval act (OMN-13418). This PR reproduces the intent of#7464; the merge event, and nothing prior to it, is the authorization.Ticket: OMN-16702 (adjacent: OMN-16685).
Operator ruling this executes
2026-08-29: re-stage the valkey roll grants.
batch-af8142c0-f2bf-4d79-887a-e65d964c9da8(OCC#7464, merged 2026-08-28T21:51:06Z) expired 2026-08-29T09:00:00Z, unconsumed — nodeploy-onex-prod.ymldispatch ever ran against it (last dispatch, run33209359978, fired at 2026-08-28T20:42:14Z, before the grant merged; nothing has dispatched since). Its four entries were pruned by a concurrent lane (onex_change_control#7554, OMN-15010) for the unrelated reason thatmainwas red on the OMN-13424 no-expired-entry invariant.One line for the approver, per the operator's instruction: merge = approval; the roll-execution lane dispatches on merge.
Security context, per the operator's instruction: the public-cluster
dev/dev-valkeythis batch's entry 4 authorizes credentialing is currently unauthenticated and servesdash.omninode.aisession data (until thek8s/onex-publicapply moves omnidash off it) plus Infisical's cache. Anything that can route todev:6379today reads and writes the whole keyspace — the NetworkPolicy admitting it is namespace-wide, not workload-scoped. That exposure is why this window is being re-staged rather than left to lapse a second time.Coordination with the concurrent prune (
#7554)#7554("prune the four expired batch-af8142c0 prod-promotion grants") was OPEN, MERGEABLE, checks green at the time this branch was cut. This branch is built directly on top of its head commit (hotfix/omn-15010-prune-expired-af8142c0-grants@0d203ec77) rather than independently offmain, so:mainalready carries#7554's deletion of the four expiredaf8142c0entries, plus this PR's own four new entries under a new batch.grant_idis duplicated, and merge order between the two PRs doesn't matter — whichever lands second finds its removal of the same four lines already applied and merges clean.#7554remains useful and mergeable on its own if the operator prefers to land it first; this PR does not supersede its scope, only builds on it.What's in the new batch
Same four entries as
batch-af8142c0in substance, newpromotion_batch_id: batch-48e48b4c-68f5-4e1c-b12e-818dcf062dfdand newgrant_ids (the OMN-13424 validator forbids re-adding an already-expiredgrant_id):grant-30d406bbsha256:13c96028…(runtime)grant-7f32b169sha256:50601f9e…(omnidash)grant-0bb17fe1sha256:b4c32554…(onex-api)grant-25d6751asha256:53ae5378…(dev-valkey)expires_at: 2026-08-30T16:00:00Z— aligned with the still-live OMN-16799 cutover batch (batch-404af076) below it in the file, so both live batches share one expiry.Preconditions re-verified, not assumed
k8s/onex-publictree SHA (04c2fe17e6a7478271e1358b78ee9afda6aa544b), omnidash/onex-api/valkey image digests all re-checked live againstomninode_infra@main/@dev2026-08-29 — identical.git log --since=2026-08-28T21:08:00Zon those five manifest paths returns nothing.omninode_infra/docs/runbooks/OMN-16702-dev-valkey-requirepass-roll.md): Step 0 sequencing (public apply first, roll second) and Step 3 server-first order (reversing it is a hard AUTH failure, not a degradation) are unchanged. Rollback posture unchanged — reverse-orderrollout undo, credential Secret not deleted, rollback is a security regression not a neutral outcome.d75cbdc) had already merged before that run. No dispatch has run since to re-prove or disprove it — this grant removes the authorization blocker only, same as the original.Verification
.github/workflows/validate-prod-promotion-grants.yml, re-executed):PASS: grants/prod_promotion_grants.yaml — 6 grant(s) validated successfully.uv run pytest tests/test_prod_promotion_grants.py -q→18 passed.pre-commit run --files grants/prod_promotion_grants.yaml→ clean (yamlfmt reflowed once, re-verified after).grant_id/promotion_batch_id.main-target-guardtrailersSame underlying ticket (OMN-16702) as
#7464; reusing its evidence companion since nothing new landed ondevfor this re-stage.Evidence-Ticket: OMN-16702
hotfix-evidence: OCC-7441
backmerge: #7441