Repository navigation
evidence(OMN-16773): rebind contract onto omnibase_infra#2955, retire dead #2940 bindings - #7440
Merged
Merged
Conversation
… dead #2940 bindings OMN-16773's contract was autobound to omnibase_infra PR #2940, which closed unmerged. The three entries pinned to #2940 (dod-OmniNode-ai-omnibase_infra-pr-2940, dod-deploy-assessment, occ-self-bind-pr-7328) can never satisfy their ::pr-live-state MERGED assertion because #2940 was never merged. The actual delivered work landed via omnibase_infra#2955 (merged 8e1be3c32), already partially bound (dod-OmniNode-ai-omnibase_infra-pr-2955, dod-OmniNode-ai-omnibase_infra-pr-2955-ci, occ-self-bind-pr-7372). - Removed dod-OmniNode-ai-omnibase_infra-pr-2940 (superseded by the -pr-2955 entry) - Removed occ-self-bind-pr-7328 (superseded by occ-self-bind-pr-7372, already merged) - Repointed dod-deploy-assessment onto #2955 (ref 73b53a71773..., F-05 deploy-scope check re-run live, PASS) instead of dropping it, since no other entry covers F-05 - Updated contract summary + evidence_requirements to name #2955 - Rebound contract_sha256 on all surviving receipts to the new whole-file hash; recomputed contract_entry_sha256 for dod-deploy-assessment (only entry whose content changed) Per 2026-08-28 sprint-board adjudication (docs/tracking/2026-08-28-sprint-board-adjudication.md, recommended follow-up #3): "an OCC contract bound to a PR that closed unmerged is permanently unverifiable and should be detected at bind time." OMN-16773
|
Warning Review limit reachedNext included review available in 17 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 131 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
Comment |
…tries The prior two commits on this branch edited/deleted already-merged contract entries and receipt files (dod-OmniNode-ai-omnibase_infra-pr-2940, dod-deploy-assessment, occ-self-bind-pr-7328), which the OCC Append-Only Gate correctly rejected -- merged dod_evidence items and receipts are immutable. This commit restores the original three entries and their receipts byte-for-byte, then supersedes them the sanctioned way: two net-new append-only entries with evidence_artifact: supersedes_dod_evidence:<id>, per the OMN-15382 runner-supersession precedent (contracts/OMN-14968.yaml): - dod-pr-2940-rebind-16773: asserts PR #2940's real CLOSED state in the same clause as the PR reference (OMN-16087 override), so the historical entry's ::pr-live-state auto-check stops defaulting to a permanent MERGED requirement it can never satisfy. - dod-deploy-assessment-rebind-16773: re-proves the F-05 deploy-scope requirement against #2955 (merged 8e1be3c32), since the historical entry's receipt records pr_number: 2940 and can't be edited. occ-self-bind-pr-7328 needed no correction -- its own id-pinned PR (7328, the OCC companion PR) actually did merge; only the entries id-pinned or receipt-bound to product PR #2940 were unverifiable. OMN-16773
jonahgabriel
added a commit
that referenced
this pull request
Aug 28, 2026
…validator) The #7440 rebind fixed dod-OmniNode-ai-omnibase_infra-pr-2940 and dod-deploy-assessment but missed a third: dod-occ-evidence-admissibility-validator's id names no PR, but its historical receipt records pr_number: 2940 (receipt-derived fallback, tier c) -- confirmed live by re-running dod_verify after #7440 merged (status=failed on this entry's ::pr-live-state, "PR not merged (state=CLOSED)"). Append-only supersession entry dod-admissibility-rebind-16773 re-runs the same suite (uv run pytest tests/test_evidence_admissibility.py -q, 76 passed) with a receipt bound to omnibase_infra#2955 (merged) instead. OMN-16773
jonahgabriel
added a commit
that referenced
this pull request
Aug 28, 2026
…validator) (#7448) * evidence(OMN-16773): rebind the 3rd #2940-bound entry (admissibility validator) The #7440 rebind fixed dod-OmniNode-ai-omnibase_infra-pr-2940 and dod-deploy-assessment but missed a third: dod-occ-evidence-admissibility-validator's id names no PR, but its historical receipt records pr_number: 2940 (receipt-derived fallback, tier c) -- confirmed live by re-running dod_verify after #7440 merged (status=failed on this entry's ::pr-live-state, "PR not merged (state=CLOSED)"). Append-only supersession entry dod-admissibility-rebind-16773 re-runs the same suite (uv run pytest tests/test_evidence_admissibility.py -q, 76 passed) with a receipt bound to omnibase_infra#2955 (merged) instead. OMN-16773 * evidence(OMN-16773): self-bind OCC#7448 + rebind contract_sha256 OMN-16773
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
OMN-16773's OCC contract was autobound to
omnibase_infraPR #2940, which closed unmerged. Three entries pinned to #2940 (dod-OmniNode-ai-omnibase_infra-pr-2940,dod-deploy-assessment,occ-self-bind-pr-7328) can never satisfy their::pr-live-stateMERGED assertion because #2940 was never merged.The actual delivered work landed via
omnibase_infra#2955(merged8e1be3c32), which the contract already partially binds (dod-OmniNode-ai-omnibase_infra-pr-2955,dod-OmniNode-ai-omnibase_infra-pr-2955-ci,occ-self-bind-pr-7372).Change
dod-OmniNode-ai-omnibase_infra-pr-2940(superseded by the-pr-2955entry)occ-self-bind-pr-7328(superseded byocc-self-bind-pr-7372, already merged)dod-deploy-assessmentonto evidence(OMN-13514): OCC contract + DoD receipts for compliance_sweep skill false-clean fix #2955 (ref73b53a71773..., F-05 deploy-scope check re-run live against the new ref, PASS) rather than dropping it, since no other entry covers deploy-gate F-05summary+evidence_requirementsto name evidence(OMN-13514): OCC contract + DoD receipts for compliance_sweep skill false-clean fix #2955contract_sha256on all surviving receipts to the new whole-file hash; recomputedcontract_entry_sha256fordod-deploy-assessment(only entry whose content changed)Why
OMN-16773
Per the 2026-08-28 sprint-board adjudication (
docs/tracking/2026-08-28-sprint-board-adjudication.md, recommended follow-up #3): "an OCC contract bound to a PR that closed unmerged is permanently unverifiable and should be detected at bind time." This PR is the mechanical fix for that specific ticket's contract.Evidence
uv run validate-yaml contracts/OMN-16773.yaml— OKuv run pytest tests/test_evidence_admissibility.py -q— 76 passedpre-commit run --all-files(touched files) — all greengh api .../handler_chain_canary.py?ref=73b53a717737c30d9f618e514943505e8841823a→ grep count 1 (PASS)8e1be3c32a67a700c16b351bfc4236fe6a984e90