Repository navigation
evidence(OMN-16799): OCC companion for OmniNode-ai/omninode_infra#1044 - #7420
Merged
Merged
Conversation
Hand-authored companion, not an autobind. node_occ_companion_compute's F-17 guard deliberately suppresses companion authoring while the product PR is a draft or is title-marked do-not-merge/WIP (handler_occ_companion_compute.py, added after incident occ#4333). omninode_infra#1044 is BOTH -- DRAFT, and its title carries "[DO NOT MERGE -- awaiting grant]" -- and both are correct: #1044 must not become mergeable before the OMN-16799 prod-promotion grant lands on onex_change_control@main. So the autobind will not mint this until the operator un-drafts AND retitles #1044, which is exactly the step the Evidence-Source line is supposed to unblock. This PR supplies it without touching #1044's draft state. Appends two dod_evidence items to the existing OMN-16799 contract (append-only; per-entry contract_entry_sha256 binding means entries 1..N keep their hashes): - dod-OmniNode-ai-omninode_infra-pr-1044: Evidence-Source bind, literal PR number per the OMN-15382 class-3 mis-binding rule. - dod-omn-16799-reclaim-behavior-ratchet: a real behavior-class check on the changed surface, not a ticket-independent suite standing in for one (OMN-16434). #1044 ships tests/k8s/test_omn_16799_api_hostname_reclaim.py, 8 tests pinning the fail-closed shape of the reclaim_api_hostname input. The existing OMN-16799 entries from OCC#7342 (the #1034 autobind) are untouched. Evidence-Ticket: OMN-16799
|
Warning Review limit reachedNext included review available in 31 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 131 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OCC evidence companion for OmniNode-ai/omninode_infra#1044 — the gated
api.omninode.aihostname reclaim.Ticket: OMN-16799.
Why this is hand-authored and not an autobind
node_occ_companion_compute's F-17 guard deliberately suppresses companion authoring when the product PR is a draft, or when its title/body is marked do-not-merge/WIP (handler_occ_companion_compute.py, added after incident occ#4333).omninode_infra#1044is both:isDraft: truefix(OMN-16799): gate the api.omninode.ai hostname reclaim behind a prod-promotion grant [DO NOT MERGE — awaiting grant]Both are correct and deliberate — #1044 must not become mergeable before the OMN-16799 prod-promotion grant lands on
onex_change_control@main(OCC#7418). The suppression is the guard working, not a bug.But that creates a small deadlock:
#1044'sverify / verifyreceipt gate needs anEvidence-Source: OCC#<PR>line, and the autobind that would mint it refuses to fire until #1044 is un-drafted and retitled. This PR supplies the evidence without touching #1044's draft state, so the operator's step is a plain un-draft + merge rather than un-draft, wait for autobind, then merge.What it adds
Two
dod_evidenceitems appended to the existingcontracts/OMN-16799.yaml(the OCC#7342 autobind foromninode_infra#1034). Append-only: the OMN-13888 per-entrycontract_entry_sha256binding means entries 1..N keep their hashes, so nothing already bound is invalidated.dod-OmniNode-ai-omninode_infra-pr-1044${PR_NUMBER}on a PR-bound id resolves to whatever PR the compliance runner is evaluating).dod-omn-16799-reclaim-behavior-ratchettests/k8s/test_omn_16799_api_hostname_reclaim.py, 8 tests pinning the fail-closed shape ofreclaim_api_hostname: opt-in defaultfalse, runtime-only refusal cross-checked against the OMN-14209 guard it depends on, both steps gated on the input, the delete chained to the precondition step's outcome, the three preconditions probed, and a ratchet asserting no ungateddelete ingressexists anywhere in the workflow. Not a ticket-independent suite standing in for a proof (OMN-16434).Both probes were run before the receipts were written.
pytest tests/k8s/test_omn_16799_api_hostname_reclaim.py -q→8 passed.Scope
Evidence only. This PR changes no runtime, no manifest, no workflow, and authorizes no prod mutation.
omninode_infra#1044stays DRAFT; nothing here un-drafts it or makes it mergeable.Evidence-Ticket: OMN-16799