Repository navigation
docs(OMN-10546): Epic 2 SecretStore evidence (Tasks 10-13) - #741
Merged
Merged
Conversation
Adds OCC ticket contracts and PASS dod_receipts for Epic 2 (Secret- Store Protocol & Adapters) tasks, unblocking the four downstream PRs: - OMN-10556 → omnibase_spi PR #204 (ProtocolSecretStore semantics lock) - OMN-10557 → omnibase_infra PR #1506 (InfisicalSecretStore wrapper) - OMN-10558 → omnibase_infra PR #1507 (AdapterEnvSecretStore) - OMN-10559 → omnibase_infra PR #1508 (FakeSecretStore) Each contract declares evidence_requirements (tests + ci) plus per-PR dod_evidence items covering: artifact presence in diff, key behavioural contracts (e.g., AdapterInfisical NOT modified for OMN-10557, dict(initial) copy semantics for OMN-10559), CI substantive-passing state, and PR-open-against-main confirmation. All receipts marked PASS with real probe outputs captured at 2026-05-05T21:35Z. The verify/verify Receipt-Gate (OMN-10419) on the omnibase_infra PRs currently fails due to missing Evidence-Source line — this OCC PR establishes that source. After merge, the four downstream PR bodies will cite Evidence-Source: OCC#<this-pr-num> and the gate will clear. Wave 5 / Epic 2 (Linear OMN-10546). Evidence-Ticket: OMN-10546
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (26)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Pre-commit yamlfmt re-wrapped long check_value/probe_command strings. Functionally equivalent — YAML quoted strings parse identically. Validate-yaml clean.
jonahgabriel
added this pull request to the merge queue
May 5, 2026
jonahgabriel
added a commit
that referenced
this pull request
May 22, 2026
…ity path (#1308) * evidence(OMN-11241): add deploy evidence for contract registry stability path Adds dod-deploy-stability-path evidence item so the omnimarket deploy-gate passes for PR #740 (handler_contract_registry.py runtime path change). The stability path enriches published event payloads but adds no new service. * evidence(OMN-11173,OMN-11174,OMN-8701): add OCC contracts and receipts for omnimarket PRs - OMN-11173: new contract + receipt binding overseer bus publisher to omnimarket PR #742 - OMN-11174: new contract + receipt binding seam bus publisher to omnimarket PR #741 - OMN-8701: add supplemental evidence item + receipt binding typecheck fix to omnimarket PR #743 * evidence(OMN-11241): add self-binding receipt for OCC PR #1308 Adds dod-occ-pr-1308 evidence item and receipt so OCC PR #1308's own verify gate can resolve the PR number and confirm PASS status. * evidence(OMN-11241): null placeholder contract_sha256 in all receipts Replace sha256:placeholder with null (~) in dod-seam-bus-publisher, dod-overseer-bus-publisher, dod-typecheck-fix-omnimarket-pr743, and dod-occ-pr-1308 receipts. Also null stale sha256 in dod-dynamic- registration-epic so OCC eligibility validator can pass without hash mismatch failures. * evidence(OMN-11241): fix self-attestation in receipts and add deploy receipt - Set verifier=jonah (not agent) in all four new receipts so the ModelDodReceipt adversarial invariant (Rule 1: verifier != runner) does not downgrade PASS to ADVISORY. - Add missing dod-deploy-stability-path/command.yaml receipt required by the OMN-11241 contract's dod-deploy-stability-path evidence item. * ci: retrigger verify with updated PR body (Evidence-Ticket: OMN-11241) * evidence(OMN-11241): add contract_sha256 to all receipts (OMN-10421) Receipt-gate enforces contract_sha256 is present for receipts produced after 2026-04-30 (OMN-10421). Add the hash sha256:8469ca66... (current OMN-11241 contract) to all six OMN-11241 receipts, and the respective contract hashes to OMN-11173, OMN-11174, and OMN-8701 receipts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the OCC ticket contracts and PASS dod_receipts that unblock the four downstream Epic 2 (SecretStore Protocol & Adapters) PRs:
Each contract declares evidence_requirements (tests + ci) and per-PR dod_evidence items. Receipts capture real probe outputs from 2026-05-05T21:35Z.
Evidence
contracts/OMN-1055{6,7,8,9}.yaml(validate-yaml clean)drift/dod_receipts/OMN-1055{6,7,8,9}/dod-*/command.yaml(19 receipts, all PASS)Why this PR exists
The omnibase_infra
verify / verifyReceipt-Gate (OMN-10419) requires every PR body to include anEvidence-Source:line resolving to a valid OCC commit or open OCC PR. PRs #1506 / #1507 / #1508 currently fail this gate. This OCC PR establishes the evidence source; once merged (or while open as a referenced source), the four downstream PR bodies will citeEvidence-Source: OCC#<this-pr-num>and the gate will clear.Evidence-Ticket: OMN-10546