Skip to content

docs(OMN-10544): add ticket contract + dod receipts for epic-org guards - #728

Merged
jonahgabriel merged 5 commits into
mainfrom
jonah/omn-10544-epic-org-structural-guards-occ
May 6, 2026
Merged

jonahgabriel merged 5 commits into
mainfrom
jonah/omn-10544-epic-org-structural-guards-occ

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented May 5, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Ticket: OMN-10544
Evidence-Ticket: OMN-10544
Pinned-omniclaude-PR: #1514
Pinned-omniclaude-SHA: 03d63b3dc2c12dbd674960ce2e3e5f72ed5b3ee5

OCC contract + dod_receipts proving the OMN-10544 fix:

  • contracts/OMN-10544.yaml — evidence requirements + 4 dod_evidence items.
  • drift/dod_receipts/OMN-10544/dod-001/command.yaml — epics-only refusal guard exists and is exercised by unit test.
  • drift/dod_receipts/OMN-10544/dod-002/command.yaml — secondary clustering pass surfaces the three sub-cohorts on the 2026-05-05 ambiguous group.
  • drift/dod_receipts/OMN-10544/dod-003/command.yaml — SKILL.md Phase 3 + 3b document the new verdict types.

The dod-occ-pr-XXX self-binding receipt will be added in a follow-up commit once this PR is opened.

Summary by CodeRabbit

  • Tests

    • Added multiple verification receipts for OMN-10544 documenting successful command checks and passing evidence for the ticket.
  • Documentation

    • Added a contract describing OMN-10544 with ticket details, required evidence items, and verification guidelines.

@coderabbitai

coderabbitai Bot commented May 5, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 685ac2d4-8dd1-4d09-8c26-40c465c7f528

📥 Commits

Reviewing files that changed from the base of the PR and between 36341f7 and fd8a2d0.

📒 Files selected for processing (4)
  • drift/dod_receipts/OMN-10544/dod-001/command.yaml
  • drift/dod_receipts/OMN-10544/dod-002/command.yaml
  • drift/dod_receipts/OMN-10544/dod-003/command.yaml
  • drift/dod_receipts/OMN-10544/dod-occ-pr-728/command.yaml

📝 Walkthrough

Walkthrough

Adds an evidence contract for OMN-10544 and four new command-style DoD receipt YAMLs under drift/dod_receipts/OMN-10544 that record PASS results and metadata for verification checks (dod-001, dod-002, dod-003, dod-occ-pr-728).

Changes

OMN-10544 Evidence Contract

Layer / File(s) Summary
Contract Definition
contracts/OMN-10544.yaml
New contract YAML declaring ticket_id OMN-10544, metadata (title, summary), flags (is_seam_ticket: false, interface_change: false), evidence_requirements (tests, docs, manual), emergency_bypass controls, and four dod_evidence items (dod-001, dod-002, dod-003, dod-occ-pr-728) with command-based checks.

Evidence Receipt Records

Layer / File(s) Summary
Receipt Additions
drift/dod_receipts/OMN-10544/dod-001/command.yaml, drift/dod_receipts/OMN-10544/dod-002/command.yaml, drift/dod_receipts/OMN-10544/dod-003/command.yaml, drift/dod_receipts/OMN-10544/dod-occ-pr-728/command.yaml
Four new command-type receipt files added. Each contains schema_version, ticket_id, evidence_item_id, check_type, check_value (grep/command verifications), status: PASS, run_timestamp, commit_sha, runner, verifier, probe_command/probe_stdout, actual_output, exit_code: 0, and pr_number references (notably PR 1514 in several receipts and PR 728 referenced in dod-occ-pr-728).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 I hopped in with a checklist bright,
Four tiny files to set things right.
Contracts penned and receipts in tow,
OMN-10544 all aglow. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically summarizes the main change: adding a contract and definition-of-done receipts for the OMN-10544 epic-org guards feature.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-10544-epic-org-structural-guards-occ

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
github-actions Bot enabled auto-merge May 6, 2026 00:16

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@drift/dod_receipts/OMN-10544/dod-occ-pr-728/command.yaml`:
- Around line 15-17: The stored probe_stdout currently contains an abbreviated
8-char headRefOid ("027ecf2a"); update the receipt so probe_stdout captures and
stores the full 40-character SHA returned by the probe_command (the gh pr view
invocation) to preserve exact raw output. Locate the probe_command and
probe_stdout entries (look for keys named probe_command and probe_stdout and the
JSON key headRefOid) and replace the abbreviated value with the complete 40-char
headRefOid string exactly as produced by the gh command so the receipt reflects
the raw output verbatim.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6f7463f8-c020-46ef-8295-1e8610e16b36

📥 Commits

Reviewing files that changed from the base of the PR and between d3f5913 and 36341f7.

📒 Files selected for processing (5)
  • contracts/OMN-10544.yaml
  • drift/dod_receipts/OMN-10544/dod-001/command.yaml
  • drift/dod_receipts/OMN-10544/dod-002/command.yaml
  • drift/dod_receipts/OMN-10544/dod-003/command.yaml
  • drift/dod_receipts/OMN-10544/dod-occ-pr-728/command.yaml

Comment thread drift/dod_receipts/OMN-10544/dod-occ-pr-728/command.yaml Outdated
@jonahgabriel
jonahgabriel added this pull request to the merge queue May 6, 2026
Merged via the queue into main with commit b72abe7 May 6, 2026
27 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-10544-epic-org-structural-guards-occ branch May 6, 2026 01:25
jonahgabriel added a commit that referenced this pull request May 21, 2026
…or (#1259)

* evidence(OMN-11278): bind OCC contract for node_session_phase_evaluator

Creates OCC contract OMN-11278 and binds dod-unit-tests receipt (20/20
passing) for omnimarket PR #728 — node_session_phase_evaluator (COMPUTE).

* fix(OMN-11278): correct receipt schema to ModelDodReceipt format

* evidence(OMN-11278): add dod-occ-pr-self receipt for OCC PR #1259

* evidence(OMN-11278): fix unit receipt check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant