Skip to content

evidence(OMN-15749): OCC companion for OmniNode-ai/omnibase_infra#2826 - #6819

Merged
jonahgabriel merged 2 commits into
devfrom
jonah/omn-15749-infra-2826-companion
Aug 21, 2026
Merged

jonahgabriel merged 2 commits into
devfrom
jonah/omn-15749-infra-2826-companion

Conversation

@jonahgabriel

Copy link
Copy Markdown
Contributor

Summary

OCC companion for omnibase_infra#2826, which makes the OMN-15181 deploy-agent digest-verification fixture absorb real docker daemon/registry timeouts instead of erroring on them.

Creates contracts/OMN-15749.yaml and its PASS receipt.

Why this is hand-authored

OCC autobind formally declined this PR. onexbot-occ-writer[bot] commented on omnibase_infra#2826 at 2026-08-21T04:48:24Z, marker occ-autobind-no-red-derivable:2826:

OCC autobind did not mint a companion for this PR: no changed-file candidate could be proven RED against the merge base, and emitting a PR-existence probe instead would be non-falsifiable evidence (OMN-15247). Hand-authored evidence is required.

That satisfies the pr-landing-ceremony.md §1.3 precondition — autobind is confirmed declined, not merely slow, so hand-authoring here does not risk the self-companion / divergent-automation guard.

Worth recording why autobind could not derive a RED candidate: #2826 changes a test fixture, so there is no product-code line whose absence at the merge base proves the defect. The RED fact lives one level up — the constant and helper the fixture gains — which is exactly what the probe below targets.

The probe is content-bound, not a PR-existence check

body="$(gh api 'repos/OmniNode-ai/omnibase_infra/contents/scripts/deploy-agent/tests/unit/test_executor_digest_verification_image_id_omn15181.py?ref=cc972ae1a2124a50acdc928cc4401b7455276b95' \
  --jq .content | base64 -d)" && printf '%s' "$body" | grep -qF -- '_PULL_TIMEOUT_SECONDS'
  • EXECUTED — gh api is on the admissibility allowlist; bare gh pr view is not (it "proves a PR exists, not that the code works").
  • FALSIFIABLE — run in both directions before the receipt was written. GREEN at head cc972ae1a2124a50acdc928cc4401b7455276b95; RED at merge-base 2444b99f135406b793b6620fb9b44605ad76171a, where the fixture still calls subprocess.run directly and _PULL_TIMEOUT_SECONDS does not exist. The receipt records the real exit status.
  • OUTSIDE ITS OWN DIFF — it reads omnibase_infra, a repo this OCC PR does not author.

Two shape details, both deliberate:

  • OMN-15411 Rule E pipe-safe form — capture into "$body" first, then pipe to grep, so the exit status is grep's and not masked by the pipeline head.
  • ?ref= URL is single-quoted, and the needle uses grep -qF --. Without the --, a needle beginning with - is parsed as an option — I hit exactly that while verifying the sibling probe for infra#2817, where --squash --auto made grep exit non-zero with invalid option. A probe that fails for that reason would have looked like a legitimate RED.

Evidence

Evidence-Ticket: OMN-15749

  • contracts/OMN-15749.yaml — new, one entry dod-OmniNode-ai-omnibase_infra-pr-2826
  • drift/dod_receipts/OMN-15749/dod-OmniNode-ai-omnibase_infra-pr-2826/command.yaml — PASS

Hashes computed with omnibase_core.validation.validator_receipt_gate against the yamlfmt-stabilized contract bytes, and re-verified after the commit hooks ran so a hook-side reflow cannot have staled them. verifier names the gh CLI against the GitHub API — re-derivable by anyone, not forgeable locally — with the executing lane recorded separately as runner, per the OMN-13060/A-5 hardening gate.

What #2826 itself proves

Its own acceptance signal is already green: Deploy Agent Tests reports 206 passed, 0 skipped, and both real_container tests log PASSED (not SKIPPED) on a real self-hosted runner — so the fixture still builds a real busybox container and both assertions still execute. The skip paths the PR adds are genuinely environment-conditional.

Test plan

  • Probe run in both directions (GREEN at head, RED at merge-base)
  • Hashes re-verified post-commit
  • pre-commit hooks passed
  • occ-preflight / eligibility and verify / verify green on this PR

Refs: OMN-15749, omnibase_infra#2826, OMN-15247, OMN-13888, OMN-15411

Hand-authored because OCC autobind formally DECLINED this PR. onexbot-occ-writer
commented on omnibase_infra#2826 at 2026-08-21T04:48:24Z with marker
`occ-autobind-no-red-derivable:2826`: "no changed-file candidate could be proven
RED against the merge base, and emitting a PR-existence probe instead would be
non-falsifiable evidence (OMN-15247). Hand-authored evidence is required."
That satisfies the pr-landing-ceremony §1.3 precondition for hand-authoring.

The probe is content-bound, not a PR-existence check, so it clears the
evidence-admissibility gate on all three axes:

- EXECUTED — `gh api` is on the allowlist; bare `gh pr view` is not.
- FALSIFIABLE — verified GREEN at head cc972ae1a and RED at merge-base
  2444b99f1, where the fixture still calls subprocess.run directly and
  _PULL_TIMEOUT_SECONDS does not exist. Both directions run before the
  receipt was written; the receipt records the real exit status.
- OUTSIDE ITS OWN DIFF — it reads omnibase_infra, which this OCC PR does
  not author.

Uses the OMN-15411 Rule E pipe-safe shape (capture into "$body", then pipe to
grep) with the ?ref= URL single-quoted, and `grep -qF --` because the needle
would otherwise be parsed as an option.

Refs: OMN-15749, omnibase_infra#2826, OMN-15247 (admissibility), OMN-13888
(per-entry hash), OMN-15411 (pipe-safe probe shape)
@coderabbitai

coderabbitai Bot commented Aug 21, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your current included review allowance is based on your included PR review attempts over the past 7 days.

Next review available in: 54 minutes

Limit details: You’ve used the included review currently available. Your 116 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f1dac568-ab81-461d-917f-4d8200aded83

📥 Commits

Reviewing files that changed from the base of the PR and between a3f14e6 and 11fcc43.

📒 Files selected for processing (3)
  • contracts/OMN-15749.yaml
  • drift/dod_receipts/OMN-15749/dod-OmniNode-ai-omnibase_infra-pr-2826/command.yaml
  • drift/dod_receipts/OMN-15749/occ-self-bind-pr-6819/command.yaml

Comment @coderabbitai help to get the list of available commands.

@jonahgabriel jonahgabriel added the ci:ready Full CI runs on this PR (OMN-15731 label-gated CI pilot) label Aug 21, 2026
@jonahgabriel
jonahgabriel enabled auto-merge (squash) August 21, 2026 06:54
@onexbot-occ-writer

Copy link
Copy Markdown
Contributor

OCC autobind stood down for OmniNode-ai/omnibase_infra#2826 (OMN-15749): this PR (hand_authored) already carries evidence for that ticket, so no competing companion was minted (OMN-15247 defer-on-contention).

occ-preflight failed post-recovery with reason=pr_ticket_mismatch:

    no PASS receipt for one or more tickets binds to PR #6819
    or one of its commit SHAs: OMN-15749

The product-PR receipt was found and its hashes verified clean
(missing_or_nonpass_receipts and stale_receipt_bindings were both empty) --
the gap was purely binding. That receipt carries pr_number 2826, the
omnibase_infra PR, so nothing bound OMN-15749 to this OCC PR itself, which
is what the eligibility checker resolves against.

Every other OCC companion carries such an entry (occ-self-bind-pr-6805,
-6809, -6810, -6811); I omitted it because the worked example I copied from,
OCC#6814, appends to a contract whose self-bind another PR had already
landed. A companion that CREATES its contract needs its own.

Adds occ-self-bind-pr-6819 following the established convention, with the
probe run live and the real stdout recorded. Also updates the product-PR
receipt's contract_sha256, which necessarily moved when the file gained an
entry -- both contract_entry_sha256 values are unchanged, per OMN-13888.

Refs: OMN-15749, omnibase_infra#2826, OMN-13888
@jonahgabriel
jonahgabriel merged commit 766589f into dev Aug 21, 2026
66 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-15749-infra-2826-companion branch August 21, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:ready Full CI runs on this PR (OMN-15731 label-gated CI pilot)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant