Skip to content

docs(OMN-10445): bind runner fleet standardization receipt - #673

Merged
jonahgabriel merged 2 commits into
mainfrom
jonah/omn-10445-infra-runner-standardization-occ
May 2, 2026
Merged

jonahgabriel merged 2 commits into
mainfrom
jonah/omn-10445-infra-runner-standardization-occ

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented May 2, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • add central OCC receipt evidence for omnibase_infra#1492
  • bind the runner fleet standardization proof to OMN-10445 and PR head 994bbe454e542339f0f61e0dd2a0680eeaffc9c7
  • preserve existing OMN-10445 receipts and add a new dod-infra-runner-standardization evidence item

Verification

  • uv run validate-yaml contracts/OMN-10445.yaml
  • local receipt gate: RECEIPT GATE PASSED: 11 check(s) across 1 ticket(s) all have PASS receipts.

Evidence-Ticket: OMN-10445

Summary by CodeRabbit

  • Tests

    • Added automated checks validating runner fleet health/standardization and an OCC downstream eligibility check; both produce PASS evidence when successful.
  • Chores

    • Added evidence/receipt records capturing test runs, expected runner counts and eligibility outcomes, and pass/fail metadata to improve traceability and validation.

@coderabbitai

coderabbitai Bot commented May 2, 2026 •

Copy link
Copy Markdown

Warning

Rate limit exceeded

@jonahgabriel has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 8 minutes and 15 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4fe805ac-fc8d-4db7-a61a-3e0edd6219d3

📥 Commits

Reviewing files that changed from the base of the PR and between 62bc1a2 and 6b9b9b3.

📒 Files selected for processing (3)
  • contracts/OMN-10445.yaml
  • drift/dod_receipts/OMN-10445/dod-infra-occ-eligibility/command.yaml
  • drift/dod_receipts/OMN-10445/dod-infra-runner-standardization/command.yaml
📝 Walkthrough

Walkthrough

Added an evidence requirement and two generated DoD receipts for OMN-10445: a runner-fleet standardization test (pytest + CLI health probe) asserting 20 expected/observed/healthy runners and 0 degraded, and an OCC eligibility receipt asserting OCC PR #673 is eligible for downstream PR #1492.

Changes

Runner Health & OCC Eligibility

Layer / File(s) Summary
Evidence Requirements
contracts/OMN-10445.yaml
New evidence_requirements entry to run pytest in omni_worktrees/OMN-10445/omnibase_infra-runner-standardization (runner health unit tests + integration contract test).
DOD Evidence Declarations
contracts/OMN-10445.yaml
Added two dod_evidence items: dod-infra-runner-standardization (expects PASS for PR #1492 with specified commit_sha and runner counts expected=20 observed=20 healthy=20 degraded=0, 17 passed) and dod-infra-occ-eligibility (expects PASS: OCC PR #673 eligible=true for downstream PR #1492).
Evidence Proof — Runner Standardization
drift/dod_receipts/OMN-10445/dod-infra-runner-standardization/command.yaml
check_value runs pytest suite and omnibase_infra.observability.runner_health.cli_runner_health --host 192.168.86.201 --json with env vars; records status: PASS, run metadata, probe_command (replay), probe_stdout with pytest summary and JSON health (expected/observed/healthy=20, degraded=0), actual_output, exit_code: 0, pr_number: 1492.
Evidence Proof — OCC Eligibility
drift/dod_receipts/OMN-10445/dod-infra-occ-eligibility/command.yaml
check_value runs omnibase_core.validation.validator_occ_merge_eligibility for omnibase_infra PR/branch; records status: PASS, run metadata, probe_command (includes OCC/pr commit SHAs and commit text), probe_stdout showing {"eligible":true}, actual_output, exit_code: 0, and PR/workspace context (pr_number: 673, branch, working_dir).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 I hopped through YAML, pytest in tow,
Counting runners in tidy row,
Twenty healthy, none astray,
OCC waved the downstream way,
Receipts snug, I bounce away!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: binding runner fleet standardization receipt for ticket OMN-10445, which aligns with adding receipt evidence entries and configuration for runner health verification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-10445-infra-runner-standardization-occ

Review rate limit: 0/5 reviews remaining, refill in 8 minutes and 15 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
github-actions Bot enabled auto-merge May 2, 2026 16:45

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
contracts/OMN-10445.yaml (1)

53-56: ⚡ Quick win

Description promises reconciliation, but command only runs tests.

This evidence requirement says it proves GitHub/Docker reconciliation, but the command currently stops at pytest. Consider appending the live read-only reconciliation CLI step so the command matches the stated proof scope.

Suggested diff
   - kind: "tests"
     description: "Runner fleet health config standardization and GitHub/Docker reconciliation proof pass"
     command: "cd omni_worktrees/OMN-10445/omnibase_infra-runner-standardization && PYTHONPATH=src uv run
       pytest tests/unit/observability/runner_health/test_cli_runner_health.py tests/unit/observability/runner_health/test_runner_fleet_config.py
-      tests/unit/observability/runner_health/test_collector_runner_health.py -q"
+      tests/unit/observability/runner_health/test_collector_runner_health.py -q && PYTHONPATH=src RUNNER_FLEET_CONFIG_PATH=config/runner_fleet.yaml
+      uv run python -m omnibase_infra.observability.runner_health.cli_runner_health --host 192.168.86.201 --json"
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@contracts/OMN-10445.yaml` around lines 53 - 56, The YAML's command only runs
pytest but the description promises GitHub/Docker reconciliation; update the
command (the YAML "command" value) to, after the pytest invocation, also run the
live read-only reconciliation CLI for the runner standardization workflow (i.e.,
invoke the repository's reconciliation CLI in read-only/dry-run mode within the
same omni_worktrees/OMN-10445/omnibase_infra-runner-standardization context
while preserving PYTHONPATH), so the executed command sequence both runs tests
(the pytest line) and then executes the reconciliation step that proves
GitHub/Docker reconciliation.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@contracts/OMN-10445.yaml`:
- Around line 53-56: The YAML's command only runs pytest but the description
promises GitHub/Docker reconciliation; update the command (the YAML "command"
value) to, after the pytest invocation, also run the live read-only
reconciliation CLI for the runner standardization workflow (i.e., invoke the
repository's reconciliation CLI in read-only/dry-run mode within the same
omni_worktrees/OMN-10445/omnibase_infra-runner-standardization context while
preserving PYTHONPATH), so the executed command sequence both runs tests (the
pytest line) and then executes the reconciliation step that proves GitHub/Docker
reconciliation.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 54073015-1569-4282-9bcd-b33b758636c5

📥 Commits

Reviewing files that changed from the base of the PR and between a1c25e5 and 67556e3.

📒 Files selected for processing (2)
  • contracts/OMN-10445.yaml
  • drift/dod_receipts/OMN-10445/dod-infra-runner-standardization/command.yaml

@jonahgabriel
jonahgabriel force-pushed the jonah/omn-10445-infra-runner-standardization-occ branch 2 times, most recently from c4927ee to a5f9a1a Compare May 2, 2026 17:23
@jonahgabriel
jonahgabriel force-pushed the jonah/omn-10445-infra-runner-standardization-occ branch from a5f9a1a to a05894f Compare May 2, 2026 17:26
@jonahgabriel
jonahgabriel force-pushed the jonah/omn-10445-infra-runner-standardization-occ branch from 62bc1a2 to 6b9b9b3 Compare May 2, 2026 17:31
@jonahgabriel
jonahgabriel added this pull request to the merge queue May 2, 2026
Merged via the queue into main with commit e3b3af7 May 2, 2026
26 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-10445-infra-runner-standardization-occ branch May 2, 2026 18:31
jonahgabriel added a commit that referenced this pull request May 16, 2026
Empty commit on omnimarket PR #673 (to trigger Evidence-Source CI run)
shifted head SHA from 18e9411f → a5250f94. Update all receipts and
contract check_value to match the new canonical head.
jonahgabriel added a commit that referenced this pull request May 17, 2026
…1077)

* evidence(OMN-11116): bind cross-node reach-in test refactor receipts

Contract and receipts for OMN-11116 — replaces file:lineno allowlist
with module-path matching in tests/test_no_cross_node_reach_in.py.
Binds omnimarket PR #673 at commit 18e9411f.

* evidence(OMN-11116): add self-binding OCC PR #1077 receipt

Adds the dod-occ-self receipt binding OCC PR #1077 and updates
the contract's check_value to validate against pr_number: 1077.

* evidence(OMN-11116): update receipts to new PR head a5250f94

Empty commit on omnimarket PR #673 (to trigger Evidence-Source CI run)
shifted head SHA from 18e9411f → a5250f94. Update all receipts and
contract check_value to match the new canonical head.
jonahgabriel added a commit that referenced this pull request May 26, 2026
… PR #673

Receipt status: PASS for both tickets at commit 3d323912e04cd09a5498fc1fd85e9664e30accd0.
28 unit tests pass (14 per node).
jonahgabriel added a commit that referenced this pull request May 26, 2026
…ier + DebugRetrieval (#1658)

* contracts(OMN-11577, OMN-11581): add OCC contracts for CiErrorClassifier + DebugRetrieval

Bind central OCC evidence for omniintelligence PR #673 implementing
NodeCiErrorClassifierCompute and NodeDebugRetrievalCompute compute nodes.

* evidence(OMN-11577, OMN-11581): add DoD receipts for omniintelligence PR #673

Receipt status: PASS for both tickets at commit 3d323912e04cd09a5498fc1fd85e9664e30accd0.
28 unit tests pass (14 per node).

* fix(OMN-11577, OMN-11581): fix receipt verifier to avoid self-attestation downgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant