Repository navigation
docs(OMN-7261): bind task boundary hook receipts - #669
Conversation
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughContract ChangesEvidence Receipts and Contract Update
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Review rate limit: 0/5 reviews remaining, refill in 37 seconds. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
contracts/OMN-7261.yaml (1)
23-25: ⚡ Quick winHarden receipt-gate assertions with more invariant fields.
These checks only assert
statusandevidence_item_id. Addticket_idandcheck_type(optionallyschema_version) so malformed/stale receipt content is less likely to pass accidentally.Example hardening pattern
- check_value: "grep -q '^status: PASS$' drift/dod_receipts/OMN-7261/dod-001/command.yaml && grep -q '^evidence_item_id: \"dod-001\"$' drift/dod_receipts/OMN-7261/dod-001/command.yaml" + check_value: "grep -q '^status: PASS$' drift/dod_receipts/OMN-7261/dod-001/command.yaml && grep -q '^evidence_item_id: \"dod-001\"$' drift/dod_receipts/OMN-7261/dod-001/command.yaml && grep -q '^ticket_id: \"OMN-7261\"$' drift/dod_receipts/OMN-7261/dod-001/command.yaml && grep -q '^check_type: \"command\"$' drift/dod_receipts/OMN-7261/dod-001/command.yaml"Also applies to: 30-32, 37-39, 44-45
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@contracts/OMN-7261.yaml` around lines 23 - 25, Update the check_value assertions that currently only verify status and evidence_item_id to also assert ticket_id and check_type (and optionally schema_version) so malformed or stale receipts can't slip through; specifically modify the check_value grep commands (e.g., the block containing check_value and id: "dod-002") to include additional grep -q checks for '^ticket_id: "..."$', '^check_type: "..."$' (and '^schema_version: "..."$' if desired), matching the expected values for each id (e.g., dod-001, dod-002) so each receipt gate verifies status, evidence_item_id, ticket_id and check_type.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@drift/dod_receipts/OMN-7261/dod-004/command.yaml`:
- Around line 13-15: The receipt metadata contains machine-specific absolute
paths in the probe_command and working_dir fields (e.g., "/Users/jonah/..."), so
update the receipt to use repo-relative or redacted paths instead: replace
absolute paths inside probe_command and any working_dir entries with a
repository-relative path (e.g., "python -m ..." run from repo root) or a
standardized placeholder like "<REPO_ROOT>" and ensure the same normalization is
applied across all receipts in the OMN-7261 set; locate the probe_command and
working_dir entries in the receipt YAML and update their values to remove the
local user/home path while preserving the original command arguments and intent.
---
Nitpick comments:
In `@contracts/OMN-7261.yaml`:
- Around line 23-25: Update the check_value assertions that currently only
verify status and evidence_item_id to also assert ticket_id and check_type (and
optionally schema_version) so malformed or stale receipts can't slip through;
specifically modify the check_value grep commands (e.g., the block containing
check_value and id: "dod-002") to include additional grep -q checks for
'^ticket_id: "..."$', '^check_type: "..."$' (and '^schema_version: "..."$' if
desired), matching the expected values for each id (e.g., dod-001, dod-002) so
each receipt gate verifies status, evidence_item_id, ticket_id and check_type.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 38bfbe78-9e13-4aa2-be34-e293a4aa7bd7
📒 Files selected for processing (5)
contracts/OMN-7261.yamldrift/dod_receipts/OMN-7261/dod-001/command.yamldrift/dod_receipts/OMN-7261/dod-002/command.yamldrift/dod_receipts/OMN-7261/dod-003/command.yamldrift/dod_receipts/OMN-7261/dod-004/command.yaml
c1819b6 to
1682f60
Compare
3fbc5c0 to
a58b45e
Compare
* docs(OMN-7261): bind task boundary hook receipts * docs(OMN-7261): bind hook receipts to occ commit * docs(OMN-7261): harden task boundary receipts * docs(OMN-7261): add occ eligibility receipt
1 participant
Summary
Verification
Downstream: OmniNode-ai/omniclaude#1504
Summary by CodeRabbit