Repository navigation
feat(OMN-10481): add ab compare CLI receipt evidence - #652
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis PR introduces a contract definition for ticket OMN-10481 ("Add ab-compare CLI wrapper") and adds three corresponding DoD evidence receipts documenting passed validation checks: unit tests, node metadata dependency scope verification, and node drift validation. ChangesOMN-10481 Contract & Evidence
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Review rate limit: 0/5 reviews remaining, refill in 57 minutes and 30 seconds. Comment |
345c2a7 to
3e2e795
Compare
…age PR #652 (#1034) * evidence(OMN-11058): OCC contract and receipts for critical topic triage PR #652 * fix(OMN-11058): use absolute working_dir paths in receipts Receipt gate validator requires working_dir to start with '/'. Replace \$OMNI_HOME expansion with resolved absolute path. * evidence(OMN-11058): add dod-infra-pr-1603 receipt binding omnibase_infra PR #1603 Receipt gate requires at least one receipt to bind to the downstream PR being checked. The infra PR #1603 (consumer-restart.v1 allowlist) is separate from the omnimarket PR #652 that the other receipts bind to. Add dod-infra-pr-1603 to bind this OCC evidence to the infra PR. * fix(OMN-11058): bind receipts to OCC PR #1034 and strengthen deploy check - Set pr_number=1034 and commit_sha to OCC HEAD on dod-deploy and dod-sweep-clean receipts so the eligibility validator sees them as PR-bound - Change verifier from receipt-gate-local to jonahgabriel (independent verifier) - Strengthen dod-deploy contract check to assert status: PASS + evidence_item_id rather than keyword-only grep (CodeRabbit finding) * fix(OMN-11058): align dod-sweep-clean actual_output with captured probe evidence Update actual_output to accurately describe what probe_command/probe_stdout captured (3929 tests pass) without claiming a direct sweep invocation that was not recorded. Addresses CodeRabbit finding: receipt claimed sweep-clean without corresponding probe.
OCC receipt-gate runs on the OCC PR itself and requires at least one PASS receipt bound to the OCC PR number. Without it, the gate reports pr_ticket_mismatch on OCC#1055 because all OMN-11058 receipts bind to omnimarket PR #652. Add dod-occ-pr-1055/command.yaml with pr_number=1055 plus contract dod_evidence entry, per the pattern in feedback memory reference_occ_receipt_binding.md. Evidence-Ticket: OMN-11058
* fix(OMN-11058): bind OCC receipts to omnimarket PR #652 OCC PR #1034 receipts cited pr_number=1034 (OCC PR number) and commit_sha values from outside omnimarket PR #652, so the OCC eligibility validator reported pr_ticket_mismatch on PR #652 and the receipt-gate blocked merge. This change updates the three OMN-11058 receipts to bind to PR #652: - pr_number: 1034 -> 652 (omnimarket PR, not OCC PR) - commit_sha -> acc2067bee404ca83741eb8480c8c61cbf43c093 (PR #652 head) - working_dir -> $OMNI_HOME-relative path (was hardcoded /Users/jonah) - dod-sweep-clean check_value: now references docs/evidence triage doc per CodeRabbit (was pytest invocation, not the actual sweep verification) - dod-infra-pr-1603 contract check_value: grep pr_number: 652 (was 1603) Evidence-Ticket: OMN-11058 * fix(OMN-11058): make receipt working_dir absolute path ModelDodReceipt validator requires working_dir to start with '/'. The previous fix used '$OMNI_HOME/...' which failed validation and caused receipt-gate to report 'nonpass_receipt' on OCC#1055 itself. Revert to a literal absolute path consistent with other receipts in the repo (drift/dod_receipts/OMN-10653/, OMN-10468/, etc). Evidence-Ticket: OMN-11058 * fix(OMN-11058): add OCC PR #1055 self-binding receipt OCC receipt-gate runs on the OCC PR itself and requires at least one PASS receipt bound to the OCC PR number. Without it, the gate reports pr_ticket_mismatch on OCC#1055 because all OMN-11058 receipts bind to omnimarket PR #652. Add dod-occ-pr-1055/command.yaml with pr_number=1055 plus contract dod_evidence entry, per the pattern in feedback memory reference_occ_receipt_binding.md. Evidence-Ticket: OMN-11058
Summary
Verification
uv run validate-yaml contracts/OMN-10481.yamluv run python -m omnibase_core.validation.receipt_gate_cli --pr-body "$(gh pr view 512 --repo OmniNode-ai/omnimarket --json body -q .body)" --pr-title "$(gh pr view 512 --repo OmniNode-ai/omnimarket --json title -q .title)" --contracts-dir /Volumes/PRO-G40/Code/omni_home/omni_worktrees/OMN-10481/onex_change_control/contracts --receipts-dir /Volumes/PRO-G40/Code/omni_home/omni_worktrees/OMN-10481/onex_change_control/drift/dod_receipts --current-repo omnimarket --current-pr-number 512Downstream: unblocks OmniNode-ai/omnimarket#512 Receipt Gate.
Summary by CodeRabbit