Repository navigation
evidence(OMN-15718): OCC companion for OmniNode-ai/omnibase_infra#2677 - #6151
Merged
Merged
Conversation
📝 WalkthroughWalkthroughThe PR adds the OMN-15718 OCC evidence manifest and four passing command receipts. The checks validate PR ChangesOMN-15718 evidence
Estimated code review effort: 2 (Simple) | ~15 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@drift/dod_receipts/OMN-15718/dod-OmniNode-ai-omnibase_infra-pr-2677/command.yaml`:
- Line 14: Update the commit_sha field in the receipt to the attested
omnibase_infra PR `#2677` head commit from the attestation, replacing the current
OCC commit value.
- Line 11: Add the identical contract_sha256 value, computed from the final raw
bytes of contracts/OMN-15718.yaml using
omnibase_core.validation.validator_receipt_gate, adjacent to
contract_entry_sha256 in all four listed command.yaml files:
drift/dod_receipts/OMN-15718/dod-OmniNode-ai-omnibase_infra-pr-2677/command.yaml:11-11,
drift/dod_receipts/OMN-15718/dod-occ-evidence-validator-pr-2677/command.yaml:7-7,
drift/dod_receipts/OMN-15718/dod-occ-evidence-admissibility-active-pr-6151/command.yaml:7-7,
and drift/dod_receipts/OMN-15718/occ-self-bind-pr-6151/command.yaml:10-10.
Preserve contract_entry_sha256 as the canonical-JSON per-entry hash.
- Line 1: Rename the receipt files to the required timestamp-based names: move
drift/dod_receipts/OMN-15718/dod-OmniNode-ai-omnibase_infra-pr-2677/command.yaml
to 2026-08-06T01:10:36Z.yaml;
drift/dod_receipts/OMN-15718/dod-occ-evidence-validator-pr-2677/command.yaml to
2026-08-06T01:10:36Z.yaml;
drift/dod_receipts/OMN-15718/dod-occ-evidence-admissibility-active-pr-6151/command.yaml
to 2026-08-06T10:53:00Z.yaml; and
drift/dod_receipts/OMN-15718/occ-self-bind-pr-6151/command.yaml to
2026-08-06T01:13:11Z.yaml. No receipt content changes are required.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5462a32d-5f45-4f78-83f7-3149e7911c2d
📒 Files selected for processing (5)
contracts/OMN-15718.yamldrift/dod_receipts/OMN-15718/dod-OmniNode-ai-omnibase_infra-pr-2677/command.yamldrift/dod_receipts/OMN-15718/dod-occ-evidence-admissibility-active-pr-6151/command.yamldrift/dod_receipts/OMN-15718/dod-occ-evidence-validator-pr-2677/command.yamldrift/dod_receipts/OMN-15718/occ-self-bind-pr-6151/command.yaml
| @@ -0,0 +1,33 @@ | |||
| --- | |||
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Move receipts to timestamp-named files.
The receipt locations violate the required <run_timestamp>.yaml filename format. The receipt gate can fail to discover these files.
drift/dod_receipts/OMN-15718/dod-OmniNode-ai-omnibase_infra-pr-2677/command.yaml#L1-L1: move todrift/dod_receipts/OMN-15718/dod-OmniNode-ai-omnibase_infra-pr-2677/2026-08-06T01:10:36Z.yaml.drift/dod_receipts/OMN-15718/dod-occ-evidence-validator-pr-2677/command.yaml#L1-L1: move todrift/dod_receipts/OMN-15718/dod-occ-evidence-validator-pr-2677/2026-08-06T01:10:36Z.yaml.drift/dod_receipts/OMN-15718/dod-occ-evidence-admissibility-active-pr-6151/command.yaml#L1-L1: move todrift/dod_receipts/OMN-15718/dod-occ-evidence-admissibility-active-pr-6151/2026-08-06T10:53:00Z.yaml.drift/dod_receipts/OMN-15718/occ-self-bind-pr-6151/command.yaml#L1-L1: move todrift/dod_receipts/OMN-15718/occ-self-bind-pr-6151/2026-08-06T01:13:11Z.yaml.
As per coding guidelines, “Store DoD receipts only at drift/dod_receipts/<TICKET>/<ITEM_ID>/<run_timestamp>.yaml.”
📍 Affects 4 files
drift/dod_receipts/OMN-15718/dod-OmniNode-ai-omnibase_infra-pr-2677/command.yaml#L1-L1(this comment)drift/dod_receipts/OMN-15718/dod-occ-evidence-validator-pr-2677/command.yaml#L1-L1drift/dod_receipts/OMN-15718/dod-occ-evidence-admissibility-active-pr-6151/command.yaml#L1-L1drift/dod_receipts/OMN-15718/occ-self-bind-pr-6151/command.yaml#L1-L1
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@drift/dod_receipts/OMN-15718/dod-OmniNode-ai-omnibase_infra-pr-2677/command.yaml`
at line 1, Rename the receipt files to the required timestamp-based names: move
drift/dod_receipts/OMN-15718/dod-OmniNode-ai-omnibase_infra-pr-2677/command.yaml
to 2026-08-06T01:10:36Z.yaml;
drift/dod_receipts/OMN-15718/dod-occ-evidence-validator-pr-2677/command.yaml to
2026-08-06T01:10:36Z.yaml;
drift/dod_receipts/OMN-15718/dod-occ-evidence-admissibility-active-pr-6151/command.yaml
to 2026-08-06T10:53:00Z.yaml; and
drift/dod_receipts/OMN-15718/occ-self-bind-pr-6151/command.yaml to
2026-08-06T01:13:11Z.yaml. No receipt content changes are required.
Source: Coding guidelines
| 'if (.number == 2677 and .state == "OPEN" and .headRefName == "jonah/omn-15718-refresh-stability-lane-wait-timeout-rollback" | ||
| and .headRefOid == "72ebe67ac21004b09037da771ccd4ca35fa70ad3" and ([.files[].path] | sort) == ["scripts/deploy-runtime.sh","scripts/runtime_build/compose_wait_timeout.sh","scripts/runtime_build/refresh_stability_lane.sh","tests/scripts/test_compose_wait_timeout.py","tests/scripts/test_deploy_runtime_compose_wait_timeout_wiring.py","tests/scripts/test_deploy_runtime_warmup_restore.py","tests/scripts/test_refresh_stability_lane_compose_wait_timeout_wiring.py"]) | ||
| then "true" else error("unexpected #2677 state, head, or file set") end' | ||
| contract_entry_sha256: "sha256:49bd2471ed1346a4ec77c77b33b240053442a0e8e4fd7b2858808806b8c93321" |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Add the raw contract hash to every receipt.
Each receipt binds its individual entry but omits contract_sha256. Generate the SHA-256 from the final raw bytes of contracts/OMN-15718.yaml with omnibase_core.validation.validator_receipt_gate, then add the same contract_sha256 value to each receipt.
drift/dod_receipts/OMN-15718/dod-OmniNode-ai-omnibase_infra-pr-2677/command.yaml#L11-L11: addcontract_sha256adjacent tocontract_entry_sha256.drift/dod_receipts/OMN-15718/dod-occ-evidence-validator-pr-2677/command.yaml#L7-L7: addcontract_sha256adjacent tocontract_entry_sha256.drift/dod_receipts/OMN-15718/dod-occ-evidence-admissibility-active-pr-6151/command.yaml#L7-L7: addcontract_sha256adjacent tocontract_entry_sha256.drift/dod_receipts/OMN-15718/occ-self-bind-pr-6151/command.yaml#L10-L10: addcontract_sha256adjacent tocontract_entry_sha256.
As per coding guidelines, “Bind contract_sha256 to the SHA-256 hash of the contract file's raw bytes and contract_entry_sha256 to the canonical-JSON per-entry hash.”
📍 Affects 4 files
drift/dod_receipts/OMN-15718/dod-OmniNode-ai-omnibase_infra-pr-2677/command.yaml#L11-L11(this comment)drift/dod_receipts/OMN-15718/dod-occ-evidence-validator-pr-2677/command.yaml#L7-L7drift/dod_receipts/OMN-15718/dod-occ-evidence-admissibility-active-pr-6151/command.yaml#L7-L7drift/dod_receipts/OMN-15718/occ-self-bind-pr-6151/command.yaml#L10-L10
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@drift/dod_receipts/OMN-15718/dod-OmniNode-ai-omnibase_infra-pr-2677/command.yaml`
at line 11, Add the identical contract_sha256 value, computed from the final raw
bytes of contracts/OMN-15718.yaml using
omnibase_core.validation.validator_receipt_gate, adjacent to
contract_entry_sha256 in all four listed command.yaml files:
drift/dod_receipts/OMN-15718/dod-OmniNode-ai-omnibase_infra-pr-2677/command.yaml:11-11,
drift/dod_receipts/OMN-15718/dod-occ-evidence-validator-pr-2677/command.yaml:7-7,
drift/dod_receipts/OMN-15718/dod-occ-evidence-admissibility-active-pr-6151/command.yaml:7-7,
and drift/dod_receipts/OMN-15718/occ-self-bind-pr-6151/command.yaml:10-10.
Preserve contract_entry_sha256 as the canonical-JSON per-entry hash.
Source: Coding guidelines
| contract_entry_sha256: "sha256:49bd2471ed1346a4ec77c77b33b240053442a0e8e4fd7b2858808806b8c93321" | ||
| status: "PASS" | ||
| run_timestamp: "2026-08-06T01:10:36Z" | ||
| commit_sha: "11dca9194e46f9a2e3e9669a6eeaf6399fa6a124" |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Set commit_sha to the attested subject commit.
Line 14 records 11dca9194e46f9a2e3e9669a6eeaf6399fa6a124. Lines 8-10 attest PR #2677 head 72ebe67ac21004b09037da771ccd4ca35fa70ad3. Set commit_sha to that attested omnibase_infra head. Otherwise, consumers bind this receipt to an OCC commit instead of the validated source change.
Based on learnings, cross-repository DoD receipts must use the external subject PR head commit.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@drift/dod_receipts/OMN-15718/dod-OmniNode-ai-omnibase_infra-pr-2677/command.yaml`
at line 14, Update the commit_sha field in the receipt to the attested
omnibase_infra PR `#2677` head commit from the attestation, replacing the current
OCC commit value.
Source: Learnings
This was referenced Aug 7, 2026
This was referenced Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Central OCC companion for OMN-15718 / OmniNode-ai/omnibase_infra#2677.\n\nEvidence-Ticket: OMN-15718\nEvidence-Source: OmniNode-ai/omnibase_infra#2677\n\nLocal verification:\n- uv run pytest tests/test_evidence_admissibility.py -q (76 passed)\n- pre-commit run --files contracts/OMN-15718.yaml drift/dod_receipts/OMN-15718/dod-OmniNode-ai-omnibase_infra-pr-2677/command.yaml drift/dod_receipts/OMN-15718/dod-occ-evidence-validator-pr-2677/command.yaml (passed)
Summary by CodeRabbit