Skip to content

chore(occ): add OMN-15413 evidence for market PR 2020 - #6150

Closed
jonahgabriel wants to merge 5 commits into
devfrom
codex/omn-15413-occ-pr2020
Closed

jonahgabriel wants to merge 5 commits into
devfrom
codex/omn-15413-occ-pr2020

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Aug 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Verification

  • uv run pytest tests/unit/nodes/node_dod_verify/test_handler_dod_evidence_github_effect.py -q
  • pre-commit run --files contracts/OMN-15413.yaml drift/dod_receipts/OMN-15413/dod-OmniNode-ai-omnimarket-pr-2020/command.yaml drift/dod_receipts/OMN-15413/dod-occ-evidence-validator-pr-2020/command.yaml
  • uv run pytest tests/test_evidence_admissibility.py -q

Summary by CodeRabbit

  • Documentation
    • Added verified evidence records for OMN-15413.
    • Documented successful validation of the associated pull requests, branches, and changed files.
    • Recorded passing focused test and evidence-validation runs, including execution status and results.

@coderabbitai

coderabbitai Bot commented Aug 6, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2b51bce8-15fe-4ff7-af13-795111a78391

📥 Commits

Reviewing files that changed from the base of the PR and between 0558ef3 and 325c0e0.

📒 Files selected for processing (4)
  • contracts/OMN-15413.yaml
  • drift/dod_receipts/OMN-15413/dod-OmniNode-ai-omnimarket-pr-2020/command.yaml
  • drift/dod_receipts/OMN-15413/dod-occ-evidence-validator-pr-2020/command.yaml
  • drift/dod_receipts/OMN-15413/occ-self-bind-pr-6150/command.yaml
🚧 Files skipped from review as they are similar to previous changes (4)
  • drift/dod_receipts/OMN-15413/occ-self-bind-pr-6150/command.yaml
  • drift/dod_receipts/OMN-15413/dod-OmniNode-ai-omnimarket-pr-2020/command.yaml
  • drift/dod_receipts/OMN-15413/dod-occ-evidence-validator-pr-2020/command.yaml
  • contracts/OMN-15413.yaml

Included review availability: 0 reviews are currently available. Based on recent review activity, included reviews refill at 1 per hour.


📝 Walkthrough

Walkthrough

The change adds three OMN-15413 verification checks and three command receipts. They record exact PR state and files, OCC validator results, and self-binding verification for PR #6150.

Changes

OMN-15413 evidence verification

Layer / File(s) Summary
PR identity, file-set, and admissibility verification
contracts/OMN-15413.yaml, drift/dod_receipts/OMN-15413/.../command.yaml
Added checks and PASS receipts for PR #2020 state, commit, exact files, and OCC evidence-admissibility tests.
OCC self-binding verification
contracts/OMN-15413.yaml, drift/dod_receipts/OMN-15413/occ-self-bind-pr-6150/command.yaml
Added a contract check and PASS receipt binding OMN-15413 to open OCC PR #6150 on the expected branch.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 325c0

This PR adds bound evidence and validation receipts without a supplied correctness, security, availability, or deployment risk; no actionable merge-blocking risk remains beyond normal checks and review.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the addition of OMN-15413 OCC evidence for market PR 2020, which is the main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/omn-15413-occ-pr2020

Comment @coderabbitai help to get the list of available commands.

@onexbot-occ-writer

Copy link
Copy Markdown
Contributor

OCC autobind stood down for OmniNode-ai/onex_change_control#6150 (OMN-15413): this PR (hand_authored) already carries evidence for that ticket, so no competing companion was minted (OMN-15247 defer-on-contention).

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@contracts/OMN-15413.yaml`:
- Around line 44-50: Update the superseding evidence entry
`dod-occ-evidence-validator-pr-2020` so its validator directly asserts PR 2020,
the expected branch, head `4dceca94a4a52e5b996fb1a8fba4972c2721b3e1`, and exact
two-file set; otherwise remove the supersession. Add the raw-byte
`contract_sha256` binding alongside `contract_entry_sha256`, then regenerate
both hashes using `omnibase_core.validation.validator_receipt_gate`.

In
`@drift/dod_receipts/OMN-15413/dod-occ-evidence-validator-pr-2020/command.yaml`:
- Line 10: Keep commit_sha set to 4dceca94a4a52e5b996fb1a8fba4972c2721b3e1, move
the receipt from command.yaml to the canonical timestamped filename
2026-08-06T01:02:45Z.yaml, and preserve the existing
omnibase_core.ModelDodReceipt structure.

In
`@drift/dod_receipts/OMN-15413/dod-OmniNode-ai-omnimarket-pr-2020/command.yaml`:
- Around line 1-2: Rename the DoD receipt files from command.yaml to their
run_timestamp filenames:
drift/dod_receipts/OMN-15413/dod-OmniNode-ai-omnimarket-pr-2020/2026-08-06T01:02:45Z.yaml,
drift/dod_receipts/OMN-15413/dod-occ-evidence-validator-pr-2020/2026-08-06T01:02:45Z.yaml,
and
drift/dod_receipts/OMN-15413/occ-self-bind-pr-6150/2026-08-06T01:04:52Z.yaml. No
content changes are required.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 951845e8-bfef-40f6-9380-37e213a19fc5

📥 Commits

Reviewing files that changed from the base of the PR and between 11dca91 and 9dacc64.

📒 Files selected for processing (4)
  • contracts/OMN-15413.yaml
  • drift/dod_receipts/OMN-15413/dod-OmniNode-ai-omnimarket-pr-2020/command.yaml
  • drift/dod_receipts/OMN-15413/dod-occ-evidence-validator-pr-2020/command.yaml
  • drift/dod_receipts/OMN-15413/occ-self-bind-pr-6150/command.yaml

Comment thread contracts/OMN-15413.yaml Outdated
@jonahgabriel
jonahgabriel force-pushed the codex/omn-15413-occ-pr2020 branch from 88252d1 to 0e0e246 Compare August 13, 2026 12:10
@jonahgabriel jonahgabriel added the ci:ready Full CI runs on this PR (OMN-15731 label-gated CI pilot) label Aug 13, 2026
@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@jonahgabriel

Copy link
Copy Markdown
Contributor Author

Closing as superseded-in-substance. Fresh-wave adjudication (2026-08-16) after rebasing onto current dev showed the only durable red is this PR's own evidence binding: it pins omnimarket#2020 at head 4dceca94 with state OPEN, but #2020 is now an EMPTY DIFF against omnimarket dev (compare status: ahead_by 2, zero changed files) — the deleted-base fail-closed repair this companion evidences already landed on dev (the handler's deleted-base carve-out logic is live at handler_dod_evidence_github_effect.py). The product PR vehicle will never merge, so a companion binding that vehicle's exact head/OPEN state cannot go green and certifies nothing beyond what dev already carries. If the repair is ever re-shipped through a real PR, the autobind path will mint fresh receipts against that vehicle. Note for the omnimarket lane: #2020 itself is an empty-diff PR and its OCC Companion Merged Gate wait is moot.

auto-merge was automatically disabled August 16, 2026 13:56

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:ready Full CI runs on this PR (OMN-15731 label-gated CI pilot)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant