Repository navigation
chore(occ): add OMN-15413 evidence for market PR 2020 - #6150
jonahgabriel wants to merge 5 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
Included review availability: 0 reviews are currently available. Based on recent review activity, included reviews refill at 1 per hour. 📝 WalkthroughWalkthroughThe change adds three OMN-15413 verification checks and three command receipts. They record exact PR state and files, OCC validator results, and self-binding verification for PR ChangesOMN-15413 evidence verification
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR adds bound evidence and validation receipts without a supplied correctness, security, availability, or deployment risk; no actionable merge-blocking risk remains beyond normal checks and review. Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
OCC autobind stood down for |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@contracts/OMN-15413.yaml`:
- Around line 44-50: Update the superseding evidence entry
`dod-occ-evidence-validator-pr-2020` so its validator directly asserts PR 2020,
the expected branch, head `4dceca94a4a52e5b996fb1a8fba4972c2721b3e1`, and exact
two-file set; otherwise remove the supersession. Add the raw-byte
`contract_sha256` binding alongside `contract_entry_sha256`, then regenerate
both hashes using `omnibase_core.validation.validator_receipt_gate`.
In
`@drift/dod_receipts/OMN-15413/dod-occ-evidence-validator-pr-2020/command.yaml`:
- Line 10: Keep commit_sha set to 4dceca94a4a52e5b996fb1a8fba4972c2721b3e1, move
the receipt from command.yaml to the canonical timestamped filename
2026-08-06T01:02:45Z.yaml, and preserve the existing
omnibase_core.ModelDodReceipt structure.
In
`@drift/dod_receipts/OMN-15413/dod-OmniNode-ai-omnimarket-pr-2020/command.yaml`:
- Around line 1-2: Rename the DoD receipt files from command.yaml to their
run_timestamp filenames:
drift/dod_receipts/OMN-15413/dod-OmniNode-ai-omnimarket-pr-2020/2026-08-06T01:02:45Z.yaml,
drift/dod_receipts/OMN-15413/dod-occ-evidence-validator-pr-2020/2026-08-06T01:02:45Z.yaml,
and
drift/dod_receipts/OMN-15413/occ-self-bind-pr-6150/2026-08-06T01:04:52Z.yaml. No
content changes are required.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 951845e8-bfef-40f6-9380-37e213a19fc5
📒 Files selected for processing (4)
contracts/OMN-15413.yamldrift/dod_receipts/OMN-15413/dod-OmniNode-ai-omnimarket-pr-2020/command.yamldrift/dod_receipts/OMN-15413/dod-occ-evidence-validator-pr-2020/command.yamldrift/dod_receipts/OMN-15413/occ-self-bind-pr-6150/command.yaml
88252d1 to
0e0e246
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
Closing as superseded-in-substance. Fresh-wave adjudication (2026-08-16) after rebasing onto current dev showed the only durable red is this PR's own evidence binding: it pins omnimarket#2020 at head 4dceca94 with state OPEN, but #2020 is now an EMPTY DIFF against omnimarket dev (compare status: ahead_by 2, zero changed files) — the deleted-base fail-closed repair this companion evidences already landed on dev (the handler's deleted-base carve-out logic is live at handler_dod_evidence_github_effect.py). The product PR vehicle will never merge, so a companion binding that vehicle's exact head/OPEN state cannot go green and certifies nothing beyond what dev already carries. If the repair is ever re-shipped through a real PR, the autobind path will mint fresh receipts against that vehicle. Note for the omnimarket lane: #2020 itself is an empty-diff PR and its OCC Companion Merged Gate wait is moot. |
Summary
Verification
Summary by CodeRabbit