Skip to content

fix(OMN-15422): append-only supersession for dod-...-pr-2596 (closed-unmerged PR) - #6049

Merged
jonahgabriel merged 4 commits into
devfrom
jonah/omn-15422-supersede-pr2596
Aug 4, 2026
Merged

jonahgabriel merged 4 commits into
devfrom
jonah/omn-15422-supersede-pr2596

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Aug 4, 2026 •

Copy link
Copy Markdown
Contributor

Cites OMN-15422.

Defect (verified live at OCC dev ab886f4)

contracts/OMN-15422.yaml carries dod_evidence id dod-OmniNode-ai-omnibase_infra-pr-2596, a pr-live-state Evidence-Source autobind entry for OmniNode-ai/omnibase_infra#2596. That PR is CLOSED and unmerged (state=CLOSED, merged_at=null, closedAt=2026-07-31T18:42:27Z, mergeCommit=null — confirmed live via gh pr view 2596 --repo OmniNode-ai/omnibase_infra). The contract had no supersedes_dod_evidence entry retiring it — the only existing supersession targets dod-OmniNode-ai-omnibase_infra-pr-2547 — so dod_verify's pr-live-state subcheck fails on the ticket. This was root-caused and confirmed by an independent adversarial verifier as the single mechanical blocker for closing OMN-15422.

Facts

  • #2596: CLOSED, unmerged, headRefOid=8e77577347ac8d5d99d0e8ecf0c930a69376013a.
  • #2597: MERGED (mergeCommit=79df552112854f1a0ce41e2b065e42864c8053ee), same head ref 8e77577347ac... as #2596.
  • The evidence content this ticket needs — scripts/ci/check_application_database_sql.py at that shared ref, containing def _is_non_deployable_sql_path (re-verified live, grep -c returns 1) — is already bound and PASS-receipted under dod-OmniNode-ai-omnibase_infra-pr-2597 in this same contract.
  • #2596 was legitimately superseded by #2597; the evidence content lives on and is bound by the merged PR, not the closed one.

Change (append-only, mirrors the #5937/#5945 supersession pattern)

Appends dod-OmniNode-ai-omnibase_infra-pr-2596-superseded to contracts/OMN-15422.yaml with evidence_artifact: "supersedes_dod_evidence:dod-OmniNode-ai-omnibase_infra-pr-2596", a check that asserts the immutable closed/unmerged fact (.state == "closed" and .merged_at == null), and an honest rationale citing the #2597 merge and its existing bound evidence. No existing content is modified or deleted — the superseded entry stays verbatim for audit. Adds the paired PASS receipt at drift/dod_receipts/OMN-15422/dod-OmniNode-ai-omnibase_infra-pr-2596-superseded/command.yaml.

Expected effect / falsification

dod_verify for OMN-15422 should now pass the pr-live-state subcheck mechanically (the superseded entry resolves to status=superseded at runtime). Falsification: rerun dod_verify against OMN-15422 after this PR merges to dev and confirm the pr-live-state check no longer fails on #2596.

Evidence-Ticket: OMN-15422
Evidence-Source: OCC#6050

@coderabbitai

coderabbitai Bot commented Aug 4, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 15 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 91075e98-c2d8-4633-ab8a-f1aa0641207b

📥 Commits

Reviewing files that changed from the base of the PR and between ea76d6e and 96b5a95.

📒 Files selected for processing (3)
  • contracts/OMN-15422.yaml
  • drift/dod_receipts/OMN-15422/dod-OmniNode-ai-omnibase_infra-pr-2596-superseded/command.yaml
  • drift/dod_receipts/OMN-15422/occ-self-bind-pr-6049/command.yaml

Comment @coderabbitai help to get the list of available commands.

@onexbot-occ-writer

Copy link
Copy Markdown
Contributor

OCC autobind stood down for OmniNode-ai/onex_change_control#6049 (OMN-15422): this PR (hand_authored) already carries evidence for that ticket, so no competing companion was minted (OMN-15247 defer-on-contention).

@jonahgabriel
jonahgabriel merged commit ecb5bf1 into dev Aug 4, 2026
64 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-15422-supersede-pr2596 branch August 4, 2026 16:41
jonahgabriel added a commit that referenced this pull request Aug 4, 2026
* evidence: OCC companion pass 1 for #6049

* evidence: OCC companion self-bind for #6050

* fix(OMN-15422): repair OCC 6050 self-bind evidence

---------

Co-authored-by: node-occ-companion-effect <occ-companion-effect@omninode.ai>
Co-authored-by: Jonah Gray <jonah@omninode.ai>
jonahgabriel added a commit that referenced this pull request Aug 5, 2026
…bes (#6112)

* fix(OMN-15567): append-only supersession of 6 stale pr-live-state probes

The OCC contract's dod_verify check_values hardcode gh-REST-style
`.state == "open"` (lowercase) against 5 PRs that have since MERGED:
omnibase_infra#2623 (bf070a94), omnibase_infra#2628 (aef0d202, two
distinct entries at two different heads), and OCC companions #5939,
#5960, #5964. The OMN-14637 auto-relax mechanism only re-anchors the
uppercase `.state == "OPEN"` (gh pr view --json) idiom -- this lowercase
gh-api-REST literal is a distinct, unhandled case, same class OMN-15422
hit (repair chain #6049/#6050/#6052).

Adds 6 single-id append-only supersessions re-anchoring each stale
assertion to the durable merged-terminal fact (state=closed, merged=true,
exact merge_commit_sha), re-verified live 2026-08-05. Receipts land
PENDING (this lane is the runner only; an independent identity must
re-execute and flip to PASS before merge eligibility -- the OCC#6111
shape).

OMN-15567

* evidence(OMN-15567): PENDING receipts for 6 stale pr-live-state supersessions

Runner-authored PENDING receipts for the 6 append-only supersessions in
contracts/OMN-15567.yaml. Each probe_stdout is byte-exact captured output
of the committed check_value, re-run live 2026-08-05. status PENDING per
the OCC#6111 shape -- this lane is the runner only; an independent
identity must re-execute and flip to PASS before merge eligibility.

OMN-15567

* evidence(OMN-15567): OCC self-bind for companion PR #6112

OMN-15567

* evidence(OMN-15567): PENDING receipt for OCC self-bind #6112

OMN-15567

* fix(OMN-15567): independently attest stale pr-state receipts

* evidence(OMN-15567): independent opus attestation of 7 rebound receipts

Re-executed all 7 declared check_value probes on .200 at 2026-08-05T18:10:50Z
and byte-compared stdout against each receipt's recorded probe_stdout.
All 7 matched exactly (rc=0):
  omn15567-repair-infra-2623-merged            -> "true\n"
  omn15567-repair-infra-2628-open-check-merged -> "true\n"
  omn15567-repair-infra-2628-7d8e810f-merged   -> "true\n"
  omn15567-repair-occ-5939-merged              -> "true\n"
  omn15567-repair-occ-5960-merged              -> "true\n"
  omn15567-repair-occ-5964-merged              -> "true\n"
  occ-self-bind-pr-6112                        -> {"number":6112,"state":"OPEN"}

Also re-verified all 7 contract_entry_sha256 values against
compute_contract_entry_sha256(contracts/OMN-15567.yaml) -- all match.

Replaces the verifier string written by a concurrent lane
("codex:merge-sweep-20260805T1804Z", commit f53a9ea) with this session's
identity, because this is the attestation backed by probe re-execution that
this verifier actually performed. The prior value is preserved in git history;
nothing is hidden. Receipt content (check_value/probe_stdout/hashes) unchanged.

Verifier != runner (runner is the authoring branch), so this is a genuine
independent flip, not self-attestation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant