[jonahgabriel]

Fixes OMN-10433

Summary

• Add central OCC contract and PASS receipts for the dispatch queue drainer --dry-run compatibility follow-up.
• Covers focused tests, lint, and isolated temp dogfood evidence for omnimarket#486.

Verification

• uv run validate-yaml contracts/OMN-10433.yaml
• uv run python -m omnibase_core.validation.receipt_gate_cli --pr-title 'fix(OMN-10433): accept dispatch drainer dry-run flag' --pr-body 'Fixes OMN-10433' --contracts-dir contracts --receipts-dir drift/dod_receipts -> RECEIPT GATE PASSED: 3 checks\n- uv run python scripts/ci/run_contract_compliance_check.py --pr 486 --repo OmniNode-ai/omnimarket --contracts-dir contracts -> 3/3 PASS\n- git diff --check

Summary by CodeRabbit

• New Features

  • Added --dry-run flag support to the node dispatcher, enabling compile-only execution without processing dispatch queue items.

• Tests

  • Added verification documentation recording successful completion of unit tests and code quality checks.

[coderabbitai]

📝 Walkthrough

Walkthrough

Introduces contract specification OMN-10433 requiring the node_dispatch_queue_drainer node to accept a --dry-run flag, along with three definition-of-done receipt files documenting verification through unit testing, code linting, and dry-run execution with compile-only status.

Changes

Cohort / File(s)	Summary
Contract Definition contracts/OMN-10433.yaml	New contract specifying --dry-run flag requirement for node_dispatch_queue_drainer node, with three DOD evidence receipts: pytest unit tests for the node, ruff linting checks, and isolated dogfood dry-run execution validation.
Definition of Done Receipts drift/dod_receipts/OMN-10433/dod-{001,002,003}/command.yaml	Three proof-of-completion receipts recording test execution outcomes (status: PASS) with verification logic that checks local file presence or fetches from GitHub API, along with execution metadata including timestamps, commit SHA, probe commands, and exit codes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A flag that was missing, now documented with care,
--dry-run proclaimed in contracts so fair,
Three receipts prove the work is complete,
GitHub and shell checks make verification neat! ✓

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding DOD receipts (definition of done evidence files) for the OMN-10433 contract related to dispatch drainer functionality.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch jonah/omn-10433-dispatch-drainer-receipts

---

_{Review rate limit: 0/5 reviews remaining, refill in 57 minutes and 56 seconds.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

contracts/OMN-10433.yaml (1)

23-25: Use shell-safe placeholders in the dogfood command example.

Lines 23–25 use <temp-...> tokens, which shells interpret as input redirection operators if run literally. Replace with env-var-style placeholders (${VAR_NAME}) to keep this command copy-paste-safe.

Suggested update

-      env -u PYTHONPATH uv run python -m omnimarket.nodes.node_dispatch_queue_drainer --queue-item-path
-      <temp-item.yaml> --state-dir <temp-state> --tasks-dir <temp-tasks> --omni-home <temp-omni-home>
-      --dry-run"
+      env -u PYTHONPATH uv run python -m omnimarket.nodes.node_dispatch_queue_drainer --queue-item-path
+      ${TEMP_ITEM_PATH} --state-dir ${TEMP_STATE_DIR} --tasks-dir ${TEMP_TASKS_DIR} --omni-home ${TEMP_OMNI_HOME}
+      --dry-run"

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@contracts/OMN-10433.yaml` around lines 23 - 25, The dogfood example command
uses shell-sensitive angle-bracket tokens ("<temp-item.yaml>", "<temp-state>",
"<temp-tasks>", "<temp-omni-home>") which can be interpreted as redirection;
update the example in the env -u PYTHONPATH uv run python -m
omnimarket.nodes.node_dispatch_queue_drainer --queue-item-path ... command to
use shell-safe env-style placeholders (e.g. ${TEMP_ITEM}, ${TEMP_STATE},
${TEMP_TASKS}, ${TEMP_OMNI_HOME}) so the command is copy-paste safe and clearly
indicates replaceable values.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@contracts/OMN-10433.yaml`:
- Around line 23-25: The dogfood example command uses shell-sensitive
angle-bracket tokens ("<temp-item.yaml>", "<temp-state>", "<temp-tasks>",
"<temp-omni-home>") which can be interpreted as redirection; update the example
in the env -u PYTHONPATH uv run python -m
omnimarket.nodes.node_dispatch_queue_drainer --queue-item-path ... command to
use shell-safe env-style placeholders (e.g. ${TEMP_ITEM}, ${TEMP_STATE},
${TEMP_TASKS}, ${TEMP_OMNI_HOME}) so the command is copy-paste safe and clearly
indicates replaceable values.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a245f391-32d5-4e8f-af44-53129a27f8e1

📥 Commits

Reviewing files that changed from the base of the PR and between c70594e and 6e70546.

📒 Files selected for processing (4)

• contracts/OMN-10433.yaml
• drift/dod_receipts/OMN-10433/dod-001/command.yaml
• drift/dod_receipts/OMN-10433/dod-002/command.yaml
• drift/dod_receipts/OMN-10433/dod-003/command.yaml