Repository navigation
docs(OMN-10372): add contract YAML and dod receipts for symbol extractor - #573
Conversation
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughA new contract document (OMN-10372.yaml) is introduced alongside three supporting evidence receipt files that document CI validations for a symbol extraction feature, including checks for file presence, function signatures, and unit test passage confirmation. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Review rate limit: 0/5 reviews remaining, refill in 11 minutes and 57 seconds. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
drift/dod_receipts/OMN-10372/dod-001/command.yaml (1)
1-18:⚠️ Potential issue | 🟠 MajorUpdate
commit_shato match the actual head of omnibase_core PR#998.The
commit_sha: b4c21dedin this receipt does not match the head commit of the target PR. The correct head commit SHA for OmniNode-ai/omnibase_core PR#998isd0ad179a7ed6e8af00efc68a2a116ca570552506. Update thecommit_shafield to the correct value.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@drift/dod_receipts/OMN-10372/dod-001/command.yaml` around lines 1 - 18, The commit_sha in the receipt is incorrect; update the YAML field commit_sha from b4c21ded to the correct head SHA d0ad179a7ed6e8af00efc68a2a116ca570552506 in the command.yaml so the receipt matches PR `#998`; ensure you only replace the value of the commit_sha key and keep surrounding fields (schema_version, ticket_id, probe_command, etc.) intact.drift/dod_receipts/OMN-10372/dod-002/command.yaml (1)
1-17:⚠️ Potential issue | 🟠 MajorCorrect
commit_shato match the actual head of omnibase_core PR#998.The receipt has
commit_sha: b4c21ded, but the actual head commit of PR#998inOmniNode-ai/omnibase_coreisd0ad179a7ed6e8af00efc68a2a116ca570552506. Update the receipt to use the correct full or unambiguous short SHA of the PR head, not an unrelated commit.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@drift/dod_receipts/OMN-10372/dod-002/command.yaml` around lines 1 - 17, Update the receipt's commit_sha field to the actual head of PR `#998` by replacing the current value "b4c21ded" with the correct SHA "d0ad179a7ed6e8af00efc68a2a116ca570552506" in the command.yaml; ensure you only change the commit_sha entry (leave schema_version, ticket_id, evidence_item_id, probe_command, probe_stdout and other metadata intact) so the receipt accurately references the omnibus_core PR `#998` head used to verify the extract_symbols signature check.drift/dod_receipts/OMN-10372/dod-003/command.yaml (1)
1-22:⚠️ Potential issue | 🟠 MajorFix receipt
commit_shato match omnibase_core PR#998head commit.The
commit_sha: b4c21deddoes not match theheadRefOidof OmniNode-ai/omnibase_core PR#998(d0ad179a7ed6e8af00efc68a2a116ca570552506). Update to the correct head commit SHA to ensure receipt validity for the deploy-gate/receipt registry.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@drift/dod_receipts/OMN-10372/dod-003/command.yaml` around lines 1 - 22, Update the receipt's commit_sha field to match the actual head commit of omnibase_core PR `#998` by replacing the current commit_sha value (b4c21ded) with the PR headRefOid d0ad179a7ed6e8af00efc68a2a116ca570552506 so the receipt correctly reflects the PR `#998` head commit for the deploy-gate/receipt registry.
🧹 Nitpick comments (1)
contracts/OMN-10372.yaml (1)
19-20: ⚡ Quick winAvoid embedded newlines in
dod-003contract command strings.The
dod-003evidence_requirements.commandanddod_evidencecheck_valueare double-quoted strings that include a YAML line break betweengrep -q '^status: PASS$'and the file path. Most shells treat newline as whitespace, but some runners/templaters or execution contexts can preserve newlines in ways that lead to brittle parsing.I recommend collapsing both commands to a single line (same semantics, more deterministic).
♻️ Proposed change (collapse dod-003 commands to one line)
- description: 14 unit tests pass locally, recorded in canonical DoD receipt - command: "test -f drift/dod_receipts/OMN-10372/dod-003/command.yaml && grep -q '^status: PASS$' drift/dod_receipts/OMN-10372/dod-003/command.yaml - && grep -q '14 passed' drift/dod_receipts/OMN-10372/dod-003/command.yaml" + description: 14 unit tests pass locally, recorded in canonical DoD receipt + command: "test -f drift/dod_receipts/OMN-10372/dod-003/command.yaml && grep -q '^status: PASS$' drift/dod_receipts/OMN-10372/dod-003/command.yaml && grep -q '14 passed' drift/dod_receipts/OMN-10372/dod-003/command.yaml" @@ - id: dod-003 description: 14 unit tests for symbol_extractor pass source: generated checks: - check_type: command - check_value: "test -f drift/dod_receipts/OMN-10372/dod-003/command.yaml && grep -q '^status: PASS$' - drift/dod_receipts/OMN-10372/dod-003/command.yaml && grep -q '14 passed' drift/dod_receipts/OMN-10372/dod-003/command.yaml" + check_value: "test -f drift/dod_receipts/OMN-10372/dod-003/command.yaml && grep -q '^status: PASS$' drift/dod_receipts/OMN-10372/dod-003/command.yaml && grep -q '14 passed' drift/dod_receipts/OMN-10372/dod-003/command.yaml"Based on learnings: “...treat the contents as deploy-gate artifacts ... only flag issues that clearly violate the contract schema/format or internal consistency of the YAML itself.” (This refactor keeps schema/semantics; it just removes newline brittleness.) citeturn0search0
Also applies to: 43-44
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@contracts/OMN-10372.yaml` around lines 19 - 20, The dod-003 contract contains multi-line double-quoted shell command strings (the evidence_requirements.command and dod_evidence.check_value entries) that embed a YAML newline between "grep -q '^status: PASS$'" and the file path; collapse each of those into a single-line string (no embedded newline) preserving the same grep sequence and file path so the semantics are identical but the command is deterministic across shells/runners (also apply the same single-line collapse to the other occurrence mentioned around lines 43-44).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@drift/dod_receipts/OMN-10372/dod-001/command.yaml`:
- Around line 1-18: The commit_sha in the receipt is incorrect; update the YAML
field commit_sha from b4c21ded to the correct head SHA
d0ad179a7ed6e8af00efc68a2a116ca570552506 in the command.yaml so the receipt
matches PR `#998`; ensure you only replace the value of the commit_sha key and
keep surrounding fields (schema_version, ticket_id, probe_command, etc.) intact.
In `@drift/dod_receipts/OMN-10372/dod-002/command.yaml`:
- Around line 1-17: Update the receipt's commit_sha field to the actual head of
PR `#998` by replacing the current value "b4c21ded" with the correct SHA
"d0ad179a7ed6e8af00efc68a2a116ca570552506" in the command.yaml; ensure you only
change the commit_sha entry (leave schema_version, ticket_id, evidence_item_id,
probe_command, probe_stdout and other metadata intact) so the receipt accurately
references the omnibus_core PR `#998` head used to verify the extract_symbols
signature check.
In `@drift/dod_receipts/OMN-10372/dod-003/command.yaml`:
- Around line 1-22: Update the receipt's commit_sha field to match the actual
head commit of omnibase_core PR `#998` by replacing the current commit_sha value
(b4c21ded) with the PR headRefOid d0ad179a7ed6e8af00efc68a2a116ca570552506 so
the receipt correctly reflects the PR `#998` head commit for the
deploy-gate/receipt registry.
---
Nitpick comments:
In `@contracts/OMN-10372.yaml`:
- Around line 19-20: The dod-003 contract contains multi-line double-quoted
shell command strings (the evidence_requirements.command and
dod_evidence.check_value entries) that embed a YAML newline between "grep -q
'^status: PASS$'" and the file path; collapse each of those into a single-line
string (no embedded newline) preserving the same grep sequence and file path so
the semantics are identical but the command is deterministic across
shells/runners (also apply the same single-line collapse to the other occurrence
mentioned around lines 43-44).
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: f5f05a33-eee5-4498-a035-c8ba6e34f7d9
📒 Files selected for processing (4)
contracts/OMN-10372.yamldrift/dod_receipts/OMN-10372/dod-001/command.yamldrift/dod_receipts/OMN-10372/dod-002/command.yamldrift/dod_receipts/OMN-10372/dod-003/command.yaml
Contract and 3 PASS receipts for OMN-10372 tree-sitter symbol extraction. Evidence: PR #998 in omnibase_core, 14 unit tests passing.
d82d700 to
a41852e
Compare
1 participant
Summary
contracts/OMN-10372.yamlwith 3 dod_evidence itemsdrift/dod_receipts/OMN-10372/with verified probe_stdoutTicket
OMN-10372 — Task 20: [Wave 5 AST Diff] tree-sitter Python parser + symbol extraction
Evidence
symbol_extractor.pypresent in omnibase_core PR contract(OMN-10931): bind omniclaude mypy rdjsonl PR #998 (probe_stdout: 5 matches)extract_symbolsfunction signature verified in PR diffSummary by CodeRabbit