Skip to content

evidence(OMN-10344): add cost observability receipts - #549

Merged
jonahgabriel merged 2 commits into
mainfrom
jonah/omn-10344-occ-evidence
Apr 29, 2026
Merged

jonahgabriel merged 2 commits into
mainfrom
jonah/omn-10344-occ-evidence

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Apr 29, 2026 •

Copy link
Copy Markdown
Contributor

Closes OMN-10344

Summary

  • add central OCC contract for OMN-10344
  • add PASS receipts for the repeatable cost observability pytest path, live Kafka e2e attempt blocked by unavailable Docker daemon, and merged omnibase_infra PR contract(OMN-11775): add delegation deploy evidence #1466
  • preserve the Docker blocker as evidence of attempted live Kafka e2e rather than claiming live Kafka passed

Verification

  • uv run python -m onex_change_control.scripts.validate_yaml contracts/OMN-10344.yaml
  • uv run python scripts/lint_contract_check_values.py contracts/OMN-10344.yaml
  • uv run python - <<'PY'
    from pathlib import Path
    import yaml
    from omnibase_core.models.contracts.ticket.model_dod_receipt import ModelDodReceipt
    for path in sorted(Path('drift/dod_receipts/OMN-10344').glob('*/command.yaml')):
    ModelDodReceipt.model_validate(yaml.safe_load(path.read_text()))
    print(f'[OK] {path}')
    PY
  • uv run python -m omnibase_core.validation.receipt_gate_cli --pr-body 'Closes OMN-10344

Central OCC evidence for omnibase_infra PR #1466.' --contracts-dir contracts --receipts-dir drift/dod_receipts

  • pre-commit hooks during commit: passed

Note: optional receipt gate --reexecute-probes was attempted, but the local process spun CPU and was stopped. The normal receipt gate and manual probe grep checks passed.

Summary by CodeRabbit

Release Notes

  • Chores
    • Implemented automated testing and validation framework with multiple verification checkpoints to ensure service compatibility, test execution standards, and dependency integrity.

@github-actions
github-actions Bot enabled auto-merge April 29, 2026 21:52
@coderabbitai

coderabbitai Bot commented Apr 29, 2026 •

Copy link
Copy Markdown

Warning

Rate limit exceeded

@jonahgabriel has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 2 minutes and 56 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 32a352c2-a12c-4494-8995-8b3ad13eaad1

📥 Commits

Reviewing files that changed from the base of the PR and between bbd1dbf and d092b8b.

📒 Files selected for processing (1)
  • drift/dod_receipts/OMN-10344/dod-003/command.yaml
📝 Walkthrough

Walkthrough

Introduces a new contract file for OMN-10344 defining evidence requirements for pytest execution with conditional Kafka e2e skipping, Docker Compose e2e deployment, and PR merge verification, along with three corresponding receipt files documenting the results of each evidence check.

Changes

Cohort / File(s) Summary
OMN-10344 Contract Definition
contracts/OMN-10344.yaml
Establishes schema, ticket metadata, and three evidence items (dod-001, dod-002, dod-003) with command-level checks for pytest, Docker Compose e2e, and PR merge verification.
OMN-10344 Evidence Receipts
drift/dod_receipts/OMN-10344/dod-00[1-3]/command.yaml
Three receipt files recording execution results: dod-001 captures pytest run with Kafka tests skipped, dod-002 documents Docker daemon connectivity failure, dod-003 verifies PR #1466 merge status on GitHub.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Contracts and proofs, so neat and fine,
Evidence receipts in perfect line,
Kafka tests skip when the winds are cold,
Docker dreams and PR stories told,
A rabbit hops through the proof parade! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'evidence(OMN-10344): add cost observability receipts' directly and clearly describes the main change—adding contract and evidence receipts for cost observability work. It is concise, specific, and aligned with the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-10344-occ-evidence

Review rate limit: 0/5 reviews remaining, refill in 2 minutes and 56 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@drift/dod_receipts/OMN-10344/dod-003/command.yaml`:
- Around line 9-19: The commit_sha field currently holds the merge commit
(d13ca057ee0be772b3ac59f2a3d9c832206946ba); update the commit_sha value to the
attested PR head commit (25249eb5945a7a6b6f7e1756cbdde4efc8e82dca) so commit_sha
matches the head SHA shown in actual_output/probe_stdout and follows the
cross-repo DoD receipt requirement.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e66dfcae-5620-4d7a-ad39-d9413900787d

📥 Commits

Reviewing files that changed from the base of the PR and between ef8ffb8 and bbd1dbf.

📒 Files selected for processing (4)
  • contracts/OMN-10344.yaml
  • drift/dod_receipts/OMN-10344/dod-001/command.yaml
  • drift/dod_receipts/OMN-10344/dod-002/command.yaml
  • drift/dod_receipts/OMN-10344/dod-003/command.yaml

Comment thread drift/dod_receipts/OMN-10344/dod-003/command.yaml Outdated
@jonahgabriel
jonahgabriel added this pull request to the merge queue Apr 29, 2026
Merged via the queue into main with commit 6a30664 Apr 29, 2026
24 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-10344-occ-evidence branch April 29, 2026 22:07
jonahgabriel added a commit that referenced this pull request May 7, 2026
…udit

* chore(OMN-10589): add contract and receipts for contract config audit

Central contract + PASS receipts for:
  - dod-001: audit script writes 153 rows (19 config_free, 124 config_required, 10 needs_review)
  - dod-002: 8 unit tests cover classification, CSV/MD emission, repo-wide run
  - dod-occ-pr: this OCC PR

Backing omnimarket PR #549.

* fix(OMN-10589): correct OCC PR number in dod-occ-pr receipt

* fix(OMN-10589): bind OCC receipts to contract PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant