Skip to content

evidence(OMN-13902): bind omniintelligence sibling lock refresh - #4599

Merged
jonahgabriel merged 1 commit into
devfrom
codex-letter/omn-13902-oi800-sibling-lock-occ-dev
Jul 22, 2026
Merged

jonahgabriel merged 1 commit into
devfrom
codex-letter/omn-13902-oi800-sibling-lock-occ-dev

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Jul 22, 2026 •

Copy link
Copy Markdown
Contributor

Refs OMN-13902

Evidence-Ticket: OMN-13902
Evidence-Source: manual-codex

Summary

Verification

  • uv run pre-commit run --files contracts/OMN-13902.yaml drift/dod_receipts/OMN-13902/dod-omniintelligence-pr-800-lock-refresh/command.yaml

Summary by CodeRabbit

  • Documentation
    • Updated OMN-13902 verification records with refreshed evidence bindings for OCC pull requests.
    • Added verification evidence for the omniintelligence lock-refresh change.
    • Added successful receipt records confirming the referenced pull requests and their verification status.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026 •

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

OMN-13902 evidence bindings now include rebound OCC checks, an omniintelligence sibling-lock-refresh consumer, and its OCC self-bind. New command receipts record passing verification results for the associated pull requests.

Changes

OMN-13902 evidence refresh

Layer / File(s) Summary
Evidence contract bindings
contracts/OMN-13902.yaml
Adds rebound evidence for OCC PRs 4320 and 4371, plus sibling-lock-refresh evidence for omniintelligence PR 800 and OCC PR 4599.
Command verification receipts
drift/dod_receipts/OMN-13902/*/command.yaml
Adds PASS receipts with probe output and execution metadata for PRs 800, 4320, 4371, and 4599.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: binding OMN-13902 evidence for the omniintelligence sibling lock refresh.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex-letter/omn-13902-oi800-sibling-lock-occ-dev

Comment @coderabbitai help to get the list of available commands.

@jonahgabriel
jonahgabriel force-pushed the codex-letter/omn-13902-oi800-sibling-lock-occ-dev branch from 5c441f1 to 6818063 Compare July 22, 2026 07:44
@jonahgabriel
jonahgabriel force-pushed the codex-letter/omn-13902-oi800-sibling-lock-occ-dev branch from 6818063 to 5e536b0 Compare July 22, 2026 07:49
@jonahgabriel
jonahgabriel force-pushed the codex-letter/omn-13902-oi800-sibling-lock-occ-dev branch from 5e536b0 to abc0286 Compare July 22, 2026 07:52

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@drift/dod_receipts/OMN-13902/dod-omniintelligence-pr-800-lock-refresh/command.yaml`:
- Line 6: Replace the self-referential check_value in the receipt with the exact
canonical gh pr view probe specified by the OMN-13902 contract, preserving the
command text exactly so the receipt verifies the bound external evidence.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cf041c44-9e4d-460b-ac4e-7b5e54652566

📥 Commits

Reviewing files that changed from the base of the PR and between d082e6a and abc0286.

📒 Files selected for processing (5)
  • contracts/OMN-13902.yaml
  • drift/dod_receipts/OMN-13902/dod-omniintelligence-pr-800-lock-refresh/command.yaml
  • drift/dod_receipts/OMN-13902/occ-self-bind-pr-4320-rebound/command.yaml
  • drift/dod_receipts/OMN-13902/occ-self-bind-pr-4371-rebound/command.yaml
  • drift/dod_receipts/OMN-13902/occ-self-bind-pr-4599/command.yaml

ticket_id: "OMN-13902"
evidence_item_id: "dod-omniintelligence-pr-800-lock-refresh"
check_type: "command"
check_value: "grep -q '^status: PASS$' drift/dod_receipts/OMN-13902/dod-omniintelligence-pr-800-lock-refresh/command.yaml"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Align the receipt check with the bound contract command.

The contract entry in contracts/OMN-13902.yaml Lines 357-359 binds this evidence to the gh pr view probe, but Line 6 records only a self-referential grep of the receipt’s own PASS status. Use the exact canonical gh pr view command here so the receipt attests to the same external verification as the contract.

Proposed fix
-check_value: "grep -q '^status: PASS$' drift/dod_receipts/OMN-13902/dod-omniintelligence-pr-800-lock-refresh/command.yaml"
+check_value: "PRODUCT_PR_NUMBER=800; PRODUCT_REPO=OmniNode-ai/omniintelligence; gh pr view $PRODUCT_PR_NUMBER --repo $PRODUCT_REPO --json number,headRefOid,headRefName,baseRefName,title,changedFiles,additions,deletions"

Based on the supplied contract/receipt cross-check.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
check_value: "grep -q '^status: PASS$' drift/dod_receipts/OMN-13902/dod-omniintelligence-pr-800-lock-refresh/command.yaml"
check_value: "PRODUCT_PR_NUMBER=800; PRODUCT_REPO=OmniNode-ai/omniintelligence; gh pr view $PRODUCT_PR_NUMBER --repo $PRODUCT_REPO --json number,headRefOid,headRefName,baseRefName,title,changedFiles,additions,deletions"
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@drift/dod_receipts/OMN-13902/dod-omniintelligence-pr-800-lock-refresh/command.yaml`
at line 6, Replace the self-referential check_value in the receipt with the
exact canonical gh pr view probe specified by the OMN-13902 contract, preserving
the command text exactly so the receipt verifies the bound external evidence.

@jonahgabriel
jonahgabriel merged commit 8736691 into dev Jul 22, 2026
62 checks passed
@jonahgabriel
jonahgabriel deleted the codex-letter/omn-13902-oi800-sibling-lock-occ-dev branch July 22, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant