Repository navigation
evidence(OMN-14376): OCC companion for omnibase_infra PR 2261 - #3980
Conversation
Independent adversarial verification (verifier=sc-reconcile, runner= bus-fix-14376) of the delegate-default-bus fix: 39/39 focused tests green, two RED->GREEN mutation proofs (probe-then-select branching, bare-bootstrap usage-error guard incl. a custom differs-from-env scenario beyond the PR's own 2 tests) confirm real coverage, ruff clean. Deploy assessment: CLI-only diff, no live deploy/.201 mutation.
Add-only self-binding receipt for occ-preflight eligibility, ahead of the OCC PR number existing.
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 24 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
Net-new OCC companion for OMN-14376 (default onex delegate to the system-configured event bus,
omnibase_infra#2261).Authored under the OMN-14055-sanctioned independent-verifier escape hatch (verifier != implementer):
sc-reconcileindependently verified this PR — read the full diff, checked out the branch in an isolated worktree, ran the full focused suite green (39/39), then performed two RED->GREEN mutation proofs.runner: bus-fix-14376(the session lane that built #2261, perdocs/tracking/ROLLING_WORK_LEDGER.md),verifier: sc-reconcile(independent).Mutation proof 1 (probe-then-select branching in
resolve_default_bus): forcing it to always return"kafka"regardless of probe health broke 5 of 8 targeted tests. Mutation proof 2 (bare--kafka-bootstrapusage-error guard): removing the guard did NOT break the PR's own 2 dedicated tests (a pre-existing downstreambuild_backend_overridesguard catches the "env unset" case redundantly), so a third hand-written scenario was run directly againstrun_delegatewithKAFKA_BOOTSTRAP_SERVERSset to a broker different from an explicitly-passedkafka_bootstrapand--busomitted — the mutated code silently resolved via the env broker with no error, the original code correctly raisedValueError. This confirms the guard is real and load-bearing; noted as a minor test-coverage gap in the PR's own suite, not a functional defect.contracts/OMN-14376.yaml— central contract, 3 dod_evidence itemsdrift/dod_receipts/OMN-14376/dod-omnibase-infra-pr-2261-head-c22182ed/command.yaml— product proof receiptdrift/dod_receipts/OMN-14376/dod-deploy-assessment-head-c22182ed/command.yaml— deploy-surface assessment (CLI-only diff, no live deploy)drift/dod_receipts/OMN-14376/dod-occ-self-commit/command.yaml— OCC self-binding receiptAll net-new files (OMN-13888 whole-file-hash rule); no existing receipt/contract edited.
Evidence-Ticket: OMN-14376
Test plan
uv run pre-commit run --files contracts/OMN-14376.yaml drift/dod_receipts/OMN-14376/**/*.yaml— all hooks green