Skip to content

evidence(OMN-14376): OCC companion for omnibase_infra PR 2261 - #3980

Merged
jonahgabriel merged 2 commits into
devfrom
jonah/omn-14376-occ-infra-2261
Jul 12, 2026
Merged

jonahgabriel merged 2 commits into
devfrom
jonah/omn-14376-occ-infra-2261

Conversation

@jonahgabriel

Copy link
Copy Markdown
Contributor

Summary

Net-new OCC companion for OMN-14376 (default onex delegate to the system-configured event bus, omnibase_infra#2261).

Authored under the OMN-14055-sanctioned independent-verifier escape hatch (verifier != implementer): sc-reconcile independently verified this PR — read the full diff, checked out the branch in an isolated worktree, ran the full focused suite green (39/39), then performed two RED->GREEN mutation proofs. runner: bus-fix-14376 (the session lane that built #2261, per docs/tracking/ROLLING_WORK_LEDGER.md), verifier: sc-reconcile (independent).

Mutation proof 1 (probe-then-select branching in resolve_default_bus): forcing it to always return "kafka" regardless of probe health broke 5 of 8 targeted tests. Mutation proof 2 (bare --kafka-bootstrap usage-error guard): removing the guard did NOT break the PR's own 2 dedicated tests (a pre-existing downstream build_backend_overrides guard catches the "env unset" case redundantly), so a third hand-written scenario was run directly against run_delegate with KAFKA_BOOTSTRAP_SERVERS set to a broker different from an explicitly-passed kafka_bootstrap and --bus omitted — the mutated code silently resolved via the env broker with no error, the original code correctly raised ValueError. This confirms the guard is real and load-bearing; noted as a minor test-coverage gap in the PR's own suite, not a functional defect.

  • contracts/OMN-14376.yaml — central contract, 3 dod_evidence items
  • drift/dod_receipts/OMN-14376/dod-omnibase-infra-pr-2261-head-c22182ed/command.yaml — product proof receipt
  • drift/dod_receipts/OMN-14376/dod-deploy-assessment-head-c22182ed/command.yaml — deploy-surface assessment (CLI-only diff, no live deploy)
  • drift/dod_receipts/OMN-14376/dod-occ-self-commit/command.yaml — OCC self-binding receipt

All net-new files (OMN-13888 whole-file-hash rule); no existing receipt/contract edited.

Evidence-Ticket: OMN-14376

Test plan

  • uv run pre-commit run --files contracts/OMN-14376.yaml drift/dod_receipts/OMN-14376/**/*.yaml — all hooks green
  • CI on this PR (occ-preflight, Contract Compliance, etc.)

Independent adversarial verification (verifier=sc-reconcile, runner=
bus-fix-14376) of the delegate-default-bus fix: 39/39 focused tests
green, two RED->GREEN mutation proofs (probe-then-select branching,
bare-bootstrap usage-error guard incl. a custom differs-from-env
scenario beyond the PR's own 2 tests) confirm real coverage, ruff
clean. Deploy assessment: CLI-only diff, no live deploy/.201 mutation.
Add-only self-binding receipt for occ-preflight eligibility, ahead of
the OCC PR number existing.
@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 24 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9c25e3ce-3599-4fe5-8dab-be07c150d36e

📥 Commits

Reviewing files that changed from the base of the PR and between 97e704f and b3c7501.

📒 Files selected for processing (4)
  • contracts/OMN-14376.yaml
  • drift/dod_receipts/OMN-14376/dod-deploy-assessment-head-c22182ed/command.yaml
  • drift/dod_receipts/OMN-14376/dod-occ-self-commit/command.yaml
  • drift/dod_receipts/OMN-14376/dod-omnibase-infra-pr-2261-head-c22182ed/command.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-14376-occ-infra-2261

Comment @coderabbitai help to get the list of available commands.

@jonahgabriel
jonahgabriel merged commit e357f27 into dev Jul 12, 2026
45 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-14376-occ-infra-2261 branch July 12, 2026 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant